Skip to content
This repository was archived by the owner on May 31, 2025. It is now read-only.

Enable caching of catkin_pkg.packages.find_packages when using roslaunch#542

Closed
garaemon wants to merge 2 commits intoros:hydro-develfrom
garaemon:cache-result-of-find-packages
Closed

Enable caching of catkin_pkg.packages.find_packages when using roslaunch#542
garaemon wants to merge 2 commits intoros:hydro-develfrom
garaemon:cache-result-of-find-packages

Conversation

@garaemon
Copy link
Copy Markdown

@garaemon garaemon commented Dec 31, 2014

patch for #541

@ros-pull-request-builder
Copy link
Copy Markdown
Member

ros-pull-request-builder commented Dec 31, 2014

Can one of the admins verify this patch?

@garaemon garaemon mentioned this pull request Dec 31, 2014
Closed
@tfoote tfoote mentioned this pull request Jan 9, 2015
Closed
@dirk-thomas
Copy link
Copy Markdown
Member

dirk-thomas commented Jan 15, 2015

Please consider to update the PR according to the comment made on the related PR ros/catkin#704 (comment)

@garaemon
Use source_path_to_packages keyword argument of
3d0fc19 
catkin.find_in_workspaces.find_in_workspaces to cache packages in catkin
workspaces and add _catkin_packages_cache global variables to several modules
dirk-thomas
dirk-thomas reviewed Jan 21, 2015
View reviewed changes
tools/roslaunch/src/roslaunch/__init__.py
Copy link
Copy Markdown
Member

@dirk-thomas dirk-thomas Jan 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accessing private variables is not recommended.

wkentaro added a commit to wkentaro/ros_comm that referenced this pull request Sep 29, 2015
@wkentaro
Cache result of path findings
fccb7cc 
This is for faster roslaunch's node launching.

Closes ros#541
Closes ros#542
wkentaro added a commit to wkentaro/ros_comm that referenced this pull request Sep 29, 2015
@wkentaro
Cache result of path findings
347a8e0 
This is for faster roslaunch's node launching.

Closes ros#541
Closes ros#542
@wkentaro wkentaro mentioned this pull request Sep 29, 2015
Merged
@wkentaro
Copy link
Copy Markdown
Contributor

wkentaro commented Sep 29, 2015

@dirk-thomas
I sent PR with another implementation, so please review:

And it depends:

wkentaro added a commit to wkentaro/ros_comm that referenced this pull request Sep 29, 2015
@wkentaro
Cache result of path findings
c7c8c24 
This is for faster roslaunch's node launching.

Closes ros#541
Closes ros#542
wkentaro added a commit to wkentaro/ros_comm that referenced this pull request Sep 29, 2015
@wkentaro
Cache result of path findings
2424fcc 
This is for faster roslaunch's node launching.

Closes ros#541
Closes ros#542
wkentaro added a commit to wkentaro/ros_comm that referenced this pull request Sep 29, 2015
@wkentaro
Cache result of path findings
09d9fa1 
This is for faster roslaunch's node launching.

Closes ros#541
Closes ros#542
wkentaro added a commit to wkentaro/ros_comm that referenced this pull request Oct 8, 2015
@wkentaro
Cache result of path findings
10e7bc2 
This is for faster roslaunch's node launching.

Closes ros#541
Closes ros#542
wkentaro added a commit to wkentaro/ros_comm that referenced this pull request Oct 8, 2015
@wkentaro
Cache result of path findings
a59a6be 
This is for faster roslaunch's node launching.

Closes ros#541
Closes ros#542
wkentaro added a commit to wkentaro/ros_comm that referenced this pull request Oct 8, 2015
@wkentaro
Cache result of path findings
555882e 
This is for faster roslaunch's node launching.

Closes ros#541
Closes ros#542
wkentaro added a commit to wkentaro/ros_comm that referenced this pull request Oct 8, 2015
@wkentaro
Cache result of path findings
892245a 
This is for faster roslaunch's node launching.

Closes ros#541
Closes ros#542
wkentaro added a commit to wkentaro/ros_comm that referenced this pull request Oct 8, 2015
@wkentaro
Cache result of path findings
9a174e3 
This is for faster roslaunch's node launching.

Closes ros#541
Closes ros#542
wkentaro added a commit to wkentaro/ros_comm that referenced this pull request Oct 8, 2015
@wkentaro
Cache result of path findings
aaa7975 
This is for faster roslaunch's node launching.

Closes ros#541
Closes ros#542
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@garaemon @ros-pull-request-builder @dirk-thomas @wkentaro