This repository was archived by the owner on May 31, 2025. It is now read-only.
Add argument to find_in_workspaces in order to cache result of catkin_pkg.packages.find_packages#704
Closed
garaemon wants to merge 1 commit intoros:groovy-develfrom
Closed
Add argument to find_in_workspaces in order to cache result of catkin_pkg.packages.find_packages#704garaemon wants to merge 1 commit intoros:groovy-develfrom
garaemon wants to merge 1 commit intoros:groovy-develfrom
Conversation
cache result of catkin_pkg.packages.find_packages
Member
|
Adding this new argument as well as an internal cache seems to be not necessary. The function already has an optional argument |
Member
|
I will close this PR since as mentioned before the existing argument |
Author
|
Sure, I will update PR! |
cwecht
pushed a commit
to cwecht/catkin
that referenced
this pull request
Mar 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
patch for ros/ros_comm#541