This repository was archived by the owner on May 31, 2025. It is now read-only.
[roslib] Args for cache the result of path finding in catkin.find_in_workspaces#91
Closed
wkentaro wants to merge 1 commit intoros:indigo-develfrom
Closed
[roslib] Args for cache the result of path finding in catkin.find_in_workspaces#91wkentaro wants to merge 1 commit intoros:indigo-develfrom
wkentaro wants to merge 1 commit intoros:indigo-develfrom
Conversation
This was referenced Sep 29, 2015
[roslaunch] cache result of catkin_pkg.packages.find_packages to speed up roslaunch
ros/ros_comm#541
Closed
core/roslib/src/roslib/packages.py
Outdated
Member
There was a problem hiding this comment.
Please use the same documentation as in https://github.com/ros/catkin/blob/3b8a3b9607adff98ed32cfd3b6d6ea4aed647424/python/catkin/find_in_workspaces.py#L106
Same below.
Contributor
Author
There was a problem hiding this comment.
Ok. I amended the commit.
3f60082 to
49943ed
Compare
Contributor
Author
|
I updated the commit, so please review again. |
Member
|
Thank you. I have cherry-picked the patch to the jade-devel branch (a59b53a). But it will also be backported before the next Indigo patch release. |
Member
|
I have reverted the changes from this PR in favor of #95. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #74
For ros/ros_comm#676