Skip to content
This repository was archived by the owner on May 31, 2025. It is now read-only.

Add argument to toggle caching of catkin_pkg.packages.find_packages#74

Closed
garaemon wants to merge 2 commits intoros:hydro-develfrom
garaemon:cache-find-packages
Closed

Add argument to toggle caching of catkin_pkg.packages.find_packages#74
garaemon wants to merge 2 commits intoros:hydro-develfrom
garaemon:cache-find-packages

Conversation

@garaemon
Copy link
Copy Markdown

@garaemon garaemon commented Dec 31, 2014

patch for ros/ros_comm#541

@garaemon garaemon mentioned this pull request Dec 31, 2014
Closed
@dirk-thomas
Copy link
Copy Markdown
Member

dirk-thomas commented Jan 1, 2015

Please consider to update the PR to use the existing argument source_path_to_packages of the catkin_find function (see ros/catkin#704 (comment)).

@garaemon
use source_path_to_packages keyword argument of
7311aed 
catkin.find_in_workspaces.find_in_workspaces and add utility function to
create cache for source_path_to_packages keyword argument
dirk-thomas
dirk-thomas reviewed Jan 21, 2015
View reviewed changes
core/roslib/src/roslib/packages.py
Copy link
Copy Markdown
Member

@dirk-thomas dirk-thomas Jan 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic to iterate over the workspaces and finding packages in each of them is provided by catkin.find_in_workspaces and should be reused instead of being duplicated here.

@dirk-thomas
Copy link
Copy Markdown
Member

dirk-thomas commented Mar 20, 2015

If you are still interested in this feature it would be highly appreciated if you could update the PR based on the comments above.

@dirk-thomas dirk-thomas added this to the untargeted milestone Sep 17, 2015
wkentaro added a commit to wkentaro/ros that referenced this pull request Sep 29, 2015
@wkentaro
Args for cache the result of path finding in catkin.find_in_workspaces
fbecedb 
Closes ros#74
wkentaro added a commit to wkentaro/ros that referenced this pull request Sep 29, 2015
@wkentaro
Args for cache the result of path finding in catkin.find_in_workspaces
3f60082 
Closes ros#74
@wkentaro wkentaro mentioned this pull request Sep 29, 2015
Closed
@wkentaro
Copy link
Copy Markdown
Contributor

wkentaro commented Sep 29, 2015

@dirk-thomas
#91 is another implementation for this. Please review it.

The logic to iterate over the workspaces and finding packages in each of them is provided by catkin.find_in_workspaces and should be reused instead of being duplicated here.

Actually, I don't find the way to reuse function in catkin.find_in_workspaces so created another function.
ros/catkin#757

wkentaro added a commit to wkentaro/ros that referenced this pull request Oct 8, 2015
@wkentaro
Args for cache the result of path finding in catkin.find_in_workspaces
49943ed 
Closes ros#74
dirk-thomas pushed a commit that referenced this pull request Oct 9, 2015
@wkentaro @dirk-thomas
Args for cache the result of path finding in catkin.find_in_workspaces
2a65672 
Closes #74
evenator pushed a commit to evenator/ros that referenced this pull request Mar 2, 2016
@wkentaro @evenator
Args for cache the result of path finding in catkin.find_in_workspaces
c114220 
Closes ros#74
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

untargeted

Development

Successfully merging this pull request may close these issues.

3 participants

@garaemon @dirk-thomas @wkentaro