This repository was archived by the owner on May 31, 2025. It is now read-only.
[python] Collect path data which can be resused for find_in_workspaces #757
Closed
wkentaro wants to merge 2 commits intoros:indigo-develfrom
Closed
[python] Collect path data which can be resused for find_in_workspaces #757wkentaro wants to merge 2 commits intoros:indigo-develfrom
wkentaro wants to merge 2 commits intoros:indigo-develfrom
Conversation
This was referenced Sep 29, 2015
[roslaunch] cache result of catkin_pkg.packages.find_packages to speed up roslaunch
ros/ros_comm#541
Closed
Author
There was a problem hiding this comment.
Actually this function cannot be resused in find_in_workspaces() because find_in_workspaces() has first_matching_workspace_only arg.
And reusing can cause low performance for it, because this function see all workspaces and cannot stop after first match.
Member
There was a problem hiding this comment.
This function does not provide any new information over the existing catkin API. The algorithm calling the other existing API is trivial. Please move this function to ros/ros_comm#676 where it is being used.
Author
|
the all commits in this PR is not needed now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For ros/ros_comm#676