Skip to content

fix(docs): correct dead link in CodeSplittingGroup.tags JSDoc#9051

Merged
graphite-app[bot] merged 1 commit intomainfrom
04-10-fix_docs_correct_dead_link_in_codesplittinggroup.tags_jsdoc
Apr 10, 2026
Merged

fix(docs): correct dead link in CodeSplittingGroup.tags JSDoc#9051
graphite-app[bot] merged 1 commit intomainfrom
04-10-fix_docs_correct_dead_link_in_codesplittinggroup.tags_jsdoc

Conversation

@hyf0
Copy link
Copy Markdown
Member

@hyf0 hyf0 commented Apr 9, 2026

Summary

  • Fix dead link /guide/manual-code-splitting/in-depth/manual-code-splitting in JSDoc for CodeSplittingGroup.tags (packages/rolldown/src/options/output-options.ts:916)
  • This link is picked up by TypeDoc and generated into docs/reference/TypeAlias.CodeSplittingGroup.md, causing VitePress to fail the Netlify build with a dead link error

Context

The Netlify deploy preview for #9050 failed because VitePress detected a dead link in the auto-generated reference docs. The doc page lives at /in-depth/manual-code-splitting, not /guide/manual-code-splitting. Another @see link on line 567 of the same file already uses the correct path.

🤖 Generated with Claude Code

Copy link
Copy Markdown
Member Author

hyf0 commented Apr 9, 2026


How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 9, 2026

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit ed0f874
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/69d85d6b54218f0008f07537

@hyf0 hyf0 marked this pull request as ready for review April 9, 2026 16:28
Copilot AI review requested due to automatic review settings April 9, 2026 16:28
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the JSDoc reference for CodeSplittingGroup.tags to point to the correct manual code splitting documentation URL.

Changes:

  • Replaced a dead/outdated docs link in the CodeSplittingGroup.tags JSDoc @see reference.

Copy link
Copy Markdown
Member Author

hyf0 commented Apr 10, 2026

Merge activity

## Summary

- Fix dead link `/guide/manual-code-splitting` → `/in-depth/manual-code-splitting` in JSDoc for `CodeSplittingGroup.tags` (`packages/rolldown/src/options/output-options.ts:916`)
- This link is picked up by TypeDoc and generated into `docs/reference/TypeAlias.CodeSplittingGroup.md`, causing VitePress to fail the Netlify build with a dead link error

## Context

The Netlify deploy preview for #9050 failed because VitePress detected a dead link in the auto-generated reference docs. The doc page lives at `/in-depth/manual-code-splitting`, not `/guide/manual-code-splitting`. Another `@see` link on line 567 of the same file already uses the correct path.

🤖 Generated with [Claude Code](https://claude.com/claude-code)
@graphite-app graphite-app Bot force-pushed the 04-10-fix_docs_correct_dead_link_in_codesplittinggroup.tags_jsdoc branch from 42d4703 to ed0f874 Compare April 10, 2026 02:16
@graphite-app graphite-app Bot merged commit ed0f874 into main Apr 10, 2026
30 checks passed
@graphite-app graphite-app Bot deleted the 04-10-fix_docs_correct_dead_link_in_codesplittinggroup.tags_jsdoc branch April 10, 2026 02:21
graphite-app Bot pushed a commit that referenced this pull request Apr 10, 2026
## Summary

- Add a `docs-build` job to CI that runs the full docs pipeline (TypeDoc reference generation + VitePress build) to catch dead links and build errors before merge
- Add `docs-changes` path filter that triggers on changes to `docs/`, `packages/rolldown/src/**` (JSDoc comments feed TypeDoc), `packages/pluginutils/**`, and `pnpm-lock.yaml`
- Only runs when relevant files change (or on `main`), matching the existing CI pattern

## Context

The Netlify deploy preview for #9050 caught a dead link (`/guide/manual-code-splitting` → `/in-depth/manual-code-splitting`) that was only discovered after push. VitePress already has built-in dead link detection that fails the build, but this only ran on Netlify — not in the required CI checks. This adds it as a proper CI gate.

Fixed in #9051.

🤖 Generated with [Claude Code](https://claude.com/claude-code)
This was referenced Apr 15, 2026
shulaoda added a commit that referenced this pull request Apr 16, 2026
## [1.0.0-rc.16] - 2026-04-16

### 🚀 Features

- const enum cross-module inlining support (#8796) by @Dunqing
- implement module tagging system for code splitting (#9045) by @hyf0

### 🐛 Bug Fixes

- rolldown_plugin_vite_manifest: handle duplicate chunk names for CSS entries (#9059) by @sapphi-red
- improve error message for invalid return values in function options (#9125) by @shulaoda
- await async export-star init wrappers (#9101) by @thezzisu
- never panic during diagnostic emission (#9091) by @IWANABETHATGUY
- include array rest pattern in binding_identifiers (#9112) by @IWANABETHATGUY
- rolldown: set worker thread count with ROLLDOWN_WORKER_THREADS (#9086) by @fpotter
- rolldown_plugin_lazy_compilation: escape request ID in proxy modules (#9102) by @h-a-n-a
- treat namespace member access as side-effect-free (#9099) by @IWANABETHATGUY
- relax overly conservative side-effect leak check in chunk optimizer (#9085) by @IWANABETHATGUY
- runtime: release `cb` reference after `__commonJS` factory initialization (#9067) by @hyf0-agent
- `@__NO_SIDE_EFFECTS__` wrapper should not remove dynamic imports (#9075) by @IWANABETHATGUY
- rolldown_plugin_vite_import_glob: use POSIX path join/normalize for glob resolution (#9077) by @shulaoda
- emit REQUIRE_TLA error when require() loads a module with top-level await (#9071) by @jaehafe
- emit namespace declaration for empty modules in manual chunks (#8993) by @privatenumber
- rolldown_plugin_vite_import_glob: keep common base on path segment boundary (#9070) by @shulaoda
- prevent circular runtime helper imports during facade elimination (#8989) (#9057) by @IWANABETHATGUY
- correct circular dependency check in facade elimination (#9047) by @h-a-n-a
- docs: correct dead link in CodeSplittingGroup.tags JSDoc (#9051) by @hyf0
- emit DUPLICATE_SHEBANG warning when banner contains shebang (#9026) by @IWANABETHATGUY

### 🚜 Refactor

- use semantic reference flags for member write detection (#9060) by @Dunqing
- extract UsedSymbolRefs newtype wrapper (#9130) by @IWANABETHATGUY
- dedupe await wrapping in export-star init emit (#9119) by @IWANABETHATGUY
- calculate side-effect-free function symbols on demand (#9120) by @IWANABETHATGUY
- extract duplicated top-level await handling into shared helper (#9087) by @IWANABETHATGUY
- rolldown_plugin_vite_import_glob: use split_first for get_common_base (#9069) by @shulaoda
- simplify ESM init deduplication with idiomatic insert check (#9044) by @IWANABETHATGUY

### 📚 Documentation

- document runtime module placement strategy in code-splitting design (#9062) by @IWANABETHATGUY
- clarify `options` hook behavior difference with Rollup in watch mode (#9053) by @sapphi-red
- meta/design: introduce module tags (#9017) by @hyf0

### ⚡ Performance

- convert `generate_transitive_esm_init` to iterative (#9046) by @IWANABETHATGUY

### 🧪 Testing

- merge strict/non_strict test variants using configVariants (#9089) by @IWANABETHATGUY

### ⚙️ Miscellaneous Tasks

- disable Renovate auto-updates for oxc packages (#9129) by @IWANABETHATGUY
- upgrade oxc@0.126.0 (#9127) by @Dunqing
- deps: update napi to v3.8.5 (#9126) by @renovate[bot]
- deps: update dependency @napi-rs/cli to v3.6.2 (#9123) by @renovate[bot]
- move lazy-compilation design doc (#9117) by @h-a-n-a
- deps: update dependency vite-plus to v0.1.18 (#9118) by @renovate[bot]
- deps: update dependency vite-plus to v0.1.17 (#9113) by @renovate[bot]
- deps: update oxc to v0.125.0 (#9094) by @renovate[bot]
- deps: update dependency follow-redirects to v1.16.0 [security] (#9103) by @renovate[bot]
- deps: update test262 submodule for tests (#9097) by @sapphi-red
- deps: update crate-ci/typos action to v1.45.1 (#9096) by @renovate[bot]
- deps: update rust crates (#9081) by @renovate[bot]
- deps: update npm packages (#9080) by @renovate[bot]
- remove outdated TODO in determine_module_exports_kind (#9072) by @jaehafe
- rust/test: support `extendedTests: false` shorthand in test config (#9050) by @hyf0
- ci: extract shared infra-changes anchor in path filters (#9054) by @hyf0
- add docs build check to catch dead links in PRs (#9052) by @hyf0

### ❤️ New Contributors

* @thezzisu made their first contribution in [#9101](#9101)
* @fpotter made their first contribution in [#9086](#9086)
* @jaehafe made their first contribution in [#9071](#9071)
* @privatenumber made their first contribution in [#8993](#8993)

Co-authored-by: shulaoda <165626830+shulaoda@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants