revert: fix(rolldown): increase tokio blocking threads size for watch mode by hyf0 · Pull Request #8517 · rolldown/rolldown

hyf0 · 2026-03-02T07:13:43Z

This PR reverts the fix #6467 becuase the previous issued watch mode implementation.

hyf0 · 2026-03-02T07:14:10Z

How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull request overview

This PR simplifies CLI startup by initializing the NAPI-provided Tokio runtime unconditionally as early as possible, aiming to standardize on the default “4 blocking threads” configuration.

Changes:

Removed --watch/-w detection logic that previously selected different Tokio runtime configurations.
Switched to calling createTokioRuntime() with no explicit thread argument and added explanatory comments.

packages/rolldown/src/cli/setup-index.ts

netlify · 2026-03-02T12:45:20Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`2db94c4`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/69a5aeee902de80007544470

Copilot

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.

packages/rolldown/src/experimental-index.ts

crates/rolldown_binding/src/lib.rs

github-actions · 2026-03-02T14:47:37Z

Benchmarks Rust

target: main(6b868eb)
pr: 03-02-perf_init_tokio_runtime_with_4_blocking_threads(2db94c4)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.02     78.7±2.42ms        ? ?/sec    1.00     76.9±1.62ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.03     86.8±1.98ms        ? ?/sec    1.00     84.5±1.54ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    159.9±3.97ms        ? ?/sec    1.01    160.8±4.46ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.01    179.5±7.02ms        ? ?/sec    1.00    177.1±5.42ms        ? ?/sec
bundle/bundle@threejs                                        1.00     72.0±2.73ms        ? ?/sec    1.00     72.0±2.61ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.01     78.2±1.13ms        ? ?/sec    1.00     77.6±0.97ms        ? ?/sec
bundle/bundle@threejs10x                                     1.02   769.5±10.26ms        ? ?/sec    1.00    756.7±7.14ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.02    879.4±9.36ms        ? ?/sec    1.00    864.2±6.52ms        ? ?/sec
scan/scan@rome_ts                                            1.01     76.8±1.37ms        ? ?/sec    1.00     76.2±1.38ms        ? ?/sec
scan/scan@threejs                                            1.03     27.4±0.50ms        ? ?/sec    1.00     26.5±0.34ms        ? ?/sec
scan/scan@threejs10x                                         1.01    266.4±3.45ms        ? ?/sec    1.00    262.7±3.65ms        ? ?/sec

graphite-app · 2026-03-02T15:37:50Z

Merge activity

Mar 2, 3:37 PM UTC: hyf0 added this pull request to the Graphite merge queue.
Mar 2, 3:51 PM UTC: Merged by the Graphite merge queue.

… mode (#8517) This PR reverts the fix #6467 becuase the previous issued watch mode implementation.

@IWANABETHATGUY

## [1.0.0-rc.7] - 2026-03-05 ⚡ Smarter Code Generation Defaults - DCE-only minification and smart constant inlining are now enabled by default - Produces cleaner, smaller output bundles without requiring explicit configuration 💡 LLM-Friendly Bundle Analyzer Reports - New markdown output format for the bundle analyzer plugin with bundle summaries, module graphs, dependency chains, and optimization suggestions - Optimization suggestions now also recommend using the entriesAware option when common chunks contain modules only reachable from specific entries ### 💥 BREAKING CHANGES - enable minify: 'dce-only' by default (#8465) by @IWANABETHATGUY - settings `inlineConst: { mode: 'smart', pass: 1}` by default (#8444) by @IWANABETHATGUY ### 🚀 Features - binding: add original getter to BindingMagicString (#8533) by @IWANABETHATGUY - native-magic-string: add `offset` property support (#8531) by @IWANABETHATGUY - add `output.strict` option to control `"use strict"` directive emission (#8489) by @Copilot - watch: expose `watcher.compareContentsForPolling` (#8526) by @hyf0 - watch: use new watcher to support watch mode (#8475) by @hyf0 - rust/watch: handle bulk-change (#8466) by @hyf0 - add LLM-friendly markdown output format to bundle analyzer plugin (#8242) by @IWANABETHATGUY ### 🐛 Bug Fixes - expose `plugins` on `NormalizedInputOptions` for `buildStart` hook (#8521) by @Copilot - only uppercase facade symbols in JSX preserve mode (#8519) by @IWANABETHATGUY - binding: export BindingResult in generated dts header (#8537) by @minsoo-web - pre-resolve paths option to avoid `invoke_sync` deadlock (#8518) by @IWANABETHATGUY - remove debug-only jsx_preset and UntranspiledSyntaxError (#8511) by @IWANABETHATGUY - apply `topLevelVar` to exported `const`/`let` declarations (#8507) by @IWANABETHATGUY - rolldown_plugin_vite_web_worker_post: avoid replacing `new.target` (#8488) by @sapphi-red - update copyright year to 2026 (#8486) by @maciekzygmunt ### 🚜 Refactor - rust: use Oxc's SymbolFlags::ConstVariable instead of custom IsConst flag (#8543) by @Dunqing - rust: remove FacadeScoping, use Scoping::create_symbol for facade symbols (#8540) by @Dunqing - rust/watch: remove hacky `reset_closed_for_watch_mode` (#8530) by @hyf0 - binding: return &str instead of String in filename() getter (#8534) by @IWANABETHATGUY - rust: remove old watch mode implementation (#8525) by @hyf0 - rust/watch: simply watch logic in the binding layer (#8516) by @hyf0 - rust/watch: tweak struct/function names (#8464) by @hyf0 ### 📚 Documentation - explain how external modules work in rolldown (#8457) by @sapphi-red - add some diagrams using graphviz (#8499) by @sapphi-red - use `vitepress-plugin-graphviz` (#8498) by @sapphi-red - list s390x/ppc64le prebuilt binaries (#8495) by @crusty-voidzero - fix error type for `RolldownBuild.generate` and others (#8490) by @sapphi-red ### ⚡ Performance - string_wizard: reduce allocations and add ASCII fast paths (#8541) by @IWANABETHATGUY - use IndexBitSet to replace IndexVec<XXXIdx, bool> for module/stmt inclusion tracking (#8503) by @IWANABETHATGUY - plugin: use IndexBitSet to optimize skipped plugins checking (#8497) by @ShroXd - rust/tla: skip compute_tla if there is no module use TLA (#8487) by @ShroXd ### 🧪 Testing - node/watch: make watch tests run in concurrent and retry-able (#8512) by @hyf0 - add test case for static flag tree-shaking (#8476) by @IWANABETHATGUY - migrate post-banner sourcemap-with-shebang to Rust (#8477) by @Copilot ### ⚙️ Miscellaneous Tasks - vscode: `formatOnSave` for markdown files using oxc formatter (#8536) by @minsoo-web - deps: update test262 submodule for tests (#8528) by @sapphi-red - remove `retry` workaround from output paths test fixtures (#8520) by @Copilot - docs: add Shuyuan Wang (h-a-n-a) and remove from acknowledgements (#8509) by @Copilot - consolidate top_level_var test cases using configVariants (#8508) by @IWANABETHATGUY - add s390x and ppc64le linux gnu targets (#8493) by @Brooooooklyn ### ◀️ Revert - fix(rolldown): increase tokio blocking threads size for watch mode (#8517) by @hyf0 ### ❤️ New Contributors * @minsoo-web made their first contribution in [#8536](#8536) * @crusty-voidzero made their first contribution in [#8495](#8495) * @maciekzygmunt made their first contribution in [#8486](#8486) Co-authored-by: shulaoda <165626830+shulaoda@users.noreply.github.com>

hyf0 marked this pull request as ready for review March 2, 2026 07:13

github-actions bot assigned hyf0 Mar 2, 2026

Copilot AI review requested due to automatic review settings March 2, 2026 07:13

Copilot started reviewing on behalf of hyf0 March 2, 2026 07:14 View session

hyf0 changed the title ~~perf: init tokio runtime with 4 blocking threads~~ perf(cli): init tokio runtime with 4 blocking threads always Mar 2, 2026

Copilot AI reviewed Mar 2, 2026

View reviewed changes

packages/rolldown/src/cli/setup-index.ts Outdated Show resolved Hide resolved

packages/rolldown/src/cli/setup-index.ts Outdated Show resolved Hide resolved

packages/rolldown/src/cli/setup-index.ts Outdated Show resolved Hide resolved

hyf0 marked this pull request as draft March 2, 2026 07:42

hyf0 force-pushed the 03-02-refactor_rust_watch_simply_watch_logic_in_the_binding_layer branch from cb1e1fe to 847093e Compare March 2, 2026 11:56

hyf0 force-pushed the 03-02-perf_init_tokio_runtime_with_4_blocking_threads branch from 7db4ea8 to 1a49f89 Compare March 2, 2026 11:56

graphite-app bot changed the base branch from 03-02-refactor_rust_watch_simply_watch_logic_in_the_binding_layer to graphite-base/8517 March 2, 2026 12:33

graphite-app bot force-pushed the 03-02-perf_init_tokio_runtime_with_4_blocking_threads branch from 1a49f89 to 0c650b5 Compare March 2, 2026 12:43

graphite-app bot force-pushed the graphite-base/8517 branch from 847093e to 6b868eb Compare March 2, 2026 12:43

graphite-app bot changed the base branch from graphite-base/8517 to main March 2, 2026 12:43

graphite-app bot force-pushed the 03-02-perf_init_tokio_runtime_with_4_blocking_threads branch from 0c650b5 to 1248ae8 Compare March 2, 2026 12:44

hyf0 force-pushed the 03-02-perf_init_tokio_runtime_with_4_blocking_threads branch from 1248ae8 to f838133 Compare March 2, 2026 12:59

hyf0 changed the title ~~perf(cli): init tokio runtime with 4 blocking threads always~~ revert: fix(rolldown): increase tokio blocking threads size for watch mode Mar 2, 2026

hyf0 marked this pull request as ready for review March 2, 2026 14:31

Copilot AI review requested due to automatic review settings March 2, 2026 14:31

Copilot started reviewing on behalf of hyf0 March 2, 2026 14:32 View session

Copilot AI reviewed Mar 2, 2026

View reviewed changes

packages/rolldown/src/experimental-index.ts Show resolved Hide resolved

crates/rolldown_binding/src/lib.rs Show resolved Hide resolved

shulaoda approved these changes Mar 2, 2026

View reviewed changes

This was referenced Mar 2, 2026

refactor(rust): remove old watch mode implementation #8525

Merged

Watch mode issue collection #6482

Open

feat(watch): expose watcher.compareContentsForPolling #8526

Merged

revert: fix(rolldown): increase tokio blocking threads size for watch…

2db94c4

… mode (#8517) This PR reverts the fix #6467 becuase the previous issued watch mode implementation.

graphite-app bot force-pushed the 03-02-perf_init_tokio_runtime_with_4_blocking_threads branch from f838133 to 2db94c4 Compare March 2, 2026 15:38

graphite-app bot merged commit 2db94c4 into main Mar 2, 2026
35 checks passed

graphite-app bot deleted the 03-02-perf_init_tokio_runtime_with_4_blocking_threads branch March 2, 2026 15:51

IWANABETHATGUY mentioned this pull request Mar 3, 2026

feat(native-magic-string): add offset property support #8531

Merged

This was referenced Mar 4, 2026

release: v1.0.0-rc.7 #8539

Closed

release: v1.0.0-rc.7 #8547

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

revert: fix(rolldown): increase tokio blocking threads size for watch mode#8517

revert: fix(rolldown): increase tokio blocking threads size for watch mode#8517
graphite-app[bot] merged 1 commit intomainfrom
03-02-perf_init_tokio_runtime_with_4_blocking_threads

hyf0 commented Mar 2, 2026 •

edited

Loading

Uh oh!

hyf0 commented Mar 2, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

netlify bot commented Mar 2, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 2, 2026 •

edited

Loading

Uh oh!

graphite-app bot commented Mar 2, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

hyf0 commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hyf0 commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

netlify bot commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Rust

Uh oh!

graphite-app bot commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hyf0 commented Mar 2, 2026 •

edited

Loading

hyf0 commented Mar 2, 2026 •

edited

Loading

netlify bot commented Mar 2, 2026 •

edited

Loading

github-actions bot commented Mar 2, 2026 •

edited

Loading

graphite-app bot commented Mar 2, 2026 •

edited

Loading