Skip to content

feat: enable minify: 'dce-only' by default#8465

Merged
graphite-app[bot] merged 1 commit intomainfrom
02-25-feat_enable_minify_dce-only_by_default
Feb 27, 2026
Merged

feat: enable minify: 'dce-only' by default#8465
graphite-app[bot] merged 1 commit intomainfrom
02-25-feat_enable_minify_dce-only_by_default

Conversation

@IWANABETHATGUY
Copy link
Member

@IWANABETHATGUY IWANABETHATGUY commented Feb 25, 2026

Closed #7235

failed-tests.json — Added 4 new entries (DCE-only default causes output differences):

  • rollup@form@export-globals — DCE removes intermediate variable
  • rollup@form@preserves-comments-after-imports — DCE inlines constant into object literal
  • rollup@form@reexport-self — DCE inlines constant into console.log()
  • rollup@sourcemaps@names-transformed-render-chunk — DCE changes code structure, breaking sourcemap test regex

Copy link
Member Author

IWANABETHATGUY commented Feb 25, 2026


How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@hyf0
Copy link
Member

hyf0 commented Feb 25, 2026

What's the context of making this option default?

@IWANABETHATGUY IWANABETHATGUY force-pushed the 02-25-feat_enable_minify_dce-only_by_default branch from 0484889 to 9f0baa0 Compare February 25, 2026 16:27
@IWANABETHATGUY IWANABETHATGUY force-pushed the 02-24-feat_enable_inlineconst_by_default branch from fa89fa5 to 84f3f34 Compare February 25, 2026 16:27
@IWANABETHATGUY
Copy link
Member Author

What's the context of making this option default?

related to #7235

@graphite-app graphite-app bot force-pushed the 02-24-feat_enable_inlineconst_by_default branch 2 times, most recently from d7d0bd0 to ed1a048 Compare February 26, 2026 06:00
@IWANABETHATGUY IWANABETHATGUY force-pushed the 02-25-feat_enable_minify_dce-only_by_default branch from 9f0baa0 to 0bf6d96 Compare February 26, 2026 09:18
@IWANABETHATGUY IWANABETHATGUY force-pushed the 02-24-feat_enable_inlineconst_by_default branch from ed1a048 to 1932cb3 Compare February 26, 2026 09:18
@IWANABETHATGUY IWANABETHATGUY force-pushed the 02-25-feat_enable_minify_dce-only_by_default branch 2 times, most recently from 4b105f5 to bae5c3d Compare February 26, 2026 10:35
@IWANABETHATGUY IWANABETHATGUY force-pushed the 02-24-feat_enable_inlineconst_by_default branch from 1932cb3 to 0d89919 Compare February 26, 2026 12:09
@graphite-app graphite-app bot changed the base branch from 02-24-feat_enable_inlineconst_by_default to graphite-base/8465 February 26, 2026 12:20
@graphite-app graphite-app bot force-pushed the 02-25-feat_enable_minify_dce-only_by_default branch from bae5c3d to 169d6e0 Compare February 26, 2026 12:33
@graphite-app graphite-app bot force-pushed the graphite-base/8465 branch from 0d89919 to caa971d Compare February 26, 2026 12:33
@graphite-app graphite-app bot changed the base branch from graphite-base/8465 to main February 26, 2026 12:34
@graphite-app graphite-app bot force-pushed the 02-25-feat_enable_minify_dce-only_by_default branch from 169d6e0 to 74922ca Compare February 26, 2026 12:34
@netlify
Copy link

netlify bot commented Feb 26, 2026

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit e35d082
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/69a123acc285db00087d5712

@IWANABETHATGUY IWANABETHATGUY force-pushed the 02-25-feat_enable_minify_dce-only_by_default branch from 74922ca to 0f75c95 Compare February 26, 2026 13:57
@IWANABETHATGUY IWANABETHATGUY changed the title feat: enable minify: 'dce-only' by default feat!: enable minify: 'dce-only' by default Feb 26, 2026
@IWANABETHATGUY IWANABETHATGUY changed the title feat!: enable minify: 'dce-only' by default feat!: enable minify: 'dce-only' by default Feb 26, 2026
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review February 26, 2026 14:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables minify: "dce-only" as the default behavior and updates esbuild snapshot fixtures to reflect the new output.

Changes:

  • Adjust code generation comment preservation behavior when whitespace is not removed.
  • Update a large set of esbuild snapshot artifacts/diffs to match output changes introduced by DCE-only default minification.

Reviewed changes

Copilot reviewed 299 out of 1420 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
crates/rolldown/src/stages/generate_stage/minify_chunks.rs Tweaks comment emission logic in codegen based on remove_whitespace.
crates/rolldown/tests/esbuild/default/reserve_props/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/require_without_call_inside_try/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/require_without_call/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/require_with_template/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/require_with_call_inside_try/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/require_txt/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/require_shim_substitution/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/require_resolve/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/require_property_access_common_js/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/require_parent_dir_es6/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/require_parent_dir_common_js/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/require_main_cache_common_js/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/require_json/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/require_fs_node_minify/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/require_fs_node/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/require_fs_browser/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/require_child_dir_es6/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/require_child_dir_common_js/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/require_bad_argument_count/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/require_and_dynamic_import_invalid_template/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/rename_private_identifiers_no_bundle/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/rename_labels_no_bundle/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/relative_entry_point_error/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/re_export_fs_node/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/re_export_default_no_bundle_es6/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/re_export_default_no_bundle_common_js/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/re_export_default_no_bundle/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/re_export_default_internal/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/re_export_default_external_es6/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/re_export_default_external_common_js/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/re_export_common_js_as_es6/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/quoted_property/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/preserve_key_comment/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/output_extension_remapping_file/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/output_extension_remapping_dir/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/outbase/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/object_literal_proto_setter_edge_cases_minify_syntax/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/object_literal_proto_setter_edge_cases/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/non_determinism_issue2537/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/node_annotation_invalid_identifier_issue4100/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/node_annotation_false_positive_issue3544/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/no_warn_common_js_exports_in_esm_pass_through/diff.md Snapshot diff update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/no_warn_common_js_exports_in_esm_pass_through/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/no_overwrite_input_file_error/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/new_expression_common_js/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/nested_scope_bug/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/nested_require_without_call/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/nested_es6_from_common_js/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/nested_common_js/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/named_function_expression_argument_collision/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/multiple_entry_points_same_name_collision/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/minify_sibling_labels_no_bundle/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/minify_private_identifiers_no_bundle/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/minify_identifiers_import_path_frequency_analysis/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/minified_jsx_preserve_with_object_spread/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/minified_exports_and_module_format_common_js/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/minified_dynamic_import_with_expression_cjs/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/minified_bundle_es6/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/minified_bundle_ending_with_important_semicolon/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/minified_bundle_common_js/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/metafile_import_with_type_json/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/many_entry_points/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/mangle_quoted_props_minify_syntax/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/mangle_quoted_props/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/mangle_props_type_script_features/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/mangle_props_shorthand/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/mangle_props_optional_chain/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/mangle_props_no_shorthand/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/mangle_props_minify/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/mangle_props_lowered_optional_chain/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/mangle_props_lowered_class_fields/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/mangle_props_key_comment_minify/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/mangle_props_key_comment/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/mangle_props_jsx_transform_namespace/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/mangle_props_jsx_transform/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/mangle_props_jsx_preserve/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/mangle_props_import_export_bundled/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/mangle_props_import_export/diff.md Snapshot diff update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/mangle_props_import_export/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/mangle_props_avoid_collisions/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/mangle_props/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/mangle_no_quoted_props_minify_syntax/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/mangle_no_quoted_props/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/keep_names_tree_shaking/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/keep_names_class_static_name/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/jsx_this_value_esm/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/jsx_this_value_common_js/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/jsx_this_property_esm/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/jsx_this_property_common_js/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/jsx_syntax_in_js/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/jsx_imports_es6/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/jsx_imports_common_js/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/jsx_import_meta_value/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/jsx_import_meta_property/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/jsx_dev_self_edge_cases/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/jsx_constant_fragments/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/jsx_automatic_imports_es6/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/jsx_automatic_imports_common_js/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/inject_with_string_export_name_no_bundle/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/inject_with_string_export_name_bundle/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/inject_with_define/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/inject_no_bundle/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/inject_jsx_dot_names/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/inject_jsx/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/inject_import_ts/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/inject_import_order/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/inject_import_meta/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/inject_assign/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/inject/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/indirect_require_message/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/import_with_hash_in_path/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/import_then_catch/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/import_re_export_es6_issue149/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/import_namespace_this_value/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/import_missing_neither_es6_nor_common_js/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/import_missing_common_js/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/import_meta_no_bundle/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/import_meta_es6/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/import_meta_common_js/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/import_inside_try/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/import_fs_node_es6/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/import_fs_node_common_js/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/import_fs_browser/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/import_forms_with_no_bundle/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/import_forms_with_minify_identifiers_and_no_bundle/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/import_abs_path_with_query_parameter/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/iife_es5/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/hashbang_no_bundle/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/hashbang_bundle/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/hashbang_banner_use_strict_order/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/forbid_string_import_names_no_bundle/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/forbid_string_import_names_bundle/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/forbid_string_export_names_no_bundle/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/forbid_string_export_names_bundle/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/false_require/diff.md Snapshot diff update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/false_require/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/external_packages/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/external_module_exclusion_relative_path/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/external_module_exclusion_package/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/external_es6_converted_to_common_js/diff.md Snapshot diff update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/external_es6_converted_to_common_js/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/exports_and_module_format_common_js/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/export_wildcard_fs_node_es6/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/export_wildcard_fs_node_common_js/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/export_special_name_bundle/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/export_special_name/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/export_fs_node_in_common_js_module/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/export_fs_node/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/export_fs_browser/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/export_forms_with_minify_identifiers_and_no_bundle/diff.md Snapshot diff update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/export_forms_with_minify_identifiers_and_no_bundle/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/export_forms_iife/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/export_forms_es6/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/export_forms_common_js/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/export_chain/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/es6_from_common_js/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/empty_export_clause_bundle_as_common_js_issue910/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/dynamic_import_with_template_iife/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/dynamic_import_with_expression_cjs/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/duplicate_property_warning/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/duplicate_entry_point/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/dot_import/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/define_this/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/define_optional_chain_panic_issue3551/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/define_optional_chain_lowered/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/define_optional_chain/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/define_infinite_loop_issue2407/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/define_import_meta/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/define_assign_warning/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/decorator_printing_esm/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/decorator_printing_cjs/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/const_with_let_no_mangle/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/const_with_let_no_bundle/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/const_with_let/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/conditional_require_resolve/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/conditional_require/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/conditional_import/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/common_js_from_es6/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/comment_preservation_transform_jsx/diff.md Snapshot diff update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/comment_preservation_transform_jsx/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/comment_preservation_preserve_jsx/diff.md Snapshot diff update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/comment_preservation_preserve_jsx/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/char_freq_ignore_comments/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/call_import_namespace_warning/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/bundling_files_outside_of_outbase/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/bundle_esm_with_nested_var_issue4348/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/built_in_node_module_precedence/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/bad_import_error_message_with_handles_import_errors_flag/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/await_import_inside_try/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/avoid_tdz_no_bundle/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/avoid_tdz/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/auto_external_node/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/arrow_fn_scope/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/argument_default_value_scope_no_bundle/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/default/ambiguous_reexport_msg/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/tree_shaking_react_elements/diff.md Snapshot diff update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/tree_shaking_react_elements/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/tree_shaking_object_property/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/tree_shaking_no_bundle_iife/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/tree_shaking_no_bundle_esm/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/tree_shaking_no_bundle_cjs/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/tree_shaking_lowered_class_static_field_minified/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/tree_shaking_lowered_class_static_field_assignment/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/tree_shaking_lowered_class_static_field/diff.md Snapshot diff update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/tree_shaking_lowered_class_static_field/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/tree_shaking_in_esm_wrapper/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/tree_shaking_import_identifier/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/tree_shaking_class_static_property/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/tree_shaking_class_property/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/tree_shaking_binary_operators/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/top_level_function_inlining_with_spread/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/text_loader_remove_unused/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/remove_unused_pure_comment_calls/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/remove_unused_no_side_effects_tagged_templates/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/remove_unused_imports_eval_ts/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/remove_unused_imports_eval/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/remove_unused_import_meta/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/remove_trailing_return/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/pure_calls_with_spread/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/preserve_directives_minify_pass_through/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/preserve_directives_minify_iife/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/preserve_directives_minify_bundle/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/package_json_side_effects_true_keep_es6/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/package_json_side_effects_true_keep_common_js/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/package_json_side_effects_nested_directory_remove/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/package_json_side_effects_keep_export_default_expr/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/package_json_side_effects_false_remove_star_import_es6/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/package_json_side_effects_false_remove_star_import_common_js/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/package_json_side_effects_false_remove_named_import_es6/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/package_json_side_effects_false_remove_named_import_common_js/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/package_json_side_effects_false_remove_bare_import_es6/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/package_json_side_effects_false_remove_bare_import_common_js/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/package_json_side_effects_false_one_fork/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/package_json_side_effects_false_no_warning_in_node_modules_issue999/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/package_json_side_effects_false_keep_star_import_es6/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/package_json_side_effects_false_keep_star_import_common_js/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/package_json_side_effects_false_keep_named_import_es6/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/package_json_side_effects_false_keep_named_import_common_js/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/package_json_side_effects_false_keep_bare_import_and_require_es6/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/package_json_side_effects_false_keep_bare_import_and_require_common_js/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/package_json_side_effects_false_intermediate_files_used/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/package_json_side_effects_false_intermediate_files_diamond/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/package_json_side_effects_false_intermediate_files_chain_one/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/package_json_side_effects_false_intermediate_files_chain_all/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/package_json_side_effects_false_cross_platform_slash/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/package_json_side_effects_false_all_fork/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/package_json_side_effects_array_remove/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/package_json_side_effects_array_keep_module_use_module/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/package_json_side_effects_array_keep_module_use_main/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/package_json_side_effects_array_keep_module_implicit_module/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/package_json_side_effects_array_keep_main_use_module/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/package_json_side_effects_array_keep_main_use_main/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/package_json_side_effects_array_keep_main_implicit_module/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/package_json_side_effects_array_keep/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/package_json_side_effects_array_glob/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/no_side_effects_comment_unused_calls/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/no_side_effects_comment_minify_whitespace/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/no_side_effects_comment_ignore_annotations/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/nested_function_inlining_with_spread/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/json_loader_remove_unused/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/inline_function_call_for_init_decl/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/inline_function_call_behavior_changes/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/import_re_export_of_namespace_import/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/file_loader_remove_unused/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/drop_labels/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/drop_label_tree_shaking_bug_issue3311/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/disable_tree_shaking/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/dead_code_inside_empty_try/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/dead_code_following_jump/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/dce_var_exports/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/dce_type_of_equals_string_mangle/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/dce_type_of_equals_string_guard_condition/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/dce_type_of_equals_string/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/dce_type_of_compare_string_guard_condition/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/dce_template_literal/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/dce_of_using_declarations/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/dce_of_symbol_instances/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/dce_of_symbol_for_call/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/dce_of_symbol_ctor_call/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/dce_of_iterator_superclass_issue4310/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/dce_of_iife/diff.md Snapshot diff update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/dce_of_iife/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/dce_of_expr_after_keep_names_issue3195/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/dce_of_experimental_decorators/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/dce_of_destructuring/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/dce_of_decorators/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/dce_class_static_blocks_minify_syntax/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/dce_class_static_blocks/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/data_url_loader_remove_unused/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/cross_module_constant_folding_string/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/cross_module_constant_folding_number/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/cross_module_constant_folding_computed_property_name/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/const_value_inlining_no_bundle/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/const_value_inlining_direct_eval/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/const_value_inlining_bundle/artifacts.snap Snapshot update for DCE-only default output formatting.
crates/rolldown/tests/esbuild/dce/base64_loader_remove_unused/artifacts.snap Snapshot update for DCE-only default output formatting.
Comments suppressed due to low confidence (1)

crates/rolldown/tests/esbuild/default/keep_names_class_static_name/artifacts.snap:1

  • This snapshot now effectively asserts an empty output for keep_names_class_static_name, which no longer exercises the behavior the test name suggests (keeping class/static names). If the intent is still to validate keep_names behavior, consider updating the test input (or test configuration) so the relevant declarations are retained (e.g., make them observable/used, or run this fixture with minify/DCE disabled) instead of being eliminated by DCE-only.

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 26, 2026

Merging this PR will degrade performance by 38.96%

❌ 6 regressed benchmarks
✅ 2 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
bundle@threejs 180.9 ms 282.7 ms -36%
bundle@rome_ts 453.5 ms 636 ms -28.7%
bundle@threejs-sourcemap 212.8 ms 348.7 ms -38.96%
bundle@multi-duplicated-top-level-symbol 244.8 ms 287.1 ms -14.73%
bundle@rome_ts-sourcemap 518.7 ms 758.6 ms -31.63%
bundle@multi-duplicated-top-level-symbol-sourcemap 271 ms 335.1 ms -19.12%

Comparing 02-25-feat_enable_minify_dce-only_by_default (69cb98c) with main (caa971d)1

Open in CodSpeed

Footnotes

  1. No successful run was found on main (612f230) during the generation of this report, so caa971d was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@hyf0
Copy link
Member

hyf0 commented Feb 26, 2026

Considering about the benchmark, is it worth? For libaray author, if the optimization could be done by rolldown, them it could be done in the final app bundling step. For app, minifer will be enabled no matter how.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 26, 2026

Benchmarks Rust

  • target: main(612f230)
  • pr: 02-25-feat_enable_minify_dce-only_by_default(69cb98c)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.22     80.2±2.33ms        ? ?/sec    1.00     65.9±1.73ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.24     88.5±2.06ms        ? ?/sec    1.00     71.6±5.61ms        ? ?/sec
bundle/bundle@rome_ts                                        1.68    164.7±3.93ms        ? ?/sec    1.00     98.2±2.08ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.78    191.4±6.67ms        ? ?/sec    1.00    107.7±2.00ms        ? ?/sec
bundle/bundle@threejs                                        2.07     75.9±2.30ms        ? ?/sec    1.00     36.6±2.10ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              2.10     85.2±2.15ms        ? ?/sec    1.00     40.5±0.80ms        ? ?/sec
bundle/bundle@threejs10x                                     2.24   818.9±13.51ms        ? ?/sec    1.00    365.4±3.79ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           2.25   940.5±10.26ms        ? ?/sec    1.00    418.3±4.90ms        ? ?/sec
scan/scan@rome_ts                                            1.00     75.3±2.00ms        ? ?/sec    1.00     75.5±1.53ms        ? ?/sec
scan/scan@threejs                                            1.01     27.4±1.77ms        ? ?/sec    1.00     27.1±1.55ms        ? ?/sec
scan/scan@threejs10x                                         1.01    264.3±4.32ms        ? ?/sec    1.00    262.5±3.86ms        ? ?/sec

@IWANABETHATGUY
Copy link
Member Author

Considering about the benchmark, is it worth? For libaray author, if the optimization could be done by rolldown, them it could be done in the final app bundling step. For app, minifer will be enabled no matter how.

Worth discussing, cc @sapphi-red

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 27, 2026

Merge activity

graphite-app bot pushed a commit that referenced this pull request Feb 27, 2026
Closed #7235

**`failed-tests.json`** — Added 4 new entries (DCE-only default causes output differences):
- `rollup@form@export-globals` — DCE removes intermediate variable
- `rollup@form@preserves-comments-after-imports` — DCE inlines constant into object literal
- `rollup@form@reexport-self` — DCE inlines constant into console.log()
- `rollup@sourcemaps@names-transformed-render-chunk` — DCE changes code structure, breaking sourcemap test regex
@graphite-app graphite-app bot force-pushed the 02-25-feat_enable_minify_dce-only_by_default branch from 0f75c95 to 69cb98c Compare February 27, 2026 04:19
@hyf0 hyf0 changed the title feat!: enable minify: 'dce-only' by default feat: enable minify: 'dce-only' by default Feb 27, 2026
@IWANABETHATGUY IWANABETHATGUY changed the title feat: enable minify: 'dce-only' by default feat!: enable minify: 'dce-only' by default Feb 27, 2026
@IWANABETHATGUY IWANABETHATGUY changed the title feat!: enable minify: 'dce-only' by default feat: enable minify: 'dce-only' by default Feb 27, 2026
Closed #7235

**`failed-tests.json`** — Added 4 new entries (DCE-only default causes output differences):
- `rollup@form@export-globals` — DCE removes intermediate variable
- `rollup@form@preserves-comments-after-imports` — DCE inlines constant into object literal
- `rollup@form@reexport-self` — DCE inlines constant into console.log()
- `rollup@sourcemaps@names-transformed-render-chunk` — DCE changes code structure, breaking sourcemap test regex
Copilot AI review requested due to automatic review settings February 27, 2026 04:55
@IWANABETHATGUY IWANABETHATGUY force-pushed the 02-25-feat_enable_minify_dce-only_by_default branch from 69cb98c to e35d082 Compare February 27, 2026 04:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 299 out of 1421 changed files in this pull request and generated 4 comments.

@graphite-app graphite-app bot merged commit e35d082 into main Feb 27, 2026
35 checks passed
@graphite-app graphite-app bot deleted the 02-25-feat_enable_minify_dce-only_by_default branch February 27, 2026 05:06
This was referenced Mar 4, 2026
shulaoda added a commit that referenced this pull request Mar 5, 2026
## [1.0.0-rc.7] - 2026-03-05

⚡ Smarter Code Generation Defaults
- DCE-only minification and smart constant inlining are now enabled by default
- Produces cleaner, smaller output bundles without requiring explicit configuration

💡 LLM-Friendly Bundle Analyzer Reports
- New markdown output format for the bundle analyzer plugin with bundle summaries, module graphs, dependency chains, and optimization suggestions
- Optimization suggestions now also recommend using the entriesAware option when common chunks contain modules only reachable from specific entries


### 💥 BREAKING CHANGES

- enable minify: 'dce-only' by default (#8465) by @IWANABETHATGUY
- settings `inlineConst: { mode: 'smart', pass: 1}`  by default (#8444) by @IWANABETHATGUY

### 🚀 Features

- binding: add original getter to BindingMagicString (#8533) by @IWANABETHATGUY
- native-magic-string: add `offset` property support (#8531) by @IWANABETHATGUY
- add `output.strict` option to control `"use strict"` directive emission (#8489) by @Copilot
- watch: expose `watcher.compareContentsForPolling` (#8526) by @hyf0
- watch: use new watcher to support watch mode (#8475) by @hyf0
- rust/watch: handle bulk-change (#8466) by @hyf0
- add LLM-friendly markdown output format to bundle analyzer plugin (#8242) by @IWANABETHATGUY

### 🐛 Bug Fixes

- expose `plugins` on `NormalizedInputOptions` for `buildStart` hook (#8521) by @Copilot
- only uppercase facade symbols in JSX preserve mode (#8519) by @IWANABETHATGUY
- binding: export BindingResult in generated dts header (#8537) by @minsoo-web
- pre-resolve paths option to avoid `invoke_sync` deadlock (#8518) by @IWANABETHATGUY
- remove debug-only jsx_preset and UntranspiledSyntaxError (#8511) by @IWANABETHATGUY
- apply `topLevelVar` to exported `const`/`let` declarations (#8507) by @IWANABETHATGUY
- rolldown_plugin_vite_web_worker_post: avoid replacing `new.target` (#8488) by @sapphi-red
- update copyright year to 2026 (#8486) by @maciekzygmunt

### 🚜 Refactor

- rust: use Oxc's SymbolFlags::ConstVariable instead of custom IsConst flag (#8543) by @Dunqing
- rust: remove FacadeScoping, use Scoping::create_symbol for facade symbols (#8540) by @Dunqing
- rust/watch: remove hacky `reset_closed_for_watch_mode` (#8530) by @hyf0
- binding: return &str instead of String in filename() getter (#8534) by @IWANABETHATGUY
- rust: remove old watch mode implementation (#8525) by @hyf0
- rust/watch: simply watch logic in the binding layer (#8516) by @hyf0
- rust/watch: tweak struct/function names (#8464) by @hyf0

### 📚 Documentation

- explain how external modules work in rolldown (#8457) by @sapphi-red
- add some diagrams using graphviz (#8499) by @sapphi-red
- use `vitepress-plugin-graphviz` (#8498) by @sapphi-red
- list s390x/ppc64le prebuilt binaries (#8495) by @crusty-voidzero
- fix error type for `RolldownBuild.generate` and others (#8490) by @sapphi-red

### ⚡ Performance

- string_wizard: reduce allocations and add ASCII fast paths (#8541) by @IWANABETHATGUY
- use IndexBitSet to replace IndexVec<XXXIdx, bool> for module/stmt inclusion tracking (#8503) by @IWANABETHATGUY
- plugin: use IndexBitSet to optimize skipped plugins checking (#8497) by @ShroXd
- rust/tla: skip compute_tla if there is no module use TLA (#8487) by @ShroXd

### 🧪 Testing

- node/watch: make watch tests run in concurrent and retry-able (#8512) by @hyf0
- add test case for static flag tree-shaking (#8476) by @IWANABETHATGUY
- migrate post-banner sourcemap-with-shebang to Rust (#8477) by @Copilot

### ⚙️ Miscellaneous Tasks

- vscode: `formatOnSave` for markdown files using oxc formatter (#8536) by @minsoo-web
- deps: update test262 submodule for tests (#8528) by @sapphi-red
- remove `retry` workaround from output paths test fixtures (#8520) by @Copilot
- docs: add Shuyuan Wang (h-a-n-a) and remove from acknowledgements (#8509) by @Copilot
- consolidate top_level_var test cases using configVariants (#8508) by @IWANABETHATGUY
- add s390x and ppc64le linux gnu targets (#8493) by @Brooooooklyn

### ◀️ Revert

- fix(rolldown): increase tokio blocking threads size for watch mode (#8517) by @hyf0

### ❤️ New Contributors

* @minsoo-web made their first contribution in [#8536](#8536)
* @crusty-voidzero made their first contribution in [#8495](#8495)
* @maciekzygmunt made their first contribution in [#8486](#8486)

Co-authored-by: shulaoda <165626830+shulaoda@users.noreply.github.com>
shulaoda added a commit that referenced this pull request Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Static flags are not tree-shaken

3 participants