test(node/watch): make watch tests run in concurrent and retry-able by hyf0 · Pull Request #8512 · rolldown/rolldown

hyf0 · 2026-03-01T16:18:04Z

In local:

Before: ~24s (sequential)
After: ~7s (concurrent) — 3.4x faster

hyf0 · 2026-03-01T16:18:23Z

How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull request overview

Updates rolldown’s Node watch test suite to be runnable in parallel and more resilient to CI flakiness, primarily by making tests concurrent, adding retries/timeouts, and isolating filesystem fixtures per test run.

Changes:

Converted watch tests from test.sequential to test.concurrent with shared retry/timeout settings.
Introduced unique temp directories per test run (and per retry) via crypto.randomUUID().
Refactored fixture helpers (createTestInputAndOutput, createTestWithMultiFiles) and standardized polling-based watch behavior for CI stability.

packages/rolldown/tests/watch/watch.test.ts

hyf0 · 2026-03-02T06:34:31Z

Merge activity

Mar 2, 6:34 AM UTC: The merge label 'graphite: merge-when-ready' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Mar 2, 6:34 AM UTC: hyf0 added this pull request to the Graphite merge queue.
Mar 2, 6:45 AM UTC: The Graphite merge queue couldn't merge this PR because it had merge conflicts.
Mar 2, 7:32 AM UTC: The merge label 'graphite: merge-when-ready' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Mar 2, 7:32 AM UTC: sapphi-red added this pull request to the Graphite merge queue.
Mar 2, 7:43 AM UTC: Merged by the Graphite merge queue.

netlify · 2026-03-02T07:01:10Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`bb6c3d3`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/69a53d402e9f3a0008e1e7c3

…8512) In local: - Before: ~24s (sequential) - After: ~7s (concurrent) — 3.4x faster

@IWANABETHATGUY

## [1.0.0-rc.7] - 2026-03-05 ⚡ Smarter Code Generation Defaults - DCE-only minification and smart constant inlining are now enabled by default - Produces cleaner, smaller output bundles without requiring explicit configuration 💡 LLM-Friendly Bundle Analyzer Reports - New markdown output format for the bundle analyzer plugin with bundle summaries, module graphs, dependency chains, and optimization suggestions - Optimization suggestions now also recommend using the entriesAware option when common chunks contain modules only reachable from specific entries ### 💥 BREAKING CHANGES - enable minify: 'dce-only' by default (#8465) by @IWANABETHATGUY - settings `inlineConst: { mode: 'smart', pass: 1}` by default (#8444) by @IWANABETHATGUY ### 🚀 Features - binding: add original getter to BindingMagicString (#8533) by @IWANABETHATGUY - native-magic-string: add `offset` property support (#8531) by @IWANABETHATGUY - add `output.strict` option to control `"use strict"` directive emission (#8489) by @Copilot - watch: expose `watcher.compareContentsForPolling` (#8526) by @hyf0 - watch: use new watcher to support watch mode (#8475) by @hyf0 - rust/watch: handle bulk-change (#8466) by @hyf0 - add LLM-friendly markdown output format to bundle analyzer plugin (#8242) by @IWANABETHATGUY ### 🐛 Bug Fixes - expose `plugins` on `NormalizedInputOptions` for `buildStart` hook (#8521) by @Copilot - only uppercase facade symbols in JSX preserve mode (#8519) by @IWANABETHATGUY - binding: export BindingResult in generated dts header (#8537) by @minsoo-web - pre-resolve paths option to avoid `invoke_sync` deadlock (#8518) by @IWANABETHATGUY - remove debug-only jsx_preset and UntranspiledSyntaxError (#8511) by @IWANABETHATGUY - apply `topLevelVar` to exported `const`/`let` declarations (#8507) by @IWANABETHATGUY - rolldown_plugin_vite_web_worker_post: avoid replacing `new.target` (#8488) by @sapphi-red - update copyright year to 2026 (#8486) by @maciekzygmunt ### 🚜 Refactor - rust: use Oxc's SymbolFlags::ConstVariable instead of custom IsConst flag (#8543) by @Dunqing - rust: remove FacadeScoping, use Scoping::create_symbol for facade symbols (#8540) by @Dunqing - rust/watch: remove hacky `reset_closed_for_watch_mode` (#8530) by @hyf0 - binding: return &str instead of String in filename() getter (#8534) by @IWANABETHATGUY - rust: remove old watch mode implementation (#8525) by @hyf0 - rust/watch: simply watch logic in the binding layer (#8516) by @hyf0 - rust/watch: tweak struct/function names (#8464) by @hyf0 ### 📚 Documentation - explain how external modules work in rolldown (#8457) by @sapphi-red - add some diagrams using graphviz (#8499) by @sapphi-red - use `vitepress-plugin-graphviz` (#8498) by @sapphi-red - list s390x/ppc64le prebuilt binaries (#8495) by @crusty-voidzero - fix error type for `RolldownBuild.generate` and others (#8490) by @sapphi-red ### ⚡ Performance - string_wizard: reduce allocations and add ASCII fast paths (#8541) by @IWANABETHATGUY - use IndexBitSet to replace IndexVec<XXXIdx, bool> for module/stmt inclusion tracking (#8503) by @IWANABETHATGUY - plugin: use IndexBitSet to optimize skipped plugins checking (#8497) by @ShroXd - rust/tla: skip compute_tla if there is no module use TLA (#8487) by @ShroXd ### 🧪 Testing - node/watch: make watch tests run in concurrent and retry-able (#8512) by @hyf0 - add test case for static flag tree-shaking (#8476) by @IWANABETHATGUY - migrate post-banner sourcemap-with-shebang to Rust (#8477) by @Copilot ### ⚙️ Miscellaneous Tasks - vscode: `formatOnSave` for markdown files using oxc formatter (#8536) by @minsoo-web - deps: update test262 submodule for tests (#8528) by @sapphi-red - remove `retry` workaround from output paths test fixtures (#8520) by @Copilot - docs: add Shuyuan Wang (h-a-n-a) and remove from acknowledgements (#8509) by @Copilot - consolidate top_level_var test cases using configVariants (#8508) by @IWANABETHATGUY - add s390x and ppc64le linux gnu targets (#8493) by @Brooooooklyn ### ◀️ Revert - fix(rolldown): increase tokio blocking threads size for watch mode (#8517) by @hyf0 ### ❤️ New Contributors * @minsoo-web made their first contribution in [#8536](#8536) * @crusty-voidzero made their first contribution in [#8495](#8495) * @maciekzygmunt made their first contribution in [#8486](#8486) Co-authored-by: shulaoda <165626830+shulaoda@users.noreply.github.com>

This was referenced Mar 1, 2026

feat(watch): use new watcher to support watch mode #8475

Merged

feat(rust/watch): handle bulk-change #8466

Merged

github-actions bot assigned hyf0 Mar 1, 2026

hyf0 marked this pull request as ready for review March 1, 2026 16:18

Copilot AI review requested due to automatic review settings March 1, 2026 16:18

Copilot started reviewing on behalf of hyf0 March 1, 2026 16:19 View session

Copilot AI reviewed Mar 1, 2026

View reviewed changes

hyf0 requested review from sapphi-red and shulaoda March 1, 2026 16:36

graphite-app bot force-pushed the 02-26-feat_watch_use_new_watcher_to_support_watch_mode branch from 7c991ab to bd4f446 Compare March 1, 2026 16:39

graphite-app bot requested a review from IWANABETHATGUY as a code owner March 1, 2026 16:39

graphite-app bot force-pushed the 02-26-feat_watch_use_new_watcher_to_support_watch_mode branch from bd4f446 to be8bd7c Compare March 1, 2026 16:40

graphite-app bot force-pushed the 03-01-test_node_watch_make_watch_tests_run_in_concurrent_and_retry-able branch from a9f3fa4 to 468933e Compare March 1, 2026 16:40

shulaoda approved these changes Mar 1, 2026

View reviewed changes

hyf0 force-pushed the 03-01-test_node_watch_make_watch_tests_run_in_concurrent_and_retry-able branch from 468933e to 825ea08 Compare March 2, 2026 02:09

sapphi-red approved these changes Mar 2, 2026

View reviewed changes

hyf0 mentioned this pull request Mar 2, 2026

refactor(rust/watch): simply watch logic in the binding layer #8516

Merged

graphite-app bot changed the base branch from 02-26-feat_watch_use_new_watcher_to_support_watch_mode to graphite-base/8512 March 2, 2026 06:33

hyf0 added the graphite: merge-when-ready label Mar 2, 2026

graphite-app bot changed the base branch from graphite-base/8512 to main March 2, 2026 06:45

graphite-app bot removed the graphite: merge-when-ready label Mar 2, 2026

hyf0 force-pushed the 03-01-test_node_watch_make_watch_tests_run_in_concurrent_and_retry-able branch from 825ea08 to 26f3426 Compare March 2, 2026 06:59

hyf0 mentioned this pull request Mar 2, 2026

revert: fix(rolldown): increase tokio blocking threads size for watch mode #8517

Merged

sapphi-red added the graphite: merge-when-ready label Mar 2, 2026

test(node/watch): make watch tests run in concurrent and retry-able (#…

bb6c3d3

…8512) In local: - Before: ~24s (sequential) - After: ~7s (concurrent) — 3.4x faster

Copilot AI review requested due to automatic review settings March 2, 2026 07:33

graphite-app bot force-pushed the 03-01-test_node_watch_make_watch_tests_run_in_concurrent_and_retry-able branch from 26f3426 to bb6c3d3 Compare March 2, 2026 07:33

hyf0 review requested due to automatic review settings March 2, 2026 07:33

graphite-app bot merged commit bb6c3d3 into main Mar 2, 2026
32 checks passed

graphite-app bot deleted the 03-01-test_node_watch_make_watch_tests_run_in_concurrent_and_retry-able branch March 2, 2026 07:43

This was referenced Mar 2, 2026

refactor(rust): remove old watch mode implementation #8525

Merged

feat(watch): expose watcher.compareContentsForPolling #8526

Merged

This was referenced Mar 4, 2026

release: v1.0.0-rc.7 #8539

Closed

release: v1.0.0-rc.7 #8547

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test(node/watch): make watch tests run in concurrent and retry-able#8512

test(node/watch): make watch tests run in concurrent and retry-able#8512
graphite-app[bot] merged 1 commit intomainfrom
03-01-test_node_watch_make_watch_tests_run_in_concurrent_and_retry-able

hyf0 commented Mar 1, 2026 •

edited

Loading

Uh oh!

hyf0 commented Mar 1, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hyf0 commented Mar 2, 2026 •

edited by graphite-app bot

Loading

Uh oh!

netlify bot commented Mar 2, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

hyf0 commented Mar 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hyf0 commented Mar 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hyf0 commented Mar 2, 2026 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

netlify bot commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

hyf0 commented Mar 1, 2026 •

edited

Loading

hyf0 commented Mar 1, 2026 •

edited

Loading

hyf0 commented Mar 2, 2026 •

edited by graphite-app bot

Loading

netlify bot commented Mar 2, 2026 •

edited

Loading