Skip to content

fix(node/resolve): take custom package json path into account#6419

Merged
graphite-app[bot] merged 1 commit intomainfrom
10-06-fix_node_resolve_take_custom_package_json_path_into_account
Oct 6, 2025
Merged

fix(node/resolve): take custom package json path into account#6419
graphite-app[bot] merged 1 commit intomainfrom
10-06-fix_node_resolve_take_custom_package_json_path_into_account

Conversation

@hyf0
Copy link
Member

@hyf0 hyf0 commented Oct 6, 2025

Fixes #6398

Copy link
Member Author

hyf0 commented Oct 6, 2025


How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@hyf0 hyf0 marked this pull request as ready for review October 6, 2025 07:21
@hyf0 hyf0 requested a review from sapphi-red October 6, 2025 07:22
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2025

Benchmarks Rust

  • target: main(8fd8103)
  • pr: 10-06-fix_node_resolve_take_custom_package_json_path_into_account(9faaf8f)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     67.8±1.55ms        ? ?/sec    1.01     68.3±1.66ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.02     77.2±2.77ms        ? ?/sec    1.00     75.4±1.64ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    111.9±7.75ms        ? ?/sec    1.00    111.7±2.31ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    126.6±1.91ms        ? ?/sec    1.01    128.1±1.86ms        ? ?/sec
bundle/bundle@threejs                                        1.00     43.5±0.82ms        ? ?/sec    1.00     43.5±0.98ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     50.2±0.87ms        ? ?/sec    1.03     51.5±1.69ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    432.6±6.38ms        ? ?/sec    1.00    430.9±6.08ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    494.7±5.47ms        ? ?/sec    1.00    494.1±7.44ms        ? ?/sec
scan/scan@rome_ts                                            1.05     91.1±1.77ms        ? ?/sec    1.00     86.5±2.44ms        ? ?/sec
scan/scan@threejs                                            1.00     33.0±2.05ms        ? ?/sec    1.00     33.0±2.08ms        ? ?/sec
scan/scan@threejs10x                                         1.00    335.5±4.77ms        ? ?/sec    1.00    334.2±4.82ms        ? ?/sec

@hyf0 hyf0 linked an issue Oct 6, 2025 that may be closed by this pull request
@hyf0 hyf0 force-pushed the 10-06-fix_node_resolve_take_custom_package_json_path_into_account branch from 9108953 to 6ffe5e2 Compare October 6, 2025 08:08
@graphite-app graphite-app bot changed the base branch from 10-06-refactor_rust_improve_constuction_of_packagejson_and_remove_unused_fields to graphite-base/6419 October 6, 2025 08:08
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 6, 2025

Merge activity

@graphite-app graphite-app bot changed the base branch from graphite-base/6419 to main October 6, 2025 08:23
@graphite-app graphite-app bot force-pushed the 10-06-fix_node_resolve_take_custom_package_json_path_into_account branch from 6ffe5e2 to 9faaf8f Compare October 6, 2025 08:24
@netlify
Copy link

netlify bot commented Oct 6, 2025

Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit 9faaf8f
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68e37cbf2518cf000888aa9d
😎 Deploy Preview https://deploy-preview-6419--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@graphite-app graphite-app bot merged commit 9faaf8f into main Oct 6, 2025
29 checks passed
@graphite-app graphite-app bot deleted the 10-06-fix_node_resolve_take_custom_package_json_path_into_account branch October 6, 2025 08:41
@github-actions github-actions bot mentioned this pull request Oct 7, 2025
shulaoda pushed a commit that referenced this pull request Oct 7, 2025
## [1.0.0-beta.42] - 2025-10-07

### 🚀 Features

- rolldown: oxc v0.94.0 (#6428) by @Boshen
- add CLI environment flag (#6426) by @IWANABETHATGUY
- dev: use `RebuildStrategy#Auto` by default (#6420) by @hyf0
- rolldown_plugin_vite_html: introduce html plugin state (#6413) by @shulaoda
- dev: expose build errors via `DevOptions#on_output` (#6412) by @hyf0
- dev: add binding for `DevOptions#rebuild_strategy` (#6396) by @hyf0
- dev: add `RebuildStrategy::Auto` to issue rebuild automatically if detecting full reload hmr update (#6395) by @hyf0
- debug: inject `call_id` for `renderChunk` hook (#6392) by @hyf0
- node/dev: add `DevEngine#close` (#6377) by @hyf0
- rust/dev: add `DevEngine#close` (#6376) by @hyf0

### 🐛 Bug Fixes

- rolldown_plugin_react_refresh_wrapper: register exports in next microtask (#6423) by @sapphi-red
- plugin/vite-resolve: try original extension before replacing with TS variants (#6421) by @sapphi-red
- node/resolve: take custom package json path into account (#6419) by @hyf0
- dev: call `watchChange` hook (#6403) by @sapphi-red
- use minify options for DCE for dce-only minify (#6402) by @sapphi-red
- respect package.json type field in plugin-resolved modules (#6400) by @hyf0
- returning result of this.resolve in resolveDynamicImport hook impacts bundle size (#6397) by @sapphi-red
- rolldown_plugin_json: avoid generating named exports for `eval` and `arguments` (#6381) by @sapphi-red
- use static property for namespace object (#6383) by @sapphi-red

### 🚜 Refactor

- rust: improve constuction of `PackageJson` and remove unused fields (#6418) by @hyf0
- introduce `BindingResult` to pass errors from rust to js (#6390) by @hyf0
- rust: rename eager_rebuild to rebuild_strategy with enum (#6394) by @hyf0
- rust/binding: use `BindingError` to cover `JsError` and `NativeError` (#6388) by @hyf0
- rust/binding: rename `BindingError` to `NativeError` (#6387) by @hyf0

### 📚 Documentation

- tweak built-in transforms section (#6384) by @sapphi-red

### ⚡ Performance

- dev: avoid frequent `setTimeout` -> `clearTimeout` (#6375) by @sapphi-red

### 🧪 Testing

- hmr: include generated bundle for full reloads in snapshots (#6374) by @sapphi-red
- dev: add test about doing hmr with not being affected by not executed modules (#6360) by @hyf0
- hmr: hmr patch file generation for `this.addWatchFile` (#5219) by @sapphi-red

### ⚙️ Miscellaneous Tasks

- deps: update crate-ci/typos action to v1.38.0 (#6431) by @renovate[bot]
- deps: update crate-ci/typos action to v1.37.3 (#6429) by @renovate[bot]
- deps: lock file maintenance npm packages (#6417) by @renovate[bot]
- deps: update github-actions (#6414) by @renovate[bot]
- rust/test: sensible heading level for build snapshot of config variant (#6408) by @hyf0
- rust/test: introduce `SnapshotSection` to organize snapshot content (#6407) by @hyf0
- rust/test: extract `ArtifactsSnapshot` and `BuildRoundOutput` into standalone files (#6406) by @hyf0
- rust/test: introduce `ArtifactsSnapshot` to make generating snapshot more clear (#6405) by @hyf0
- deps: update crate-ci/typos action to v1.37.2 (#6409) by @renovate[bot]
- fix `GitHub` casing (#6401) by @iiio2
- rust: remove unused `rolldown_binding_watcher` crate (#6386) by @hyf0
- deps: update crate-ci/typos action to v1.37.1 (#6391) by @renovate[bot]
- node: rename `normalizeErrors` into `aggregateBindingErrorsIntoError` (#6389) by @hyf0
- fix typos (#6382) by @sapphi-red
- deps: update dependency tsdown to v0.15.6 (#6379) by @renovate[bot]
- deps: update crate-ci/typos action to v1.37.0 (#6380) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.16.11 (#6378) by @renovate[bot]
- add comment to `add_watch_file` that the path should be a normalized absolute path (#6371) by @sapphi-red
- deps: update dependency rolldown-plugin-dts to v0.16.10 (#6373) by @renovate[bot]

Co-authored-by: sapphi-red <49056869+sapphi-red@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ModuleDefFormat::*PackageJson cannot be set by plugins

2 participants