Skip to content

test(hmr): hmr patch file generation for this.addWatchFile#5219

Merged
graphite-app[bot] merged 1 commit intomainfrom
07-09-test_hmr_hmr_patch_file_generation_for_this.addwatchfile_
Sep 30, 2025
Merged

test(hmr): hmr patch file generation for this.addWatchFile#5219
graphite-app[bot] merged 1 commit intomainfrom
07-09-test_hmr_hmr_patch_file_generation_for_this.addwatchfile_

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Jul 9, 2025

See #5220

Copy link
Member Author

sapphi-red commented Jul 9, 2025


How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Base automatically changed from 07-09-feat_hmr_return_undefined_from_generatehmrpatch_when_there_is_no_patch to main July 9, 2025 09:15
@sapphi-red sapphi-red force-pushed the 07-09-test_hmr_hmr_patch_file_generation_for_this.addwatchfile_ branch from 49f5c23 to 2a6f2cb Compare July 9, 2025 09:17
@netlify
Copy link

netlify bot commented Jul 9, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit f7d836b
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68db496bb57ea60008d541ba

@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2025

Benchmarks Rust

  • target: main(8575023)
  • pr: 07-09-test_hmr_hmr_patch_file_generation_for_this.addwatchfile_(f7d836b)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     69.3±2.03ms        ? ?/sec    1.02     70.9±1.29ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     76.7±2.34ms        ? ?/sec    1.03     78.6±2.19ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    112.3±2.08ms        ? ?/sec    1.02    114.6±2.73ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    128.6±2.05ms        ? ?/sec    1.01    130.4±2.68ms        ? ?/sec
bundle/bundle@threejs                                        1.00     44.9±1.37ms        ? ?/sec    1.00     45.0±0.71ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     51.4±0.91ms        ? ?/sec    1.01     52.0±0.83ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    433.7±6.43ms        ? ?/sec    1.01    436.1±5.16ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    499.2±4.63ms        ? ?/sec    1.01    503.5±6.05ms        ? ?/sec
scan/scan@rome_ts                                            1.02     90.0±1.72ms        ? ?/sec    1.00     88.5±2.18ms        ? ?/sec
scan/scan@threejs                                            1.01     33.1±0.44ms        ? ?/sec    1.00     32.8±0.54ms        ? ?/sec
scan/scan@threejs10x                                         1.01    337.0±4.86ms        ? ?/sec    1.00    333.2±4.68ms        ? ?/sec

@sapphi-red sapphi-red force-pushed the 07-09-test_hmr_hmr_patch_file_generation_for_this.addwatchfile_ branch from 2a6f2cb to c40f18c Compare July 10, 2025 02:13
@sapphi-red sapphi-red force-pushed the 07-09-test_hmr_hmr_patch_file_generation_for_this.addwatchfile_ branch 2 times, most recently from c9d0f69 to 2c341a5 Compare August 28, 2025 05:41
@sapphi-red sapphi-red force-pushed the 07-09-test_hmr_hmr_patch_file_generation_for_this.addwatchfile_ branch 3 times, most recently from 15c0ae9 to c0d2f1f Compare September 29, 2025 03:51
@sapphi-red sapphi-red force-pushed the 07-09-test_hmr_hmr_patch_file_generation_for_this.addwatchfile_ branch from c0d2f1f to 7532d27 Compare September 29, 2025 05:30
@sapphi-red sapphi-red marked this pull request as ready for review September 29, 2025 05:30
@sapphi-red sapphi-red requested a review from hyf0 September 29, 2025 05:30
@sapphi-red sapphi-red assigned sapphi-red and unassigned hyf0 Sep 29, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 30, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 07-09-test_hmr_hmr_patch_file_generation_for_this.addwatchfile_ branch from 7532d27 to f7d836b Compare September 30, 2025 03:07
@graphite-app graphite-app bot merged commit f7d836b into main Sep 30, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 07-09-test_hmr_hmr_patch_file_generation_for_this.addwatchfile_ branch September 30, 2025 03:19
@github-actions github-actions bot mentioned this pull request Oct 7, 2025
shulaoda pushed a commit that referenced this pull request Oct 7, 2025
## [1.0.0-beta.42] - 2025-10-07

### 🚀 Features

- rolldown: oxc v0.94.0 (#6428) by @Boshen
- add CLI environment flag (#6426) by @IWANABETHATGUY
- dev: use `RebuildStrategy#Auto` by default (#6420) by @hyf0
- rolldown_plugin_vite_html: introduce html plugin state (#6413) by @shulaoda
- dev: expose build errors via `DevOptions#on_output` (#6412) by @hyf0
- dev: add binding for `DevOptions#rebuild_strategy` (#6396) by @hyf0
- dev: add `RebuildStrategy::Auto` to issue rebuild automatically if detecting full reload hmr update (#6395) by @hyf0
- debug: inject `call_id` for `renderChunk` hook (#6392) by @hyf0
- node/dev: add `DevEngine#close` (#6377) by @hyf0
- rust/dev: add `DevEngine#close` (#6376) by @hyf0

### 🐛 Bug Fixes

- rolldown_plugin_react_refresh_wrapper: register exports in next microtask (#6423) by @sapphi-red
- plugin/vite-resolve: try original extension before replacing with TS variants (#6421) by @sapphi-red
- node/resolve: take custom package json path into account (#6419) by @hyf0
- dev: call `watchChange` hook (#6403) by @sapphi-red
- use minify options for DCE for dce-only minify (#6402) by @sapphi-red
- respect package.json type field in plugin-resolved modules (#6400) by @hyf0
- returning result of this.resolve in resolveDynamicImport hook impacts bundle size (#6397) by @sapphi-red
- rolldown_plugin_json: avoid generating named exports for `eval` and `arguments` (#6381) by @sapphi-red
- use static property for namespace object (#6383) by @sapphi-red

### 🚜 Refactor

- rust: improve constuction of `PackageJson` and remove unused fields (#6418) by @hyf0
- introduce `BindingResult` to pass errors from rust to js (#6390) by @hyf0
- rust: rename eager_rebuild to rebuild_strategy with enum (#6394) by @hyf0
- rust/binding: use `BindingError` to cover `JsError` and `NativeError` (#6388) by @hyf0
- rust/binding: rename `BindingError` to `NativeError` (#6387) by @hyf0

### 📚 Documentation

- tweak built-in transforms section (#6384) by @sapphi-red

### ⚡ Performance

- dev: avoid frequent `setTimeout` -> `clearTimeout` (#6375) by @sapphi-red

### 🧪 Testing

- hmr: include generated bundle for full reloads in snapshots (#6374) by @sapphi-red
- dev: add test about doing hmr with not being affected by not executed modules (#6360) by @hyf0
- hmr: hmr patch file generation for `this.addWatchFile` (#5219) by @sapphi-red

### ⚙️ Miscellaneous Tasks

- deps: update crate-ci/typos action to v1.38.0 (#6431) by @renovate[bot]
- deps: update crate-ci/typos action to v1.37.3 (#6429) by @renovate[bot]
- deps: lock file maintenance npm packages (#6417) by @renovate[bot]
- deps: update github-actions (#6414) by @renovate[bot]
- rust/test: sensible heading level for build snapshot of config variant (#6408) by @hyf0
- rust/test: introduce `SnapshotSection` to organize snapshot content (#6407) by @hyf0
- rust/test: extract `ArtifactsSnapshot` and `BuildRoundOutput` into standalone files (#6406) by @hyf0
- rust/test: introduce `ArtifactsSnapshot` to make generating snapshot more clear (#6405) by @hyf0
- deps: update crate-ci/typos action to v1.37.2 (#6409) by @renovate[bot]
- fix `GitHub` casing (#6401) by @iiio2
- rust: remove unused `rolldown_binding_watcher` crate (#6386) by @hyf0
- deps: update crate-ci/typos action to v1.37.1 (#6391) by @renovate[bot]
- node: rename `normalizeErrors` into `aggregateBindingErrorsIntoError` (#6389) by @hyf0
- fix typos (#6382) by @sapphi-red
- deps: update dependency tsdown to v0.15.6 (#6379) by @renovate[bot]
- deps: update crate-ci/typos action to v1.37.0 (#6380) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.16.11 (#6378) by @renovate[bot]
- add comment to `add_watch_file` that the path should be a normalized absolute path (#6371) by @sapphi-red
- deps: update dependency rolldown-plugin-dts to v0.16.10 (#6373) by @renovate[bot]

Co-authored-by: sapphi-red <49056869+sapphi-red@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants