Skip to content

fix(rolldown_plugin_json): avoid generating named exports for eval and arguments#6381

Merged
graphite-app[bot] merged 1 commit intomainfrom
10-01-fix_rolldown_plugin_json_avoid_generating_named_exports_for_eval_and_arguments_
Oct 1, 2025
Merged

fix(rolldown_plugin_json): avoid generating named exports for eval and arguments#6381
graphite-app[bot] merged 1 commit intomainfrom
10-01-fix_rolldown_plugin_json_avoid_generating_named_exports_for_eval_and_arguments_

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Oct 1, 2025

@sapphi-red sapphi-red self-assigned this Oct 1, 2025
Copy link
Member Author

sapphi-red commented Oct 1, 2025


How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sapphi-red sapphi-red marked this pull request as ready for review October 1, 2025 02:02
@netlify
Copy link

netlify bot commented Oct 1, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit d87b595
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68dc9cc0ef9e9000085b0634

@sapphi-red sapphi-red changed the base branch from main to graphite-base/6381 October 1, 2025 02:07
@sapphi-red sapphi-red force-pushed the 10-01-fix_rolldown_plugin_json_avoid_generating_named_exports_for_eval_and_arguments_ branch from 66140c2 to cfe9ad5 Compare October 1, 2025 02:08
@sapphi-red sapphi-red changed the base branch from graphite-base/6381 to 10-01-chore_fix_typos October 1, 2025 02:08
@sapphi-red sapphi-red mentioned this pull request Oct 1, 2025
@sapphi-red sapphi-red force-pushed the 10-01-fix_rolldown_plugin_json_avoid_generating_named_exports_for_eval_and_arguments_ branch from cfe9ad5 to 325cef8 Compare October 1, 2025 02:12
@graphite-app graphite-app bot changed the base branch from 10-01-chore_fix_typos to graphite-base/6381 October 1, 2025 02:19
@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2025

Benchmarks Rust

  • target: main(bb03390)
  • pr: 10-01-fix_rolldown_plugin_json_avoid_generating_named_exports_for_eval_and_arguments_(d87b595)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     64.8±1.25ms        ? ?/sec    1.00     64.7±1.10ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.01     71.9±1.08ms        ? ?/sec    1.00     71.5±1.96ms        ? ?/sec
bundle/bundle@rome_ts                                        1.01    110.4±3.10ms        ? ?/sec    1.00    108.8±1.85ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.01    126.0±1.64ms        ? ?/sec    1.00    125.1±1.37ms        ? ?/sec
bundle/bundle@threejs                                        1.00     42.2±0.54ms        ? ?/sec    1.01     42.8±2.41ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     49.6±1.07ms        ? ?/sec    1.00     49.4±0.93ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    426.8±4.39ms        ? ?/sec    1.00    427.8±5.39ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    491.1±3.62ms        ? ?/sec    1.01    494.0±9.68ms        ? ?/sec
scan/scan@rome_ts                                            1.00     85.2±1.40ms        ? ?/sec    1.02     87.0±2.49ms        ? ?/sec
scan/scan@threejs                                            1.00     32.1±1.63ms        ? ?/sec    1.02     32.6±2.12ms        ? ?/sec
scan/scan@threejs10x                                         1.00    332.7±4.81ms        ? ?/sec    1.01    334.5±4.11ms        ? ?/sec

@graphite-app graphite-app bot force-pushed the graphite-base/6381 branch from ffcb0e3 to f2835ec Compare October 1, 2025 02:33
@graphite-app graphite-app bot force-pushed the 10-01-fix_rolldown_plugin_json_avoid_generating_named_exports_for_eval_and_arguments_ branch from 325cef8 to 996caff Compare October 1, 2025 02:33
@graphite-app graphite-app bot changed the base branch from graphite-base/6381 to main October 1, 2025 02:34
@graphite-app graphite-app bot force-pushed the 10-01-fix_rolldown_plugin_json_avoid_generating_named_exports_for_eval_and_arguments_ branch from 996caff to 97f35e0 Compare October 1, 2025 02:34
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 1, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 10-01-fix_rolldown_plugin_json_avoid_generating_named_exports_for_eval_and_arguments_ branch from 97f35e0 to d87b595 Compare October 1, 2025 03:15
@graphite-app graphite-app bot merged commit d87b595 into main Oct 1, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 10-01-fix_rolldown_plugin_json_avoid_generating_named_exports_for_eval_and_arguments_ branch October 1, 2025 03:27
@github-actions github-actions bot mentioned this pull request Oct 7, 2025
shulaoda pushed a commit that referenced this pull request Oct 7, 2025
## [1.0.0-beta.42] - 2025-10-07

### 🚀 Features

- rolldown: oxc v0.94.0 (#6428) by @Boshen
- add CLI environment flag (#6426) by @IWANABETHATGUY
- dev: use `RebuildStrategy#Auto` by default (#6420) by @hyf0
- rolldown_plugin_vite_html: introduce html plugin state (#6413) by @shulaoda
- dev: expose build errors via `DevOptions#on_output` (#6412) by @hyf0
- dev: add binding for `DevOptions#rebuild_strategy` (#6396) by @hyf0
- dev: add `RebuildStrategy::Auto` to issue rebuild automatically if detecting full reload hmr update (#6395) by @hyf0
- debug: inject `call_id` for `renderChunk` hook (#6392) by @hyf0
- node/dev: add `DevEngine#close` (#6377) by @hyf0
- rust/dev: add `DevEngine#close` (#6376) by @hyf0

### 🐛 Bug Fixes

- rolldown_plugin_react_refresh_wrapper: register exports in next microtask (#6423) by @sapphi-red
- plugin/vite-resolve: try original extension before replacing with TS variants (#6421) by @sapphi-red
- node/resolve: take custom package json path into account (#6419) by @hyf0
- dev: call `watchChange` hook (#6403) by @sapphi-red
- use minify options for DCE for dce-only minify (#6402) by @sapphi-red
- respect package.json type field in plugin-resolved modules (#6400) by @hyf0
- returning result of this.resolve in resolveDynamicImport hook impacts bundle size (#6397) by @sapphi-red
- rolldown_plugin_json: avoid generating named exports for `eval` and `arguments` (#6381) by @sapphi-red
- use static property for namespace object (#6383) by @sapphi-red

### 🚜 Refactor

- rust: improve constuction of `PackageJson` and remove unused fields (#6418) by @hyf0
- introduce `BindingResult` to pass errors from rust to js (#6390) by @hyf0
- rust: rename eager_rebuild to rebuild_strategy with enum (#6394) by @hyf0
- rust/binding: use `BindingError` to cover `JsError` and `NativeError` (#6388) by @hyf0
- rust/binding: rename `BindingError` to `NativeError` (#6387) by @hyf0

### 📚 Documentation

- tweak built-in transforms section (#6384) by @sapphi-red

### ⚡ Performance

- dev: avoid frequent `setTimeout` -> `clearTimeout` (#6375) by @sapphi-red

### 🧪 Testing

- hmr: include generated bundle for full reloads in snapshots (#6374) by @sapphi-red
- dev: add test about doing hmr with not being affected by not executed modules (#6360) by @hyf0
- hmr: hmr patch file generation for `this.addWatchFile` (#5219) by @sapphi-red

### ⚙️ Miscellaneous Tasks

- deps: update crate-ci/typos action to v1.38.0 (#6431) by @renovate[bot]
- deps: update crate-ci/typos action to v1.37.3 (#6429) by @renovate[bot]
- deps: lock file maintenance npm packages (#6417) by @renovate[bot]
- deps: update github-actions (#6414) by @renovate[bot]
- rust/test: sensible heading level for build snapshot of config variant (#6408) by @hyf0
- rust/test: introduce `SnapshotSection` to organize snapshot content (#6407) by @hyf0
- rust/test: extract `ArtifactsSnapshot` and `BuildRoundOutput` into standalone files (#6406) by @hyf0
- rust/test: introduce `ArtifactsSnapshot` to make generating snapshot more clear (#6405) by @hyf0
- deps: update crate-ci/typos action to v1.37.2 (#6409) by @renovate[bot]
- fix `GitHub` casing (#6401) by @iiio2
- rust: remove unused `rolldown_binding_watcher` crate (#6386) by @hyf0
- deps: update crate-ci/typos action to v1.37.1 (#6391) by @renovate[bot]
- node: rename `normalizeErrors` into `aggregateBindingErrorsIntoError` (#6389) by @hyf0
- fix typos (#6382) by @sapphi-red
- deps: update dependency tsdown to v0.15.6 (#6379) by @renovate[bot]
- deps: update crate-ci/typos action to v1.37.0 (#6380) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.16.11 (#6378) by @renovate[bot]
- add comment to `add_watch_file` that the path should be a normalized absolute path (#6371) by @sapphi-red
- deps: update dependency rolldown-plugin-dts to v0.16.10 (#6373) by @renovate[bot]

Co-authored-by: sapphi-red <49056869+sapphi-red@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot assign to 'eval' in strict mode

2 participants