Skip to content

refactor(rust/binding): rename BindingError to NativeError#6387

Merged
graphite-app[bot] merged 1 commit intomainfrom
10-01-refactor_rust_binding_rename_bindingerror_to_nativeerror_
Oct 1, 2025
Merged

refactor(rust/binding): rename BindingError to NativeError#6387
graphite-app[bot] merged 1 commit intomainfrom
10-01-refactor_rust_binding_rename_bindingerror_to_nativeerror_

Conversation

@hyf0
Copy link
Member

@hyf0 hyf0 commented Oct 1, 2025

  • NativeError is a more accurate name.
  • BindingError concept would be used for covering NativeError and JsError in concept.

Context:

  • I'm developing exposing error from dev engine and found it's a little chaotic to understand how the rust error are passed to js side.

Copy link
Member Author

hyf0 commented Oct 1, 2025


How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@hyf0 hyf0 marked this pull request as ready for review October 1, 2025 09:25
@netlify
Copy link

netlify bot commented Oct 1, 2025

Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit f1930ab
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68dd304177a4ba00088cd4b7
😎 Deploy Preview https://deploy-preview-6387--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2025

Benchmarks Rust

  • target: main(d8f1692)
  • pr: 10-01-refactor_rust_binding_rename_bindingerror_to_nativeerror_(f1930ab)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     66.3±1.91ms        ? ?/sec    1.01     67.3±1.75ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     73.2±1.77ms        ? ?/sec    1.01     73.7±1.54ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    109.9±2.37ms        ? ?/sec    1.01    111.1±2.95ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    126.6±2.55ms        ? ?/sec    1.00    127.2±2.10ms        ? ?/sec
bundle/bundle@threejs                                        1.01     43.8±2.83ms        ? ?/sec    1.00     43.4±0.85ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     49.8±0.94ms        ? ?/sec    1.02     50.8±1.01ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    423.7±5.94ms        ? ?/sec    1.00    425.5±4.57ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    487.4±5.16ms        ? ?/sec    1.00    488.3±5.14ms        ? ?/sec
scan/scan@rome_ts                                            1.01     87.0±1.56ms        ? ?/sec    1.00     86.1±1.53ms        ? ?/sec
scan/scan@threejs                                            1.01     32.3±0.42ms        ? ?/sec    1.00     32.0±0.49ms        ? ?/sec
scan/scan@threejs10x                                         1.02    333.9±5.13ms        ? ?/sec    1.00    328.5±6.99ms        ? ?/sec

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 1, 2025

Merge activity

- `NativeError` is a more accurate name.
- `BindingError` concept would be used for covering `NativeError` and `JsError` in concept.

Context:

- I'm developing exposing error from dev engine and found it's a little chaotic to understand how the rust error are passed to js side.
@graphite-app graphite-app bot force-pushed the 10-01-refactor_rust_binding_rename_bindingerror_to_nativeerror_ branch from 38bc8ad to f1930ab Compare October 1, 2025 13:44
@graphite-app graphite-app bot merged commit f1930ab into main Oct 1, 2025
59 of 62 checks passed
@graphite-app graphite-app bot deleted the 10-01-refactor_rust_binding_rename_bindingerror_to_nativeerror_ branch October 1, 2025 16:15
@github-actions github-actions bot mentioned this pull request Oct 7, 2025
shulaoda pushed a commit that referenced this pull request Oct 7, 2025
## [1.0.0-beta.42] - 2025-10-07

### 🚀 Features

- rolldown: oxc v0.94.0 (#6428) by @Boshen
- add CLI environment flag (#6426) by @IWANABETHATGUY
- dev: use `RebuildStrategy#Auto` by default (#6420) by @hyf0
- rolldown_plugin_vite_html: introduce html plugin state (#6413) by @shulaoda
- dev: expose build errors via `DevOptions#on_output` (#6412) by @hyf0
- dev: add binding for `DevOptions#rebuild_strategy` (#6396) by @hyf0
- dev: add `RebuildStrategy::Auto` to issue rebuild automatically if detecting full reload hmr update (#6395) by @hyf0
- debug: inject `call_id` for `renderChunk` hook (#6392) by @hyf0
- node/dev: add `DevEngine#close` (#6377) by @hyf0
- rust/dev: add `DevEngine#close` (#6376) by @hyf0

### 🐛 Bug Fixes

- rolldown_plugin_react_refresh_wrapper: register exports in next microtask (#6423) by @sapphi-red
- plugin/vite-resolve: try original extension before replacing with TS variants (#6421) by @sapphi-red
- node/resolve: take custom package json path into account (#6419) by @hyf0
- dev: call `watchChange` hook (#6403) by @sapphi-red
- use minify options for DCE for dce-only minify (#6402) by @sapphi-red
- respect package.json type field in plugin-resolved modules (#6400) by @hyf0
- returning result of this.resolve in resolveDynamicImport hook impacts bundle size (#6397) by @sapphi-red
- rolldown_plugin_json: avoid generating named exports for `eval` and `arguments` (#6381) by @sapphi-red
- use static property for namespace object (#6383) by @sapphi-red

### 🚜 Refactor

- rust: improve constuction of `PackageJson` and remove unused fields (#6418) by @hyf0
- introduce `BindingResult` to pass errors from rust to js (#6390) by @hyf0
- rust: rename eager_rebuild to rebuild_strategy with enum (#6394) by @hyf0
- rust/binding: use `BindingError` to cover `JsError` and `NativeError` (#6388) by @hyf0
- rust/binding: rename `BindingError` to `NativeError` (#6387) by @hyf0

### 📚 Documentation

- tweak built-in transforms section (#6384) by @sapphi-red

### ⚡ Performance

- dev: avoid frequent `setTimeout` -> `clearTimeout` (#6375) by @sapphi-red

### 🧪 Testing

- hmr: include generated bundle for full reloads in snapshots (#6374) by @sapphi-red
- dev: add test about doing hmr with not being affected by not executed modules (#6360) by @hyf0
- hmr: hmr patch file generation for `this.addWatchFile` (#5219) by @sapphi-red

### ⚙️ Miscellaneous Tasks

- deps: update crate-ci/typos action to v1.38.0 (#6431) by @renovate[bot]
- deps: update crate-ci/typos action to v1.37.3 (#6429) by @renovate[bot]
- deps: lock file maintenance npm packages (#6417) by @renovate[bot]
- deps: update github-actions (#6414) by @renovate[bot]
- rust/test: sensible heading level for build snapshot of config variant (#6408) by @hyf0
- rust/test: introduce `SnapshotSection` to organize snapshot content (#6407) by @hyf0
- rust/test: extract `ArtifactsSnapshot` and `BuildRoundOutput` into standalone files (#6406) by @hyf0
- rust/test: introduce `ArtifactsSnapshot` to make generating snapshot more clear (#6405) by @hyf0
- deps: update crate-ci/typos action to v1.37.2 (#6409) by @renovate[bot]
- fix `GitHub` casing (#6401) by @iiio2
- rust: remove unused `rolldown_binding_watcher` crate (#6386) by @hyf0
- deps: update crate-ci/typos action to v1.37.1 (#6391) by @renovate[bot]
- node: rename `normalizeErrors` into `aggregateBindingErrorsIntoError` (#6389) by @hyf0
- fix typos (#6382) by @sapphi-red
- deps: update dependency tsdown to v0.15.6 (#6379) by @renovate[bot]
- deps: update crate-ci/typos action to v1.37.0 (#6380) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.16.11 (#6378) by @renovate[bot]
- add comment to `add_watch_file` that the path should be a normalized absolute path (#6371) by @sapphi-red
- deps: update dependency rolldown-plugin-dts to v0.16.10 (#6373) by @renovate[bot]

Co-authored-by: sapphi-red <49056869+sapphi-red@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants