Skip to content

feat(hmr): add module and exports parameters to CJS initializer functions#5322

Merged
hyf0 merged 1 commit intomainfrom
07-17-feat_hmr_add_module_and_exports_parameters_to_cjs_initializer_functions
Jul 17, 2025
Merged

feat(hmr): add module and exports parameters to CJS initializer functions#5322
hyf0 merged 1 commit intomainfrom
07-17-feat_hmr_add_module_and_exports_parameters_to_cjs_initializer_functions

Conversation

@hyf0
Copy link
Member

@hyf0 hyf0 commented Jul 17, 2025

No description provided.

@hyf0 hyf0 marked this pull request as ready for review July 17, 2025 09:17
@netlify
Copy link

netlify bot commented Jul 17, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 8a2fecb
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/6878e371d49c5400089de255

Copy link
Member Author

hyf0 commented Jul 17, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 17, 2025

Benchmarks Rust

  • target: main(28ea18a)
  • pr: 07-17-feat_hmr_add_module_and_exports_parameters_to_cjs_initializer_functions(8a2fecb)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     84.0±2.36ms        ? ?/sec    1.04     87.6±2.66ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     95.0±1.47ms        ? ?/sec    1.02     96.5±1.89ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    119.8±3.05ms        ? ?/sec    1.03    123.8±2.73ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    142.3±1.89ms        ? ?/sec    1.03    146.0±2.31ms        ? ?/sec
bundle/bundle@threejs                                        1.00     44.7±1.11ms        ? ?/sec    1.01     45.3±2.36ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.01     54.1±0.94ms        ? ?/sec    1.00     53.8±1.06ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    456.0±5.50ms        ? ?/sec    1.01    461.1±7.02ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    541.3±6.50ms        ? ?/sec    1.01    546.7±7.50ms        ? ?/sec
scan/scan@rome_ts                                            1.01     95.3±3.14ms        ? ?/sec    1.00     94.2±2.44ms        ? ?/sec
scan/scan@threejs                                            1.03     33.4±1.94ms        ? ?/sec    1.00     32.5±0.65ms        ? ?/sec
scan/scan@threejs10x                                         1.00    335.3±5.06ms        ? ?/sec    1.00    336.9±3.70ms        ? ?/sec

@hyf0 hyf0 force-pushed the 07-17-feat_hmr_add_module_and_exports_parameters_to_cjs_initializer_functions branch from d8ec9b3 to 8a2fecb Compare July 17, 2025 11:50
@hyf0 hyf0 added this pull request to the merge queue Jul 17, 2025
Merged via the queue into main with commit 6e9c31e Jul 17, 2025
23 checks passed
@hyf0 hyf0 deleted the 07-17-feat_hmr_add_module_and_exports_parameters_to_cjs_initializer_functions branch July 17, 2025 12:06
This was referenced Jul 17, 2025
shulaoda pushed a commit that referenced this pull request Jul 17, 2025
## [1.0.0-beta.28] - 2025-07-17

### 🚀 Features

- rolldown: oxc v0.77.2 (#5328) by @Boshen
- hmr: add `module` and `exports` parameters to CJS initializer
functions (#5322) by @hyf0
- rolldown_plugin_transform: align with `vitejs/rolldown-vite#318`
(#5318) by @shulaoda
- rolldown_plugin_transform: align with `vitejs/rolldown-vite#315`
(#5315) by @shulaoda
- hmr: automatically disable treeshaking in hmr (#5311) by @hyf0
- hmr: use `trait HmrAstBuilder` to unify ast construction (#5310) by
@hyf0
- rolldown_plugin_chunk_import_map: basic implementation (#5307) by
@shulaoda
- add `watch.onInvalidate` (#5239) by @situ2001
- rolldown_plugin_chunk_import_map: implement initial `render_chunk`
logic (#5306) by @shulaoda
- rolldown: oxc v0.77.1 (#5304) by @Boshen
- js: expose `experimental.incrementalBuild` option (#5300) by
@IWANABETHATGUY
- js: support `experimental.onDemandWrapping` option (#5299) by
@IWANABETHATGUY
- support on demand wrapping for entry chunk (#5291) by @IWANABETHATGUY
- rolldown_plugin_chunk_import_map: initialize (#5289) by @shulaoda
- show owner module id for "canonical name not found for" errors (#5288)
by @sapphi-red

### 🐛 Bug Fixes

- only transform VarDeclaration when enable `keepNames` (#5323) by
@IWANABETHATGUY
- keepNames with special Ifstmt (#5320) by @IWANABETHATGUY
- incremental watch panic when adding dynamic import (#5309) by
@IWANABETHATGUY
- make leaf module wrapping optimization opt-in (#5305) by
@IWANABETHATGUY
- `keepNames` should consider exportNamed function declaration (#5298)
by @IWANABETHATGUY
- undefined `process.versions` for browser build (#5295) by @sxzz
- sanitizeFileName: entry name should be sanitized (#5283) by @shulaoda
- minify-internal-exports: ensure minifying internal exports stably
(#5281) by @hyf0
- keep legal and annotation comments for `minify: 'dce-only'` (#5280) by
@sapphi-red
- unstable chunk generation when `preserveEntrySignatures: false` is
used (#5274) by @IWANABETHATGUY

### 🚜 Refactor

- pass the while CodegenOptions to `EcmaCompiler::minify` (#5279) by
@sapphi-red
- avoid iterate `canonical_exports` twice (#5276) by @IWANABETHATGUY

### 📚 Documentation

- pluginutils: add README file (#5262) by @TheAlexLichter

### ⚡ Performance

- inline function expression when rewriting `name` property with
`keepNames` enabled (#5321) by @IWANABETHATGUY
- rolldown_sourcemap: cache source id -> source text mapping (#5285) by
@Boshen
- rolldown_sourcemap: disable rayon (#5284) by @Boshen

### 🧪 Testing

- rust: prevent meaningless snapshot change from bumping oxc runtime
versions (#5312) by @hyf0

### ⚙️ Miscellaneous Tasks

- upgrade to NAPI-RS 3.0 stable (#5324) by @Brooooooklyn
- infra: add onlyBuiltDependencies (#5287) by @situ2001
- improve the order of import keys in the exports field (#5314) by @btea
- deps: update dependency rolldown-plugin-dts to v0.13.14 (#5293) by
@renovate[bot]
- deps: lock file maintenance rust crates (#5267) by @renovate[bot]
- deps: lock file maintenance npm packages (#5266) by @renovate[bot]
- deps: update github-actions (#5265) by @renovate[bot]

### ❤️ New Contributors

* @situ2001 made their first contribution in
[#5287](#5287)

Co-authored-by: IWANABETHATGUY <17974631+IWANABETHATGUY@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants