Skip to content

perf(rolldown_sourcemap): disable rayon#5284

Merged
Boshen merged 1 commit intomainfrom
perf-sourcemap
Jul 15, 2025
Merged

perf(rolldown_sourcemap): disable rayon#5284
Boshen merged 1 commit intomainfrom
perf-sourcemap

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Jul 15, 2025

Sourcemap processing should be kept on its own thread because there are other threads processing the same thing, spawning threads is expensive.

image

@netlify
Copy link

netlify bot commented Jul 15, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 7e3236c
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/6875eb787ca54a000979ab00

@github-actions
Copy link
Contributor

Benchmarks Rust

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     81.6±2.45ms        ? ?/sec    1.03     83.8±3.49ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     92.8±2.38ms        ? ?/sec    1.01     93.4±2.00ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    118.9±2.05ms        ? ?/sec    1.00    118.4±2.20ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.01    140.7±2.34ms        ? ?/sec    1.00    139.5±2.63ms        ? ?/sec
bundle/bundle@threejs                                        1.00     43.8±2.62ms        ? ?/sec    1.00     43.7±1.54ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.04     54.8±2.53ms        ? ?/sec    1.00     52.5±0.93ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    450.3±6.11ms        ? ?/sec    1.02    457.8±9.07ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.02    539.5±6.05ms        ? ?/sec    1.00    527.4±5.54ms        ? ?/sec
scan/scan@rome_ts                                            1.00     91.2±1.73ms        ? ?/sec    1.00     91.1±1.85ms        ? ?/sec
scan/scan@threejs                                            1.02     32.3±1.83ms        ? ?/sec    1.00     31.6±0.55ms        ? ?/sec
scan/scan@threejs10x                                         1.00    332.7±3.43ms        ? ?/sec    1.00    333.2±6.00ms        ? ?/sec

@Boshen Boshen marked this pull request as ready for review July 15, 2025 06:08
@Boshen
Copy link
Member Author

Boshen commented Jul 15, 2025

No changes in benchmark :-)

Copy link
Member Author

Boshen commented Jul 15, 2025

@Boshen Boshen added this pull request to the merge queue Jul 15, 2025
Merged via the queue into main with commit 89ebcb0 Jul 15, 2025
29 checks passed
@Boshen Boshen deleted the perf-sourcemap branch July 15, 2025 07:49
This was referenced Jul 17, 2025
shulaoda pushed a commit that referenced this pull request Jul 17, 2025
## [1.0.0-beta.28] - 2025-07-17

### 🚀 Features

- rolldown: oxc v0.77.2 (#5328) by @Boshen
- hmr: add `module` and `exports` parameters to CJS initializer
functions (#5322) by @hyf0
- rolldown_plugin_transform: align with `vitejs/rolldown-vite#318`
(#5318) by @shulaoda
- rolldown_plugin_transform: align with `vitejs/rolldown-vite#315`
(#5315) by @shulaoda
- hmr: automatically disable treeshaking in hmr (#5311) by @hyf0
- hmr: use `trait HmrAstBuilder` to unify ast construction (#5310) by
@hyf0
- rolldown_plugin_chunk_import_map: basic implementation (#5307) by
@shulaoda
- add `watch.onInvalidate` (#5239) by @situ2001
- rolldown_plugin_chunk_import_map: implement initial `render_chunk`
logic (#5306) by @shulaoda
- rolldown: oxc v0.77.1 (#5304) by @Boshen
- js: expose `experimental.incrementalBuild` option (#5300) by
@IWANABETHATGUY
- js: support `experimental.onDemandWrapping` option (#5299) by
@IWANABETHATGUY
- support on demand wrapping for entry chunk (#5291) by @IWANABETHATGUY
- rolldown_plugin_chunk_import_map: initialize (#5289) by @shulaoda
- show owner module id for "canonical name not found for" errors (#5288)
by @sapphi-red

### 🐛 Bug Fixes

- only transform VarDeclaration when enable `keepNames` (#5323) by
@IWANABETHATGUY
- keepNames with special Ifstmt (#5320) by @IWANABETHATGUY
- incremental watch panic when adding dynamic import (#5309) by
@IWANABETHATGUY
- make leaf module wrapping optimization opt-in (#5305) by
@IWANABETHATGUY
- `keepNames` should consider exportNamed function declaration (#5298)
by @IWANABETHATGUY
- undefined `process.versions` for browser build (#5295) by @sxzz
- sanitizeFileName: entry name should be sanitized (#5283) by @shulaoda
- minify-internal-exports: ensure minifying internal exports stably
(#5281) by @hyf0
- keep legal and annotation comments for `minify: 'dce-only'` (#5280) by
@sapphi-red
- unstable chunk generation when `preserveEntrySignatures: false` is
used (#5274) by @IWANABETHATGUY

### 🚜 Refactor

- pass the while CodegenOptions to `EcmaCompiler::minify` (#5279) by
@sapphi-red
- avoid iterate `canonical_exports` twice (#5276) by @IWANABETHATGUY

### 📚 Documentation

- pluginutils: add README file (#5262) by @TheAlexLichter

### ⚡ Performance

- inline function expression when rewriting `name` property with
`keepNames` enabled (#5321) by @IWANABETHATGUY
- rolldown_sourcemap: cache source id -> source text mapping (#5285) by
@Boshen
- rolldown_sourcemap: disable rayon (#5284) by @Boshen

### 🧪 Testing

- rust: prevent meaningless snapshot change from bumping oxc runtime
versions (#5312) by @hyf0

### ⚙️ Miscellaneous Tasks

- upgrade to NAPI-RS 3.0 stable (#5324) by @Brooooooklyn
- infra: add onlyBuiltDependencies (#5287) by @situ2001
- improve the order of import keys in the exports field (#5314) by @btea
- deps: update dependency rolldown-plugin-dts to v0.13.14 (#5293) by
@renovate[bot]
- deps: lock file maintenance rust crates (#5267) by @renovate[bot]
- deps: lock file maintenance npm packages (#5266) by @renovate[bot]
- deps: update github-actions (#5265) by @renovate[bot]

### ❤️ New Contributors

* @situ2001 made their first contribution in
[#5287](#5287)

Co-authored-by: IWANABETHATGUY <17974631+IWANABETHATGUY@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants