refactor: pass the while CodegenOptions to EcmaCompiler::minify#5279
Merged
sapphi-red merged 1 commit intomainfrom Jul 15, 2025
Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
✅ Deploy Preview for rolldown-rs canceled.
|
e7797aa to
ee03ed6
Compare
hyf0
approved these changes
Jul 15, 2025
Contributor
Benchmarks Rust
|
This was referenced Jul 17, 2025
shulaoda
pushed a commit
that referenced
this pull request
Jul 17, 2025
## [1.0.0-beta.28] - 2025-07-17 ### 🚀 Features - rolldown: oxc v0.77.2 (#5328) by @Boshen - hmr: add `module` and `exports` parameters to CJS initializer functions (#5322) by @hyf0 - rolldown_plugin_transform: align with `vitejs/rolldown-vite#318` (#5318) by @shulaoda - rolldown_plugin_transform: align with `vitejs/rolldown-vite#315` (#5315) by @shulaoda - hmr: automatically disable treeshaking in hmr (#5311) by @hyf0 - hmr: use `trait HmrAstBuilder` to unify ast construction (#5310) by @hyf0 - rolldown_plugin_chunk_import_map: basic implementation (#5307) by @shulaoda - add `watch.onInvalidate` (#5239) by @situ2001 - rolldown_plugin_chunk_import_map: implement initial `render_chunk` logic (#5306) by @shulaoda - rolldown: oxc v0.77.1 (#5304) by @Boshen - js: expose `experimental.incrementalBuild` option (#5300) by @IWANABETHATGUY - js: support `experimental.onDemandWrapping` option (#5299) by @IWANABETHATGUY - support on demand wrapping for entry chunk (#5291) by @IWANABETHATGUY - rolldown_plugin_chunk_import_map: initialize (#5289) by @shulaoda - show owner module id for "canonical name not found for" errors (#5288) by @sapphi-red ### 🐛 Bug Fixes - only transform VarDeclaration when enable `keepNames` (#5323) by @IWANABETHATGUY - keepNames with special Ifstmt (#5320) by @IWANABETHATGUY - incremental watch panic when adding dynamic import (#5309) by @IWANABETHATGUY - make leaf module wrapping optimization opt-in (#5305) by @IWANABETHATGUY - `keepNames` should consider exportNamed function declaration (#5298) by @IWANABETHATGUY - undefined `process.versions` for browser build (#5295) by @sxzz - sanitizeFileName: entry name should be sanitized (#5283) by @shulaoda - minify-internal-exports: ensure minifying internal exports stably (#5281) by @hyf0 - keep legal and annotation comments for `minify: 'dce-only'` (#5280) by @sapphi-red - unstable chunk generation when `preserveEntrySignatures: false` is used (#5274) by @IWANABETHATGUY ### 🚜 Refactor - pass the while CodegenOptions to `EcmaCompiler::minify` (#5279) by @sapphi-red - avoid iterate `canonical_exports` twice (#5276) by @IWANABETHATGUY ### 📚 Documentation - pluginutils: add README file (#5262) by @TheAlexLichter ### ⚡ Performance - inline function expression when rewriting `name` property with `keepNames` enabled (#5321) by @IWANABETHATGUY - rolldown_sourcemap: cache source id -> source text mapping (#5285) by @Boshen - rolldown_sourcemap: disable rayon (#5284) by @Boshen ### 🧪 Testing - rust: prevent meaningless snapshot change from bumping oxc runtime versions (#5312) by @hyf0 ### ⚙️ Miscellaneous Tasks - upgrade to NAPI-RS 3.0 stable (#5324) by @Brooooooklyn - infra: add onlyBuiltDependencies (#5287) by @situ2001 - improve the order of import keys in the exports field (#5314) by @btea - deps: update dependency rolldown-plugin-dts to v0.13.14 (#5293) by @renovate[bot] - deps: lock file maintenance rust crates (#5267) by @renovate[bot] - deps: lock file maintenance npm packages (#5266) by @renovate[bot] - deps: update github-actions (#5265) by @renovate[bot] ### ❤️ New Contributors * @situ2001 made their first contribution in [#5287](#5287) Co-authored-by: IWANABETHATGUY <17974631+IWANABETHATGUY@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a pure refactor and should not change any behavior.
I changed the code to set all
CodegenOptionsin a single place so that it's easier to understand the final value of the option.