Skip to content

refactor: avoid iterate canonical_exports twice#5276

Merged
IWANABETHATGUY merged 1 commit intomainfrom
07-14-refactor_avoid_iterate_canonical_exports_twice
Jul 14, 2025
Merged

refactor: avoid iterate canonical_exports twice#5276
IWANABETHATGUY merged 1 commit intomainfrom
07-14-refactor_avoid_iterate_canonical_exports_twice

Conversation

@IWANABETHATGUY
Copy link
Member

No description provided.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review July 14, 2025 10:32
@netlify
Copy link

netlify bot commented Jul 14, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit a933c8a
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/6874dec5ebd8d800083a10fb

@IWANABETHATGUY IWANABETHATGUY force-pushed the 07-14-refactor_avoid_iterate_canonical_exports_twice branch from 9b6804b to a933c8a Compare July 14, 2025 10:41
@github-actions
Copy link
Contributor

Benchmarks Rust

  • target: main(a3a4228)
  • pr: 07-14-refactor_avoid_iterate_canonical_exports_twice(a933c8a)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.01     76.2±1.65ms        ? ?/sec    1.00     75.6±1.90ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.01     87.3±1.51ms        ? ?/sec    1.00     86.1±1.51ms        ? ?/sec
bundle/bundle@rome_ts                                        1.02    115.0±4.40ms        ? ?/sec    1.00    112.6±1.88ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    133.5±1.88ms        ? ?/sec    1.00    133.7±1.72ms        ? ?/sec
bundle/bundle@threejs                                        1.01     41.9±2.45ms        ? ?/sec    1.00     41.3±1.19ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.03     51.8±2.15ms        ? ?/sec    1.00     50.4±0.76ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    438.0±5.33ms        ? ?/sec    1.00    437.5±3.97ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    511.2±3.49ms        ? ?/sec    1.00    511.6±7.75ms        ? ?/sec
scan/scan@rome_ts                                            1.00     88.3±2.38ms        ? ?/sec    1.03     90.9±1.49ms        ? ?/sec
scan/scan@threejs                                            1.00     31.0±1.71ms        ? ?/sec    1.01     31.4±1.97ms        ? ?/sec
scan/scan@threejs10x                                         1.00    322.9±3.54ms        ? ?/sec    1.01    327.0±4.01ms        ? ?/sec

@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Jul 14, 2025
Merged via the queue into main with commit f918c76 Jul 14, 2025
23 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the 07-14-refactor_avoid_iterate_canonical_exports_twice branch July 14, 2025 14:53
This was referenced Jul 17, 2025
shulaoda pushed a commit that referenced this pull request Jul 17, 2025
## [1.0.0-beta.28] - 2025-07-17

### 🚀 Features

- rolldown: oxc v0.77.2 (#5328) by @Boshen
- hmr: add `module` and `exports` parameters to CJS initializer
functions (#5322) by @hyf0
- rolldown_plugin_transform: align with `vitejs/rolldown-vite#318`
(#5318) by @shulaoda
- rolldown_plugin_transform: align with `vitejs/rolldown-vite#315`
(#5315) by @shulaoda
- hmr: automatically disable treeshaking in hmr (#5311) by @hyf0
- hmr: use `trait HmrAstBuilder` to unify ast construction (#5310) by
@hyf0
- rolldown_plugin_chunk_import_map: basic implementation (#5307) by
@shulaoda
- add `watch.onInvalidate` (#5239) by @situ2001
- rolldown_plugin_chunk_import_map: implement initial `render_chunk`
logic (#5306) by @shulaoda
- rolldown: oxc v0.77.1 (#5304) by @Boshen
- js: expose `experimental.incrementalBuild` option (#5300) by
@IWANABETHATGUY
- js: support `experimental.onDemandWrapping` option (#5299) by
@IWANABETHATGUY
- support on demand wrapping for entry chunk (#5291) by @IWANABETHATGUY
- rolldown_plugin_chunk_import_map: initialize (#5289) by @shulaoda
- show owner module id for "canonical name not found for" errors (#5288)
by @sapphi-red

### 🐛 Bug Fixes

- only transform VarDeclaration when enable `keepNames` (#5323) by
@IWANABETHATGUY
- keepNames with special Ifstmt (#5320) by @IWANABETHATGUY
- incremental watch panic when adding dynamic import (#5309) by
@IWANABETHATGUY
- make leaf module wrapping optimization opt-in (#5305) by
@IWANABETHATGUY
- `keepNames` should consider exportNamed function declaration (#5298)
by @IWANABETHATGUY
- undefined `process.versions` for browser build (#5295) by @sxzz
- sanitizeFileName: entry name should be sanitized (#5283) by @shulaoda
- minify-internal-exports: ensure minifying internal exports stably
(#5281) by @hyf0
- keep legal and annotation comments for `minify: 'dce-only'` (#5280) by
@sapphi-red
- unstable chunk generation when `preserveEntrySignatures: false` is
used (#5274) by @IWANABETHATGUY

### 🚜 Refactor

- pass the while CodegenOptions to `EcmaCompiler::minify` (#5279) by
@sapphi-red
- avoid iterate `canonical_exports` twice (#5276) by @IWANABETHATGUY

### 📚 Documentation

- pluginutils: add README file (#5262) by @TheAlexLichter

### ⚡ Performance

- inline function expression when rewriting `name` property with
`keepNames` enabled (#5321) by @IWANABETHATGUY
- rolldown_sourcemap: cache source id -> source text mapping (#5285) by
@Boshen
- rolldown_sourcemap: disable rayon (#5284) by @Boshen

### 🧪 Testing

- rust: prevent meaningless snapshot change from bumping oxc runtime
versions (#5312) by @hyf0

### ⚙️ Miscellaneous Tasks

- upgrade to NAPI-RS 3.0 stable (#5324) by @Brooooooklyn
- infra: add onlyBuiltDependencies (#5287) by @situ2001
- improve the order of import keys in the exports field (#5314) by @btea
- deps: update dependency rolldown-plugin-dts to v0.13.14 (#5293) by
@renovate[bot]
- deps: lock file maintenance rust crates (#5267) by @renovate[bot]
- deps: lock file maintenance npm packages (#5266) by @renovate[bot]
- deps: update github-actions (#5265) by @renovate[bot]

### ❤️ New Contributors

* @situ2001 made their first contribution in
[#5287](#5287)

Co-authored-by: IWANABETHATGUY <17974631+IWANABETHATGUY@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants