intial review and update to staging#7
Merged
rdeutz merged 21 commits intordeutz:com_associations_rewrite_mergefrom Jan 11, 2017
Merged
intial review and update to staging#7rdeutz merged 21 commits intordeutz:com_associations_rewrite_mergefrom
rdeutz merged 21 commits intordeutz:com_associations_rewrite_mergefrom
Conversation
Expose cache_path config, catch exceptions cleaning cache on config save
Reduce the usage of the variable
* Migrate text field to plugin * Moved field description lookup to plugin event * Remove not needed functions * Renamed to specification * Adapt gallery * Renamed to field types * Remove dom interface * Prepare the field trough an event * Remove domfield interface * Add text layout * Move output to layout and better multifields support * HoHoHoHo Travis * Change language strings to be more inline with Joomal core * Add list plugin * Add calendar plugin * Add checkboxes plugin * Add color plugin * Add editor plugin * Add image plugin * Add imagelist plugin * Add integer plugin * Add media plugin * Add radio plugin * Add sql plugin * Add text area plugin * Add url plugin * Add user plugin * Add user group plugin * Making travis happy * Adapting the installer scripts * Some fixes * Fixed comment copy paste * Cleanup of not used code * Alpha ordering language strings * Adapting the frontend ini lib language file to be the same as back end * Add missing description language string for gallery
…oomla#13516) * Fix “You are not authorised to view this” when mod_expires enabled Closes joomla#8731 Dec 18, 2015 Closes joomla#8757 Dec 21, 2015 Closes joomla#9013 Jan 28, 2016 Closes joomla#9145 Feb 17, 2016 Closes joomla#9615 Mar 26, 2016 Closes joomla#10753 Jun 7, 2016 * code style * Unit test refactoring (cannot do it the old way as relative dynamic dates in headers) * Remove duplicate header output for charset * Better Unit Tests * More unit tests :) * Close after setting headers * Do not cache the response to this, its a redirect
…lues (joomla#13513) * normalize ucm_content table in install sql * postgresql modification updates * sqlazure on update * mysql updates * remove text - copy paste error
…ues (joomla#13514) * installation sql changes * updates sql
…a#13512) * Update languages.php * ups
…deutz/joomla-cms into com_associations_rewrite_merge
rdeutz
pushed a commit
that referenced
this pull request
Jun 27, 2020
* This is a combination of 8 commits. This is the 1st commit message: > First WIP version of supporting nested subforms. This is the commit message #2: > Fix nested subforms not getting correct name attribute on input fields. This is the commit message #3: > Fix subform rows having invalid index, fix small typo. This is the commit message #4: > Replace the unique subform id via random bytes by just an increasing integer in the fields type rendering process. This is the commit message #5: > Implement feedback from PR at Joomla; > - Use a <template> HTML element for the template of the subform rows, > not a url encoded string inside of a <script> element. > - Fix code style errors reported by phpcs. > - Make the fixing of the unique attributes (name, id, etc) of input elements > of nested subform rows more errorprone, using the same method as the main > subform row. > - Manually add a minified version of the javascript file. This is the commit message #6: > Fix failing javascript tests due to changed structure of subform repeatable template container. This is the commit message #7: > Change subform repeatable javascript test to correctly check on > 0-indexed rows, previously they have been 1-indexed. This is the commit message #8: > Fix a problem where multi-level subforms on the same level doesnt trigger their template correctly. > Additionally added a note why the fixScripts() method is broken and how it could get better. * Commit code styling errors and add an aria label for the outermost 'add' button. * Fix double group-add button on repeatable subform type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
please review: f50ad78
speziell the
$extension -> $extensionNamechanges!