Skip to content

[Mssql] Fix syntax error when installing a language in backend#13512

Merged
rdeutz merged 2 commits intojoomla:stagingfrom
andrepereiradasilva:patch-17
Jan 10, 2017
Merged

[Mssql] Fix syntax error when installing a language in backend#13512
rdeutz merged 2 commits intojoomla:stagingfrom
andrepereiradasilva:patch-17

Conversation

@andrepereiradasilva
Copy link
Copy Markdown
Contributor

@andrepereiradasilva andrepereiradasilva commented Jan 8, 2017 •
edited by jeckodevelopment
Loading

Pull Request for Issue #13508 (use issue part).

Summary of Changes

Fix for #13508 (use issue part)

Testing Instructions

  1. apply patch
  2. Install a language in mssql. no use error. note you will get another error, but the use error is fixxed here

Documentation Changes Required

None

@andrepereiradasilva andrepereiradasilva mentioned this pull request Jan 8, 2017
Closed
@waader
Copy link
Copy Markdown
Contributor

waader commented Jan 8, 2017 •
edited
Loading

The semicolon in line 65 should be deleted. After that I get:
Fatal error: Using $this when not in object context in joomla37\administrator\components\com_installer\models\languages.php on line 151

@andrepereiradasilva
Copy link
Copy Markdown
Contributor Author

andrepereiradasilva commented Jan 8, 2017

semicolon deleted, thanks
that fatal error doesn't seem related to this mssql issue this PR solves.
Please open a new issue for that

@zero-24
Copy link
Copy Markdown
Contributor

zero-24 commented Jan 8, 2017

@waader

The semicolon in line 65 should be deleted. After that I get:
Fatal error: Using $this when not in object context in joomla37\administrator\components\com_installer\models\languages.php on line 151

https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_installer/models/languages.php#L151

Can you try staging? at this line we have no $this in staging 😄

@waader
Copy link
Copy Markdown
Contributor

waader commented Jan 8, 2017

With your patch applied it "becomes" line 151.

@alikon
Copy link
Copy Markdown
Contributor

alikon commented Jan 9, 2017 •
edited
Loading

I have tested this item ✅ successfully on 65f086a

solve [Microsoft][SQL Server Native Client 11.0][SQL Server]Incorrect syntax near the keyword 'use'.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13512.

@waader
Copy link
Copy Markdown
Contributor

waader commented Jan 10, 2017

@alikon Did you do a code review? I keep getting the mentioned syntax error after applying the patch. I tried with latest staging, no data installed.

@andrepereiradasilva
Copy link
Copy Markdown
Contributor Author

andrepereiradasilva commented Jan 10, 2017

@waader the thing is that seems a different error. another one. this PR only solves the use part.

@waader
Copy link
Copy Markdown
Contributor

waader commented Jan 10, 2017

I have tested this item ✅ successfully on 65f086a

Ok, thanks!

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13512.

@jeckodevelopment
Copy link
Copy Markdown
Member

jeckodevelopment commented Jan 10, 2017

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13512.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 10, 2017
@jeckodevelopment jeckodevelopment added this to the Joomla 3.7.0 milestone Jan 10, 2017
@rdeutz rdeutz merged commit c418c43 into joomla:staging Jan 10, 2017
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 10, 2017
@andrepereiradasilva andrepereiradasilva deleted the patch-17 branch January 10, 2017 17:33
roland-d added a commit to roland-d/joomla-cms that referenced this pull request Jan 13, 2017
@roland-d
Merge branch 'staging' of github.com:roland-d/joomla-cms into trackas…
aa225cb 
…sets-option

* 'staging' of github.com:roland-d/joomla-cms: (136 commits)
  Clean up old code in cache.php file (joomla#12183)
  Fixing search for MySQL (joomla#13571)
  Unnecessary double quotes in  /libraries/joomla (joomla#13372)
  Some improvements in tests #3: (joomla#13402)
  It's 2017. Happy New Year
  Fixing a typo in gallery plugin language files
  Add stripslashes to mssql result columns. (joomla#13534)
  remove unneeded space from btn-group/radio/checkboxes (joomla#12003)
  typo (joomla#13563)
  Remove default value from the field params to inherit from plugin
  Remove multiple parameter from user field
  Fix name of component helper in fieldshelper (joomla#13539)
  remove duplicated code (joomla#13550)
  Fix invalid string that causes the ini file not to load (joomla#13544)
  Catch "expects parameter 2 to be string" error
  Take complete context for group lookup (joomla#13538)
  [Mssql] Fix syntax error when installing a language in backend (joomla#13512)
  Normalize #__categories table across 3 db systems and add default values (joomla#13514)
  Normalize #__ucm_content table across 3 db systems and add default values (joomla#13513)
  Update config.xml (joomla#13503)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Joomla 3.7.0

Development

Successfully merging this pull request may close these issues.

7 participants

@andrepereiradasilva @waader @zero-24 @alikon @jeckodevelopment @rdeutz @joomla-cms-bot