remove unneeded space from btn-group/radio/checkboxes by Minei3oat · Pull Request #12003 · joomla/joomla-cms

Minei3oat · 2016-09-10T19:57:53Z

Pull Request for Issue # .

Summary of Changes

In vertical from there was unneeded space between the label and some controls (radio, checkboxes) under it.
Removed padding-top of btn-group to align with label.
Added 2px padding-top to btn-group-yesno in isis to compensate 2px less padding-top of each button to have the buttons aligned with the label.

Testing Instructions

Look at some vertical forms in backend (Isis) and frontend (Protostar):
There is 5px more space between the label and the radio (btn-group as well because it is type radio) / checkboxes field than other fields. After aplying this PR the additional space should disapear.
Look at some horizontal forms in backend (Isis) and frontend (Protostar):
Before the PR the text of btn-group is not aligned to the text of the label. After aplying this PR it should be.

Documentation Changes Required

none

Bakual · 2016-09-10T20:41:51Z

Usually we don't change anything in 3rd party files.
media/jui/less/forms.less is coming from Bootstrap and is used by 3rd party templates, thus it has an effect beyond our core templates.

Try to do the fix in the Protostar/Isis template files.

Minei3oat · 2016-09-10T21:31:41Z

Hm, in the backend there is a lot of form-vertical in from-horizontal. This is ugly because form-horizontal adds some style for horizontal forms which aren't removed by form-vertical.
The from-vertical is created by https://github.com/joomla/joomla-cms/blob/staging/layouts/joomla/edit/global.php#L47. So all components which uses JLayoutHelper::render('joomla.edit.global', $this); in a form-horizontal produce this problem.

brianteeman · 2016-10-09T09:53:46Z

@Minei3oat Please include some before and after screenshots. That will help you to get testers for this

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12003.}

Minei3oat · 2016-10-11T20:35:23Z

I hope the image helps.

brianteeman · 2016-10-11T20:38:18Z

Well at least I have a clue what you were talking about now. Hopefully others will as well.

brianteeman · 2016-10-11T20:41:10Z

I am not a CSS expert but I see that you have added 0px and I was under the impression that you don't use a unit when the value is 0

brianteeman · 2016-10-12T22:07:29Z

I have tested this item ✅ successfully on 653d710

Thanks for the image - it made it easy for me to confirm the issue you were describing and to confirm that this PR fixed the issue

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12003.}

brianteeman · 2016-10-14T19:42:12Z

I have tested this item ✅ successfully on 8405a06

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12003.}

Minei3oat · 2016-10-14T19:42:20Z

It seems equal weather to use a unit for zero values or not. It is used both in the templates' less files. Since Bootstrap uses no units on zero values I've dropped them.

brianteeman · 2016-10-14T19:51:49Z

I checked and technically its optional but it seems to be preferred to
remove it
https://www.w3.org/TR/css3-values/#lengths

On 14 October 2016 at 20:42, Minei3oat notifications@github.com wrote:

It seems equal weather to use a unit for zero values or not. It is used
both in the templates' less files. Since Bootstrap uses no units on zero
values I've dropped them.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#12003 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8TRjeoCq1FfFFStk-gPMRKF1L0V7ks5qz9sfgaJpZM4J5z9A
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

coolcat-creations · 2016-12-06T21:40:16Z

This patch reverts the new bright green color too ?
i like the brighter one more...
beside then tested successfully on the heightchange...

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12003.}

Minei3oat · 2016-12-06T21:52:57Z

This pull request changes no colors in the less files. But other pull requests submitted after I created mine have changed the colors and I didn't updated this one. So the templates css-files in this pull request are compiled with the old colors.

coolcat-creations · 2016-12-07T13:15:04Z

I have tested this item ✅ successfully on 8405a06

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12003.}

jeckodevelopment · 2016-12-07T13:50:35Z

@Minei3oat can you please look at the conflicts?

administrator/templates/isis/css/template-rtl.css
administrator/templates/isis/css/template.css
administrator/templates/isis/less/template.less

Minei3oat · 2016-12-10T20:27:32Z

I hope, I resolved the conflicts correct

In vertical from there was unneeded space between the label and the controls under it. Removed padding-top of btn-group to align with label. Added 2px padding-top to btn-group-yes in isis to compensate 2px less padding-top of each button to have the buttons aligned with the label.

This reverts commit a086850.

ghost · 2017-01-03T06:49:17Z

I have tested this item 🔴 unsuccessfully on b48f2ad

Tested with Joomla! 3.7.0-alpha1:

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12003.}

rvbgnu · 2017-01-08T17:53:15Z

I have tested this item ✅ successfully on b48f2ad

I have checked the issue before the patch

And successfully tested with the patch!

Thanks @Minei3oat !

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12003.}

Minei3oat · 2017-01-09T14:08:18Z

@franz-wohlkoenig I've tested this PR with 3.7.0 Alpha 1 in the browsers IE 11, Firefox 45 and Google Chrome 55 but I can't find a problem.

ghost · 2017-01-09T14:13:11Z

I have tested this item ✅ successfully on b48f2ad

Tested on a clean Installation works, my fault.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12003.}

jeckodevelopment · 2017-01-10T21:17:16Z

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12003.}

* remove unneeded space from btn-group/radio/checkboxes In vertical from there was unneeded space between the label and the controls under it. Removed padding-top of btn-group to align with label. Added 2px padding-top to btn-group-yes in isis to compensate 2px less padding-top of each button to have the buttons aligned with the label. * move code from forms.less to protostar / isis This reverts commit a086850. * correct comment * removed unit from zero values

…sets-option * 'staging' of github.com:roland-d/joomla-cms: (136 commits) Clean up old code in cache.php file (joomla#12183) Fixing search for MySQL (joomla#13571) Unnecessary double quotes in /libraries/joomla (joomla#13372) Some improvements in tests #3: (joomla#13402) It's 2017. Happy New Year Fixing a typo in gallery plugin language files Add stripslashes to mssql result columns. (joomla#13534) remove unneeded space from btn-group/radio/checkboxes (joomla#12003) typo (joomla#13563) Remove default value from the field params to inherit from plugin Remove multiple parameter from user field Fix name of component helper in fieldshelper (joomla#13539) remove duplicated code (joomla#13550) Fix invalid string that causes the ini file not to load (joomla#13544) Catch "expects parameter 2 to be string" error Take complete context for group lookup (joomla#13538) [Mssql] Fix syntax error when installing a language in backend (joomla#13512) Normalize #__categories table across 3 db systems and add default values (joomla#13514) Normalize #__ucm_content table across 3 db systems and add default values (joomla#13513) Update config.xml (joomla#13503) ...

* remove unneeded space from btn-group/radio/checkboxes In vertical from there was unneeded space between the label and the controls under it. Removed padding-top of btn-group to align with label. Added 2px padding-top to btn-group-yes in isis to compensate 2px less padding-top of each button to have the buttons aligned with the label. * move code from forms.less to protostar / isis This reverts commit a086850. * correct comment * removed unit from zero values

joomla-cms-bot added the PR-staging label Sep 10, 2016

Minei3oat mentioned this pull request Sep 24, 2016

remove unneeded space from btn-group/radio/checkboxes Bakual/Allrounder#18

Merged

Minei3oat force-pushed the betterForm branch from 8405a06 to 2f0bb8c Compare December 10, 2016 19:51

Minei3oat added 4 commits December 28, 2016 21:33

move code from forms.less to protostar / isis

87fcc02

This reverts commit a086850.

correct comment

5542b51

removed unit from zero values

b48f2ad

Minei3oat force-pushed the betterForm branch from 2f0bb8c to b48f2ad Compare December 28, 2016 20:43

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 10, 2017

jeckodevelopment added this to the Joomla 3.7.0 milestone Jan 10, 2017

rdeutz merged commit d3e1cc5 into joomla:staging Jan 11, 2017

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 11, 2017

Minei3oat deleted the betterForm branch January 11, 2017 20:40

Uh oh!

Conversation

Minei3oat commented Sep 10, 2016 • edited by jeckodevelopment Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of Changes

Testing Instructions

Documentation Changes Required

Uh oh!

Bakual commented Sep 10, 2016

Uh oh!

Minei3oat commented Sep 10, 2016

Uh oh!

brianteeman commented Oct 9, 2016

Uh oh!

Minei3oat commented Oct 11, 2016

Uh oh!

brianteeman commented Oct 11, 2016

Uh oh!

brianteeman commented Oct 11, 2016

Uh oh!

brianteeman commented Oct 12, 2016

Uh oh!

brianteeman commented Oct 14, 2016

Uh oh!

Minei3oat commented Oct 14, 2016

Uh oh!

brianteeman commented Oct 14, 2016

Uh oh!

coolcat-creations commented Dec 6, 2016

Uh oh!

Minei3oat commented Dec 6, 2016

Uh oh!

coolcat-creations commented Dec 7, 2016

Uh oh!

jeckodevelopment commented Dec 7, 2016

Uh oh!

Minei3oat commented Dec 10, 2016

Uh oh!

ghost commented Jan 3, 2017 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rvbgnu commented Jan 8, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Minei3oat commented Jan 9, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Jan 9, 2017

Uh oh!

jeckodevelopment commented Jan 10, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Minei3oat commented Sep 10, 2016 •

edited by jeckodevelopment

Loading

ghost commented Jan 3, 2017 •

edited by ghost

Loading

rvbgnu commented Jan 8, 2017 •

edited

Loading

Minei3oat commented Jan 9, 2017 •

edited

Loading