Skip to content

Normalize #__ucm_content table across 3 db systems and add default values#13513

Merged
rdeutz merged 5 commits intojoomla:stagingfrom
andrepereiradasilva:issue-13510
Jan 10, 2017
Merged

Normalize #__ucm_content table across 3 db systems and add default values#13513
rdeutz merged 5 commits intojoomla:stagingfrom
andrepereiradasilva:issue-13510

Conversation

@andrepereiradasilva
Copy link
Copy Markdown
Contributor

@andrepereiradasilva andrepereiradasilva commented Jan 8, 2017 •
edited by joomla-cms-bot
Loading

Pull Request for Issue #13510 and probably other issues relating ucm_content table in more strict db systems (which in joomla 4.0 mysql will be also).

Summary of Changes

Normalize the #__ucm_content table across db systems.
Only tested in mysql.
@waader please check mssql
@alikon please also check postgresql and mssql.

Testing Instructions

  1. SQL code review
  2. Test update: Apply patch, manually run the sql query for your Db system, confirm db table, confirm all fine
  3. Test install: apply patch, delete configuration.php do a normal install, confirm db table, confirm all fine

Documentation Changes Required

None.

This was referenced Jan 8, 2017
Closed
Closed
@waader
Copy link
Copy Markdown
Contributor

waader commented Jan 8, 2017

Works for mssql and postgres apart from the update file for postgres. I deleted "TEXT" in the following lines and then it worked:

ALTER TABLE "#__ucm_content" ALTER COLUMN "core_body" SET DEFAULT '';
ALTER TABLE "#__ucm_content" ALTER COLUMN "core_params" SET DEFAULT '';
ALTER TABLE "#__ucm_content" ALTER COLUMN "core_metadata" SET DEFAULT '';
ALTER TABLE "#__ucm_content" ALTER COLUMN "core_images" SET DEFAULT '';
ALTER TABLE "#__ucm_content" ALTER COLUMN "core_urls" SET DEFAULT '';
ALTER TABLE "#__ucm_content" ALTER COLUMN "core_metakey" SET DEFAULT '';
ALTER TABLE "#__ucm_content" ALTER COLUMN "core_metadesc" SET DEFAULT '';

@andrepereiradasilva
Copy link
Copy Markdown
Contributor Author

andrepereiradasilva commented Jan 8, 2017

"text" removed - copy paste error . sorry

@waader
Copy link
Copy Markdown
Contributor

waader commented Jan 8, 2017

I have tested this item ✅ successfully on 6f9254b

Works with mssql and postgres.

Thanks!

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13513.

@alikon
Copy link
Copy Markdown
Contributor

alikon commented Jan 9, 2017

I have tested this item ✅ successfully on 6f9254b

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13513.

@zero-24 zero-24 added this to the Joomla 3.7.0 milestone Jan 9, 2017
@zero-24 zero-24 added the RTC This Pull Request is Ready To Commit label Jan 9, 2017
@rdeutz rdeutz merged commit fd00290 into joomla:staging Jan 10, 2017
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 10, 2017
@andrepereiradasilva andrepereiradasilva deleted the issue-13510 branch January 10, 2017 14:16
roland-d added a commit to roland-d/joomla-cms that referenced this pull request Jan 13, 2017
@roland-d
Merge branch 'staging' of github.com:roland-d/joomla-cms into trackas…
aa225cb 
…sets-option

* 'staging' of github.com:roland-d/joomla-cms: (136 commits)
  Clean up old code in cache.php file (joomla#12183)
  Fixing search for MySQL (joomla#13571)
  Unnecessary double quotes in  /libraries/joomla (joomla#13372)
  Some improvements in tests #3: (joomla#13402)
  It's 2017. Happy New Year
  Fixing a typo in gallery plugin language files
  Add stripslashes to mssql result columns. (joomla#13534)
  remove unneeded space from btn-group/radio/checkboxes (joomla#12003)
  typo (joomla#13563)
  Remove default value from the field params to inherit from plugin
  Remove multiple parameter from user field
  Fix name of component helper in fieldshelper (joomla#13539)
  remove duplicated code (joomla#13550)
  Fix invalid string that causes the ini file not to load (joomla#13544)
  Catch "expects parameter 2 to be string" error
  Take complete context for group lookup (joomla#13538)
  [Mssql] Fix syntax error when installing a language in backend (joomla#13512)
  Normalize #__categories table across 3 db systems and add default values (joomla#13514)
  Normalize #__ucm_content table across 3 db systems and add default values (joomla#13513)
  Update config.xml (joomla#13503)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Joomla 3.7.0

Development

Successfully merging this pull request may close these issues.

6 participants

@andrepereiradasilva @waader @alikon @rdeutz @zero-24 @joomla-cms-bot