Skip to content

Update en-GB.plg_system_stats.ini#5

Closed
MATsxm wants to merge 1 commit intordeutz:implement_first_run_delayfrom
MATsxm:patch-4
Closed

Update en-GB.plg_system_stats.ini#5
MATsxm wants to merge 1 commit intordeutz:implement_first_run_delayfrom
MATsxm:patch-4

Conversation

@MATsxm
Copy link
Copy Markdown

@MATsxm MATsxm commented Nov 10, 2015

Sorry guys I'll be forever here with the Bang until we register J! an other way ;)
Thanks Roberto!

Sorry guys I'll be forever here with the Bang until we register J! an other way ;)
Thanks Roberto!
@MATsxm MATsxm closed this Nov 15, 2015
rdeutz pushed a commit that referenced this pull request Apr 11, 2016
rdeutz pushed a commit that referenced this pull request Apr 11, 2016
rdeutz pushed a commit that referenced this pull request Jan 9, 2017
- Improved readability of assertions by using more appropriate assertions
- Made some assertions more strict
rdeutz pushed a commit that referenced this pull request May 25, 2017
move jquery to vendor folder
rdeutz pushed a commit that referenced this pull request Jun 17, 2017
… (joomla#12294)

* Cleanups, fixes and a bit of optimizations for site/components batch #5

- com_tags
- com_users
- com_wrapper

Note: This is a single commit bundling all types of changes, since PR joomla#12261 which had detailed commits, was rejected as a whole

* Some more fixes after conflict resolution

* - Changed some things according to reviewer's suggestions
- Some more changes in updated stuff
rdeutz pushed a commit that referenced this pull request May 15, 2019
rdeutz pushed a commit that referenced this pull request Feb 23, 2020
rdeutz pushed a commit that referenced this pull request Jun 27, 2020
* This is a combination of 8 commits.
This is the 1st commit message:

> First WIP version of supporting nested subforms.

This is the commit message #2:

> Fix nested subforms not getting correct name attribute on input fields.

This is the commit message #3:

> Fix subform rows having invalid index, fix small typo.

This is the commit message #4:

> Replace the unique subform id via random bytes by just an increasing integer in the fields type rendering process.

This is the commit message #5:

> Implement feedback from PR at Joomla;
> - Use a <template> HTML element for the template of the subform rows,
>   not a url encoded string inside of a <script> element.
> - Fix code style errors reported by phpcs.
> - Make the fixing of the unique attributes (name, id, etc) of input elements
>   of nested subform rows more errorprone, using the same method as the main
>   subform row.
> - Manually add a minified version of the javascript file.

This is the commit message #6:

> Fix failing javascript tests due to changed structure of subform repeatable template container.

This is the commit message #7:

> Change subform repeatable javascript test to correctly check on
> 0-indexed rows, previously they have been 1-indexed.

This is the commit message #8:

> Fix a problem where multi-level subforms on the same level doesnt trigger their template correctly.
> Additionally added a note why the fixScripts() method is broken and how it could get better.

* Commit code styling errors and add an aria label for the outermost 'add' button.

* Fix double group-add button on repeatable subform type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant