Some improvements in tests #5:#13410
Merged
zero-24 merged 1 commit intojoomla:stagingfrom Jan 3, 2017
frankmayer:improvements-in-tests-5
Merged
Some improvements in tests #5:#13410zero-24 merged 1 commit intojoomla:stagingfrom frankmayer:improvements-in-tests-5
zero-24 merged 1 commit intojoomla:stagingfrom
frankmayer:improvements-in-tests-5
Conversation
- Improved readability of assertions by using more appropriate assertions - Made some assertions more strict
andrepereiradasilva
approved these changes
Dec 29, 2016
Contributor
|
Merging as this can't be tested and don't change any prod code. Also Travis is happy as well a quick review. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Testing Instructions
Code review only.
Documentation Changes Required
None