Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @eileencodes (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
|
I like this! There are some improvements to the implementation we can make, but I'd be happy to merge this first, and then make those improvements. Thanks again 👌 |
|
Merged so we can make more progress and since DHH said he is happy to merge first. |
|
@palkan thanks for all your help with this! I'm sorry it took so long ❤️ |
|
Thank you @palkan |
|
Thanks for this @palkan!! |
|
Until we all update to v6, there is this gem available. |
|
Start |
This PR is a remake of the older PRs (#23211 and #27191).
After discussing it again we decided to get it done for Rails 6.
This PR is the first one in the series (and the base). The idea is to merge
action-cable-testinggem into Rails, step by step:/cc @dhh @matthewd @kaspth