Merged
Conversation
Remove extra `:nodoc:` comment since private methods doesn't require that.
…cable tests See `git grep "= Logger.new(nil)"`
Test `assert_no_broadcasts` failure
|
r? @sgrif (@rails-bot has picked a reviewer for you, use r? to override) |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0e42d3d
Clarify api docs of ActionCable::SubscriptionAdapter::Test
Remove extra
:nodoc:comment since private methods don't require that.1055d14
Set the test adapter for the test environment by default in
config/cable.ymld2ccf0c
Simplify configuring of
ActionCable.server.config.loggerfor actioncable testsSee
git grep "= Logger.new(nil)"86e7de7
DRY in
assert_broadcastsTest
assert_no_broadcastsfailureRelated to #33659
/cc @palkan