Add ActionCable::Connection::TestCase#34845
Conversation
sponomarev
left a comment
There was a problem hiding this comment.
I wish that could be included to 5.2 branch.
There was a problem hiding this comment.
I guess it makes sense to mention the support of signed/encrypted/plain cookies API, headers, env, and session in the documentation.
There was a problem hiding this comment.
env and session options are missed here. cookies are no more an option
There was a problem hiding this comment.
Am I right that this example is not relevant due to the new cookies API?
641d1c8 to
2111bc2
Compare
2111bc2 to
9029667
Compare
|
👍 Great to see |
|
@rafaelfranca @kaspth Hey folks! Is there any chance for get this reviewed (and, hopefully, merged for Beta 1) and thus finish the |
|
I just saw the other comment and I have added this PR to my list! If all goes well, I'll get to this before beta1 🙏 |
|
There we go, thanks @palkan! |
Summary
Follow-up for #33659.
That's the final part of
action-cable-testingmerging.Connection tests are written as follows:
connectmethod to simulate connection establishment (=connectcallback invocation).For example:
You can also specify cookies, headers, Rack–all the options available for integration tests–plus session
Other Information
This PR doesn't contain a changelog entry intentionally (as the previous two): I'll add a change log in another PR, in which I'd like to update a testing guide as well.