Skip to content

Add Action Cable testing guides and generators #34933

Merged
kaspth merged 3 commits intorails:masterfrom
palkan:feature/cable-testing-guides
Jan 14, 2019
Merged

Add Action Cable testing guides and generators #34933
kaspth merged 3 commits intorails:masterfrom
palkan:feature/cable-testing-guides

Conversation

@palkan
Copy link
Contributor

@palkan palkan commented Jan 14, 2019

Summary

This is the last PR in the cable testing series (at least for now 😉):

  • Added channel_test generator
  • Added connection_test to app generator (unless --skip-action-cable)
  • Added "Action Cable Testing" guides to "Testing" guides
  • Added "Action Cable Testing" as a highlight to 6.0 release notes
  • (finally) Added changelog entry.

/cc @kaspth

@palkan palkan force-pushed the feature/cable-testing-guides branch from 93a6322 to a4099de Compare January 14, 2019 16:17
@kaspth kaspth merged commit 2585e66 into rails:master Jan 14, 2019
@kaspth
Copy link
Contributor

kaspth commented Jan 14, 2019

There we go, @palkan! ❤

@palkan palkan deleted the feature/cable-testing-guides branch January 14, 2019 19:52
bogdanvlviv added a commit to bogdanvlviv/rails that referenced this pull request Jan 21, 2019
Rails generates `test/channels`(rails#34933) and
even allows `rails test:channels` (rails#34947).
`rails stats` has been providing info about `app/channels`,
it makes sense to add `test/channels` as well.

(I've changed test because we generate `test/channels` with some code)
@palkan palkan mentioned this pull request Apr 6, 2019
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants