Add rails test:channels and fix Action Cable templates#34947
Merged
kaspth merged 2 commits intorails:masterfrom Jan 16, 2019
Merged
Add rails test:channels and fix Action Cable templates#34947kaspth merged 2 commits intorails:masterfrom
rails test:channels and fix Action Cable templates#34947kaspth merged 2 commits intorails:masterfrom
Conversation
Related to 837f602 Fix the testing guide.
rails test:channels, and fix Action Cable templatesrails test:channels and fix Action Cable templates
jeremy
approved these changes
Jan 16, 2019
Add this rake task to test channels only. We've added `rails test:mailboxes` recently in the same way rails#34828.
53b5bca to
d7097cf
Compare
bogdanvlviv
added a commit
to bogdanvlviv/rails
that referenced
this pull request
Jan 21, 2019
Rails generates `test/channels`(rails#34933) and even allows `rails test:channels` (rails#34947). `rails stats` has been providing info about `app/channels`, it makes sense to add `test/channels` as well. (I've changed test because we generate `test/channels` with some code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
frozen_string_literalfrom Action Cable's template filesRelated to 837f602.
Follow up Add Action Cable testing guides and generators #34933
Fix the testing guide.
Add
rails test:channels.Add this rake task to test channels only.
We've added
rails test:mailboxesrecently in the same way Add Rake task for testing mailboxes #34828.