fix: integration tests #746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## daan/fix-pop_up_contract_signer #746 +/- ##
================================================================
Coverage 76.27% 76.27%
================================================================
Files 115 115
Lines 26016 26016
Branches 26016 26016
================================================================
Hits 19845 19845
Misses 4029 4029
Partials 2142 2142 🚀 New features to boost your workflow:
|
moliholy
approved these changes
Nov 14, 2025
Collaborator
moliholy
left a comment
There was a problem hiding this comment.
Awesome work! Drained a lot of time yesterday. Thanks! 🙏
moliholy
added a commit
that referenced
this pull request
Nov 14, 2025
* fix(pop up contract): signer prompted if not provided * fix: contracts integration tests * refactor: pop up ink node automatic deployment (#729) * fix: consistent interaction with contract after deployment (#733) * refactor: pop up ink node automatic deployment * fix: consistent interaction with contract after deployment for suri or wallet * refactor: make should_auto_start_local_node attached to the command * feat: do not ask for suri if --skip-confirm * fix: contract tests * feat: never prompt with --skip-confirm * test: contract flow * fix: contract integration tests * feat: allow using --skip-confirm and --use-wallet * fix: increase timeout for integration test * refactor: make pop function asynchronous * fix: integration tests (#746) --------- Co-authored-by: José Molina <jose@r0gue.io> Co-authored-by: Alex Bean <alexfraga10@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the chain integration tests https://github.com/r0gue-io/pop-cli/actions/runs/19339521183/job/55328402960?pr=725 adding the awaits
And the contract integration tests that were getting stuck in the CI waiting for user confirmation