fix: consistent interaction with contract after deployment #733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the contract deployment flow to ensure consistent interaction prompts after deployment, addressing issue #732. The changes restructure the deployment logic to unify the cleanup and interaction prompt handling across both wallet and non-wallet flows.
- Introduced a tracking variable to capture deployed contract addresses across both deployment flows
- Restructured the non-wallet deployment logic into a unified else block
- Added a consolidated interaction prompt at the end that respects the
skip_confirmflag
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+339
to
+345
| Ok(_) => {}, | ||
| Err(_) => { | ||
| terminate_nodes(&mut Cli, processes).await?; | ||
| Cli.outro_cancel(FAILED)?; | ||
| return Ok(()); | ||
| }, | ||
| } |
There was a problem hiding this comment.
In the upload-only success path (line 339), the function returns early at line 343 without properly cleaning up. This bypasses the node termination at line 417 and doesn't display any outro message to the user. Consider restructuring to fall through to the unified cleanup section at the end of the function, or explicitly handle cleanup and user messaging before returning.
Suggested change
| Ok(_) => {}, | |
| Err(_) => { | |
| terminate_nodes(&mut Cli, processes).await?; | |
| Cli.outro_cancel(FAILED)?; | |
| return Ok(()); | |
| }, | |
| } | |
| Ok(_) => { | |
| terminate_nodes(&mut Cli, processes).await?; | |
| Cli.outro("Contract uploaded successfully!")?; | |
| return Ok(()); | |
| }, | |
| Err(_) => { | |
| terminate_nodes(&mut Cli, processes).await?; | |
| Cli.outro_cancel(FAILED)?; | |
| return Ok(()); | |
| }, |
Base automatically changed from
daan/refactor-pop_up_ink_node_automatic_deployment
to
daan/fix-pop_up_contract_signer
November 12, 2025 12:00
moliholy
approved these changes
Nov 12, 2025
823e846
into
daan/fix-pop_up_contract_signer
22 of 23 checks passed
moliholy
added a commit
that referenced
this pull request
Nov 14, 2025
* fix(pop up contract): signer prompted if not provided * fix: contracts integration tests * refactor: pop up ink node automatic deployment (#729) * fix: consistent interaction with contract after deployment (#733) * refactor: pop up ink node automatic deployment * fix: consistent interaction with contract after deployment for suri or wallet * refactor: make should_auto_start_local_node attached to the command * feat: do not ask for suri if --skip-confirm * fix: contract tests * feat: never prompt with --skip-confirm * test: contract flow * fix: contract integration tests * feat: allow using --skip-confirm and --use-wallet * fix: increase timeout for integration test * refactor: make pop function asynchronous * fix: integration tests (#746) --------- Co-authored-by: José Molina <jose@r0gue.io> Co-authored-by: Alex Bean <alexfraga10@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.