refactor: pop up ink node automatic deployment #729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the automatic deployment behavior for the ink! node when deploying smart contracts. The main change introduces automatic node startup when the --skip-confirm flag is used with the default local endpoint.
- Adds automatic local node startup when
skip_confirmis true and no custom URL is provided - Fixes a syntax error in the metadata formatting code (missing semicolon)
- Adds comprehensive test coverage for the new auto-start behavior
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/pop-cli/src/commands/up/contract.rs | Implements automatic local node deployment logic with helper function, updates documentation, and adds test coverage |
| crates/pop-chains/src/call/metadata/mod.rs | Fixes missing semicolon after return match statement |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
a9932dc
into
daan/fix-pop_up_contract_signer
20 of 22 checks passed
moliholy
added a commit
that referenced
this pull request
Nov 14, 2025
* fix(pop up contract): signer prompted if not provided * fix: contracts integration tests * refactor: pop up ink node automatic deployment (#729) * fix: consistent interaction with contract after deployment (#733) * refactor: pop up ink node automatic deployment * fix: consistent interaction with contract after deployment for suri or wallet * refactor: make should_auto_start_local_node attached to the command * feat: do not ask for suri if --skip-confirm * fix: contract tests * feat: never prompt with --skip-confirm * test: contract flow * fix: contract integration tests * feat: allow using --skip-confirm and --use-wallet * fix: increase timeout for integration test * refactor: make pop function asynchronous * fix: integration tests (#746) --------- Co-authored-by: José Molina <jose@r0gue.io> Co-authored-by: Alex Bean <alexfraga10@gmail.com>
al3mart
pushed a commit
that referenced
this pull request
Nov 14, 2025
al3mart
pushed a commit
that referenced
this pull request
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.