fix(pop up contract): signer prompted if not provided #725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #725 +/- ##
=======================================
Coverage 77.05% 77.06%
=======================================
Files 111 111
Lines 25422 25471 +49
Branches 25422 25471 +49
=======================================
+ Hits 19589 19629 +40
- Misses 3772 3773 +1
- Partials 2061 2069 +8
🚀 New features to boost your workflow:
|
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #725 +/- ##
==========================================
- Coverage 76.28% 76.27% -0.01%
==========================================
Files 115 115
Lines 25909 26016 +107
Branches 25909 26016 +107
==========================================
+ Hits 19765 19845 +80
- Misses 4015 4029 +14
- Partials 2129 2142 +13
🚀 New features to boost your workflow:
|
moliholy
requested changes
Nov 12, 2025
* refactor: pop up ink node automatic deployment * fix: consistent interaction with contract after deployment for suri or wallet
e0a35b6 to
d1df96c
Compare
moliholy
approved these changes
Nov 12, 2025
Collaborator
Author
|
Can we also check whether with the --skip-confirm flag the user is not prompted for confirmation on executing the message @moliholy |
Collaborator
That's the case. No confirmation is requested when deploying or executing if |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deploying a contract the signer was no prompted if not provided and alice was always used. This fixes that.
Closes #721
Closes #732