Skip to content

Tensor bitwise with broadcasting#550

Closed
mukeshj0606 wants to merge 117 commits intor-abishek:masterfrom
mukeshj0606:tensor_bitwise_with_broadcasting
Closed

Tensor bitwise with broadcasting#550
mukeshj0606 wants to merge 117 commits intor-abishek:masterfrom
mukeshj0606:tensor_bitwise_with_broadcasting

Conversation

@mukeshj0606
Copy link
Copy Markdown

Fix the Bitwise operations using Struct Templates.

r-abishek and others added 30 commits June 20, 2025 11:49
* Changes for audio augmentations build

* Add additional comment

* Updates to remove reduandant quotes

---------

Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com>
…ocs/sphinx (r-abishek#572)

Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.20.1 to 1.21.0.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](ROCm/rocm-docs-core@v1.20.1...v1.21.0)

---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
  dependency-version: 1.21.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ocs/sphinx (r-abishek#574)

Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.21.0 to 1.21.1.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](ROCm/rocm-docs-core@v1.21.0...v1.21.1)

---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
  dependency-version: 1.21.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>
migrating to rocJenkins

Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>
* Add F16 Load/Store Updates for 5 kernels

* Add copilot suggestions for cleaner load

* Address review comments

* Update parameters data types

---------

Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com>
Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>
…k#573)

* Adds Hue and saturation Tensor Implementattion

* Address copilot review comments

* Resolve review comments

* Align inline comments

* Fix typo

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Remove unnecessary variable reassignments

---------

Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>
* Fix function grouping and error returns

* Adress review comments

---------

Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com>
Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>
* Updates for 4 kernels

* Update the brightness pixel check

---------

Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com>
Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>
* RPP - cleanup and updates

* Update CHANGELOG.md

Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com>

* Update docs/install/rpp-prerequisites.rst

Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com>

* Update docs/install/rpp-prerequisites.rst

Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com>

* Readme - Use suggested template

---------

Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com>
Srihari-mcw and others added 27 commits September 7, 2025 09:42
* Updates for box filter to test

* Box Filter Newer Commit with fixes

* Further updates to match PKD3 and PLN3 output

* Fixes for RPP Box filter border replicate - Fix accuracy

* Rename variables

* Restore AVX and Update AVX code for box filter

* Box Filter float updates

* Updates to float version

* Compilation fixes

* HIP Updates for Box Filter kernelSize = 3

* HIP Updates for PLN Code

* HIP Updates for kernelSize = 5

* HIP Updates for kernelSize = 7

* HIP Updates for kernelSize = 9

* Remove additional else

* Fix issues with alignedLength for kernelSize 3 float variants PKD3 to PLN3

* Add golden outputs

* Add additional borderType parameter

* Separate float implementation for 3x3 box filter planar

* Rename function

* Introduce functions to calculate in float type itself

* Updates for PKD variants

* Compilation fixes

* Updates for PKD3 to PLN3

* Fix accuracy issues

* PLN3 to PKD3 updates for box filter

* Float shared variables

* Overload box filter for various kernelSizes

* Template the PKD3 and PLN3 implementations

* Template the rest of the implementations

* Initial cleanup of HIP Code

* Cleanup of code with parameter passing launch of kernel

* Add further comments

* Add more comments and minor cleanups further

* Initial cleanup of cpu kernel code

* Add comments for padding

* Add reference outputs in docs/data/doxygenOutputs

* Update documentation

* Minor corrections

* Updates to move filter structure as common code

* Update the separation based on type

* Update rpp_hip_load_store.hpp

* Updates for separating i8 for PLN3 code

* Fixes for PLN3 and further updates for kernelSize = 3

* I8 updates for kernelSize = 5

* Updates for kernelSize = 7

* Updates for kernelSize = 9

* Fixes for kernelSize = 9

* Remove saturate pixel

* Rename function

* Update comment

* Add declarations for I8 functions with rounding

* Whitespace and type updates

* Updates for performance - U8/I8

* Templated the box filter compute functions for all kernel sizes and optimized the I8 variants

* Update comments

* Make initial changes to template unpack function

* Fixes for box filter compilation

* modified padding load logic

* Update the round function used

* Rename verticalDirection and horizontalDirection to padVertical and padHorizontal

* Fix accuracy issues

---------

Co-authored-by: Abishek <52214183+r-abishek@users.noreply.github.com>
Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com>
Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>
Co-authored-by: Lakshmi Kumar <lakshmi.kumar@amd.com>
Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>
Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>
* Fix handle mem leaks

* Add variable to capture rpp::try_ return status

* Add handle deletes inside lambda function

* modified handle delete

---------

Co-authored-by: Maddisetty <hmaddise@ctr2-alola-login-01.amd.com>
Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>
Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com>
Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>
* Solarize HIP and HOST implementation

* cleanup the code and fix pkd3-pkd3 performance

* Add golden output and doxygen comments

* Add cheks for Threshold param

* modified case num for solarize

* minor fix

* fix load/store calls

* Address review comments

* minor fix

---------

Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com>
Co-authored-by: Maddisetty <hmaddise@ctr2-alola-login-01.amd.com>
Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>
…ocs/sphinx (ROCm#620)

Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.23.0 to 1.24.1.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.24.1/CHANGELOG.md)
- [Commits](ROCm/rocm-docs-core@v1.23.0...v1.24.1)

---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
  dependency-version: 1.24.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ocs/sphinx (ROCm#622)

Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.24.1 to 1.25.0.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.25.0/CHANGELOG.md)
- [Commits](ROCm/rocm-docs-core@v1.24.1...v1.25.0)

---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
  dependency-version: 1.25.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Initial hip memory fixes

* Further hip warning fixes

* Default build warning fixes - group III

---------

Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com>
Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>
…ocs/sphinx (ROCm#623)

Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.25.0 to 1.26.0.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.26.0/CHANGELOG.md)
- [Commits](ROCm/rocm-docs-core@v1.25.0...v1.26.0)

---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
  dependency-version: 1.26.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
ManasaDattaT pushed a commit to ManasaDattaT/rpp that referenced this pull request Dec 19, 2025
* Make changes for F16 variant of brightness.hpp

* Make changes for F16 variant of color_to_greyscale.hpp

* Further changes for F16 variant of color_to_greyscale.hpp

* Further changes for F16 variant of crop_mirror_normalize.hpp

* Changes for F16 variant of log

* Add changes for F16 variant for magnitude

* Make updates to fix compilation issues

* Make updates for SSE version of brightness and color_to_greyscale

* Add updates for color_temperature

* Further updates for crop mirror normalize

* Fix issues with crop mirror normalize

* Update code for color twist

* Updates to contrast.hpp

* Updates to exposure.hpp

* Add updates for non_linear_blend and color_twist

* Fix compiler issues with rpp_load8_f16_to_f32_mirror_avx

* Fix compiler issues with non linear blend

* Fix issues with SSE version of color_to_greyscale

* Fix issues with SSE version of brightness for PLN3 to PKD3

* Update F16 Load/Store for vignette

* Updates to phase for F16 Load

* F16 Updates for noise_gaussian

* F16 Updates for noise_salt_and_pepper.hpp

* Update code for noise_shot

* Remove vector buffer size updates

* Add F16 Load/Store updates for spatter

* Fix compilation issues

* Restore vector buffer size changes

* Add updates for tensor operations

* Remove additional file

* Restore changes in other kernels

* Fixes for SSE version of color_twist and color_to_greyscale

* Restore additional whitespace

* Update utilities/test_suite/HIP/runImageTests.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com>
Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>
Co-authored-by: Lakshmi Kumar <lakshmi.kumar@amd.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
RooseweltMcW pushed a commit to HazarathKumarM/rpp that referenced this pull request Jan 21, 2026
* Make changes for F16 variant of brightness.hpp

* Make changes for F16 variant of color_to_greyscale.hpp

* Further changes for F16 variant of color_to_greyscale.hpp

* Further changes for F16 variant of crop_mirror_normalize.hpp

* Changes for F16 variant of log

* Add changes for F16 variant for magnitude

* Make updates to fix compilation issues

* Make updates for SSE version of brightness and color_to_greyscale

* Add updates for color_temperature

* Further updates for crop mirror normalize

* Fix issues with crop mirror normalize

* Update code for color twist

* Updates to contrast.hpp

* Updates to exposure.hpp

* Add updates for non_linear_blend and color_twist

* Fix compiler issues with rpp_load8_f16_to_f32_mirror_avx

* Fix compiler issues with non linear blend

* Fix issues with SSE version of color_to_greyscale

* Fix issues with SSE version of brightness for PLN3 to PKD3

* Update F16 Load/Store for vignette

* Updates to phase for F16 Load

* F16 Updates for noise_gaussian

* F16 Updates for noise_salt_and_pepper.hpp

* Update code for noise_shot

* Remove vector buffer size updates

* Add F16 Load/Store updates for spatter

* Fix compilation issues

* Restore vector buffer size changes

* Add updates for tensor operations

* Remove additional file

* Restore changes in other kernels

* Fixes for SSE version of color_twist and color_to_greyscale

* Restore additional whitespace

* Update utilities/test_suite/HIP/runImageTests.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com>
Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>
Co-authored-by: Lakshmi Kumar <lakshmi.kumar@amd.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.