Merged
Conversation
Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com>
Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com>
Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com>
spolifroni-amd
requested changes
Jul 25, 2025
Contributor
spolifroni-amd
left a comment
There was a problem hiding this comment.
The language needs to be changed in the prerequisites and the changelog needs a small chage.
spolifroni-amd
requested changes
Jul 25, 2025
Contributor
spolifroni-amd
left a comment
There was a problem hiding this comment.
I missed an "or above"
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the RPP project documentation and version for the next release, focusing on clarifying dependencies and preparing for version 2.1.0.
- Updated version from 2.0.0 to 2.1.0 in CMakeLists.txt
- Added explicit HIP and OpenMP dependencies to documentation with installation commands
- Improved consistency in dependency version language ("or later" instead of "and above")
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docs/install/rpp-prerequisites.rst | Added HIP and OpenMP to the list of required dependencies |
| README.md | Added HIP and OpenMP installation sections and standardized version language |
| CMakeLists.txt | Updated project version from 2.0.0 to 2.1.0 |
| CHANGELOG.md | Added placeholder section for unreleased RPP 2.1.0 |
Comments suppressed due to low confidence (1)
README.md:84
- The package name 'openmp-extras-dev' appears to be incorrect. The standard OpenMP development package on Ubuntu is typically 'libomp-dev' or 'libgomp1' for GNU OpenMP. Please verify this package name exists in the target repositories.
sudo apt install openmp-extras-dev
spolifroni-amd
approved these changes
Jul 25, 2025
ManasaDattaT
pushed a commit
to ManasaDattaT/rpp
that referenced
this pull request
Dec 19, 2025
* RPP - cleanup and updates * Update CHANGELOG.md Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com> * Update docs/install/rpp-prerequisites.rst Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com> * Update docs/install/rpp-prerequisites.rst Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com> * Readme - Use suggested template --------- Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Readme - add dependencies
Version update for next release