Solarize augmentation on HOST and HIP by r-abishek · Pull Request #605 · ROCm/rpp

r-abishek · 2025-08-28T06:11:08Z

Add Solarize for both HOST and HIP Backends.
Add support for NCHW/NHWC, toggle variants and U8/F16/F32/I8 bit depths.
Add relevant QA/unit/perf tests.

Solarize HIP and HOST implementation

rrawther · 2025-09-12T00:31:32Z

utilities/test_suite/HIP/Tensor_image_hip.cpp

+                        thresholdTensor[i] = 0.5;
+
+                    startWallTime = omp_get_wtime();
+                    if (inputBitDepth == 0 || inputBitDepth == 1 || inputBitDepth == 2 || inputBitDepth == 5)


We need to use enum for inputBitDepth as well, which can be issued as a separate PR

rrawther

Added a comment for future PR

kiritigowda · 2025-09-18T03:12:10Z

@r-abishek failing compile on CI

kiritigowda · 2025-09-18T03:12:49Z

@r-abishek

FAILED: [code=1] src/modules/CMakeFiles/modules.dir/tensor/cpu/kernel/solarize.cpp.o 
/home/vsts/work/1/rocm/llvm/bin/amdclang++ -DAUDIO_SUPPORT -DGPU_SUPPORT -DHIP_COMPILE -DRPP_BACKEND_HIP=1 -DSTATIC -DUSE_PROF_API=1 -D__AVX2__ -D__HIP_PLATFORM_AMD__=1 -I/home/vsts/work/1/s/build -I/home/vsts/work/1/s/api -I/home/vsts/work/1/s/third_party/ffts/include -I/home/vsts/work/1/s/src/include/legacy_dep -I/home/vsts/work/1/s/src/include/common -I/home/vsts/work/1/s/src/include/common/cpu -I/home/vsts/work/1/s/src/include/tensor -I/home/vsts/work/1/s/src/include/common/hip -isystem /home/vsts/work/1/rocm/include -O3 -Ofast -DNDEBUG -fopenmp=libomp -fPIC -mavx2 -mf16c -mfma  -O3 -DNDEBUG -fPIC -Wno-unused-result -x hip --offload-arch=gfx942 -std=gnu++17 -MD -MT src/modules/CMakeFiles/modules.dir/tensor/cpu/kernel/solarize.cpp.o -MF src/modules/CMakeFiles/modules.dir/tensor/cpu/kernel/solarize.cpp.o.d -o src/modules/CMakeFiles/modules.dir/tensor/cpu/kernel/solarize.cpp.o -c /home/vsts/work/1/s/src/modules/tensor/cpu/kernel/solarize.cpp
/home/vsts/work/1/s/src/modules/tensor/cpu/kernel/solarize.cpp:637:56: error: use of undeclared identifier 'offset'
  637 |                     *dstPtrTempR++ = ((*(srcPtrTemp) + offset) >= thresholdParam) ? (maxVal - *(srcPtrTemp)) : *(srcPtrTemp);
      |                                                        ^~~~~~
/home/vsts/work/1/s/src/modules/tensor/cpu/kernel/solarize.cpp:638:60: error: use of undeclared identifier 'offset'
  638 |                     *dstPtrTempG++ = ((*(srcPtrTemp + 1) + offset) >= thresholdParam) ? (maxVal - *(srcPtrTemp + 1)) : *(srcPtrTemp + 1);
      |                                                            ^~~~~~
/home/vsts/work/1/s/src/modules/tensor/cpu/kernel/solarize.cpp:639:60: error: use of undeclared identifier 'offset'
  639 |                     *dstPtrTempB++ = ((*(srcPtrTemp + 2) + offset) >= thresholdParam) ? (maxVal - *(srcPtrTemp + 2)) : *(srcPtrTemp + 2);
      |                                                            ^~~~~~
/home/vsts/work/1/s/src/modules/tensor/cpu/kernel/solarize.cpp:681:54: error: use of undeclared identifier 'offset'
  681 |                     *dstPtrTemp++ = ((*srcPtrTempR + offset) >= thresholdParam) ? (maxVal - (*srcPtrTempR)) : *srcPtrTempR;
      |                                                      ^~~~~~
/home/vsts/work/1/s/src/modules/tensor/cpu/kernel/solarize.cpp:682:54: error: use of undeclared identifier 'offset'
  682 |                     *dstPtrTemp++ = ((*srcPtrTempG + offset) >= thresholdParam) ? (maxVal - (*srcPtrTempG)) : *srcPtrTempG;
      |                                                      ^~~~~~
/home/vsts/work/1/s/src/modules/tensor/cpu/kernel/solarize.cpp:683:54: error: use of undeclared identifier 'offset'
  683 |                     *dstPtrTemp++ = ((*srcPtrTempB + offset) >= thresholdParam) ? (maxVal - (*srcPtrTempB)) : *srcPtrTempB;
      |                                                      ^~~~~~
/home/vsts/work/1/s/src/modules/tensor/cpu/kernel/solarize.cpp:726:57: error: use of undeclared identifier 'offset'
  726 |                         *dstPtrTemp++ = ((*srcPtrTemp + offset) >= thresholdParam) ? (maxVal - (*srcPtrTemp)) : *srcPtrTemp;
      |                                                         ^~~~~~
7 errors generated when compiling for gfx942.
[153/175] Building CXX object src/modules/CMakeFiles/modules.dir/tensor/cpu/kernel/spectrogram.cpp.o
[154/175] Building CXX object src/modules/CMakeFiles/modules.dir/tensor/cpu/kernel/spatter.cpp.o
ninja: build stopped: subcommand failed.

##[error]The process '/usr/bin/cmake' failed with exit code 1
##[error]CMake failed with error: The process '/usr/bin/cmake' failed with exit code 1
Finishing:  CMake Build

RPP SOLARIZE : Fix CI build

codecov · 2025-09-23T06:33:25Z

Codecov Report

❌ Patch coverage is 99.62825% with 3 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...dules/tensor/rppt_tensor_effects_augmentations.cpp	98.18%	2 Missing ⚠️
src/modules/tensor/hip/kernel/solarize.cpp	98.81%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #605      +/-   ##
===========================================
+ Coverage    88.30%   88.38%   +0.08%     
===========================================
  Files          194      196       +2     
  Lines        81962    82769     +807     
===========================================
+ Hits         72373    73155     +782     
- Misses        9589     9614      +25

Files with missing lines	Coverage Δ
src/modules/tensor/cpu/kernel/solarize.cpp	`100.00% <100.00%> (ø)`
src/modules/tensor/hip/kernel/solarize.cpp	`98.81% <98.81%> (ø)`
...dules/tensor/rppt_tensor_effects_augmentations.cpp	`95.93% <98.18%> (+0.11%)`	⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

* Solarize HIP and HOST implementation * cleanup the code and fix pkd3-pkd3 performance * Add golden output and doxygen comments * Add cheks for Threshold param * modified case num for solarize * minor fix * fix load/store calls * Address review comments * minor fix --------- Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com> Co-authored-by: Maddisetty <hmaddise@ctr2-alola-login-01.amd.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>

* Box filter - padding updates (#597) * Updates for box filter to test * Box Filter Newer Commit with fixes * Further updates to match PKD3 and PLN3 output * Fixes for RPP Box filter border replicate - Fix accuracy * Rename variables * Restore AVX and Update AVX code for box filter * Box Filter float updates * Updates to float version * Compilation fixes * HIP Updates for Box Filter kernelSize = 3 * HIP Updates for PLN Code * HIP Updates for kernelSize = 5 * HIP Updates for kernelSize = 7 * HIP Updates for kernelSize = 9 * Remove additional else * Fix issues with alignedLength for kernelSize 3 float variants PKD3 to PLN3 * Add golden outputs * Add additional borderType parameter * Separate float implementation for 3x3 box filter planar * Rename function * Introduce functions to calculate in float type itself * Updates for PKD variants * Compilation fixes * Updates for PKD3 to PLN3 * Fix accuracy issues * PLN3 to PKD3 updates for box filter * Float shared variables * Overload box filter for various kernelSizes * Template the PKD3 and PLN3 implementations * Template the rest of the implementations * Initial cleanup of HIP Code * Cleanup of code with parameter passing launch of kernel * Add further comments * Add more comments and minor cleanups further * Initial cleanup of cpu kernel code * Add comments for padding * Add reference outputs in docs/data/doxygenOutputs * Update documentation * Minor corrections * Updates to move filter structure as common code * Update the separation based on type * Update rpp_hip_load_store.hpp * Updates for separating i8 for PLN3 code * Fixes for PLN3 and further updates for kernelSize = 3 * I8 updates for kernelSize = 5 * Updates for kernelSize = 7 * Updates for kernelSize = 9 * Fixes for kernelSize = 9 * Remove saturate pixel * Rename function * Update comment * Add declarations for I8 functions with rounding * Whitespace and type updates * Updates for performance - U8/I8 * Templated the box filter compute functions for all kernel sizes and optimized the I8 variants * Update comments * Make initial changes to template unpack function * Fixes for box filter compilation * modified padding load logic * Update the round function used * Rename verticalDirection and horizontalDirection to padVertical and padHorizontal * Fix accuracy issues --------- Co-authored-by: Abishek <52214183+r-abishek@users.noreply.github.com> Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> Co-authored-by: Lakshmi Kumar <lakshmi.kumar@amd.com> * Docs - removing SP6 (#609) Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * Packaging - Remove Meta Package dependency (#610) Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * Bugfix - Handle (#600) * Fix handle mem leaks * Add variable to capture rpp::try_ return status * Add handle deletes inside lambda function * modified handle delete --------- Co-authored-by: Maddisetty <hmaddise@ctr2-alola-login-01.amd.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com> * Docs - Updated doxyfile with correct api input path (#614) Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * Test Package - Add cmake deps (#617) * Solarize augmentation - HOST and HIP (#605) * Solarize HIP and HOST implementation * cleanup the code and fix pkd3-pkd3 performance * Add golden output and doxygen comments * Add cheks for Threshold param * modified case num for solarize * minor fix * fix load/store calls * Address review comments * minor fix --------- Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com> Co-authored-by: Maddisetty <hmaddise@ctr2-alola-login-01.amd.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * Docs - Bump rocm-docs-core[api_reference] from 1.23.0 to 1.24.1 in /docs/sphinx (#620) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.23.0 to 1.24.1. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.24.1/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.23.0...v1.24.1) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.24.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Docs - Bump rocm-docs-core[api_reference] from 1.24.1 to 1.25.0 in /docs/sphinx (#622) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.24.1 to 1.25.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.25.0/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.24.1...v1.25.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.25.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Warning fixes for HIP Backend - Check return status (#606) * Initial hip memory fixes * Further hip warning fixes * Default build warning fixes - group III --------- Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * Docs - Bump rocm-docs-core[api_reference] from 1.25.0 to 1.26.0 in /docs/sphinx (#623) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.25.0 to 1.26.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.26.0/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.25.0...v1.26.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.26.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * ROCm 7.1 - Changelog updates (#625) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Srihari-mcw <96763064+Srihari-mcw@users.noreply.github.com> Co-authored-by: Abishek <52214183+r-abishek@users.noreply.github.com> Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com> Co-authored-by: Lakshmi Kumar <lakshmi.kumar@amd.com> Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com> Co-authored-by: arvindcheru <90783369+arvindcheru@users.noreply.github.com> Co-authored-by: Maddisetty <hmaddise@ctr2-alola-login-01.amd.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com>

* Solarize HIP and HOST implementation * cleanup the code and fix pkd3-pkd3 performance * Add golden output and doxygen comments * Add cheks for Threshold param * modified case num for solarize * minor fix * fix load/store calls * Address review comments * minor fix --------- Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com> Co-authored-by: Maddisetty <hmaddise@ctr2-alola-login-01.amd.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>

* Optimized version of channel dropout HIP backend and working code for HOST AVX, SSE * Modified name for dropout compute function * Modified way of AVX and SSE version channel dropout to avoid if statments * Modified Channel Dropout with generic compute code reused * Parameters and name change for channel dropout * Modified HIP for better performance * Modified the code and made the channel dropout templated version for all the bitdepths * Added output image and modified the .h file to effects for channel dropout * added space * Resolved all review comments and modified code to produce results for i8 variant * Removed empty line * Resolved review comments * Modified HOST after merge * Made changes after merging and QA passed for dropout * Channel dropout make_float 4 macro changes * Updated QA with random generator and updated BIN files * Modified QA name changes * Modified RandomSeed value passed as parameter to the function call * Update rppt_tensor_effects_augmentations.cpp indentation modified * Removed space and review comments resolved * channel dropout implementation * Resolved all the review comments and modified the magic number to set as constant for better understanding, added required comments * Merged branch from develop and resolved merge conflicts * Removed empty space * Updated omp loop for better performance * Updated hip channel dropout code for PKD version * Updated change after merge * Packaging - Remove Meta Package dependency (#610) Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * Test Package - Add cmake deps (#617) * Solarize augmentation - HOST and HIP (#605) * Solarize HIP and HOST implementation * cleanup the code and fix pkd3-pkd3 performance * Add golden output and doxygen comments * Add cheks for Threshold param * modified case num for solarize * minor fix * fix load/store calls * Address review comments * minor fix --------- Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com> Co-authored-by: Maddisetty <hmaddise@ctr2-alola-login-01.amd.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * Docs - Bump rocm-docs-core[api_reference] from 1.24.1 to 1.25.0 in /docs/sphinx (#622) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.24.1 to 1.25.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.25.0/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.24.1...v1.25.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.25.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Warning fixes for HIP Backend - Check return status (#606) * Initial hip memory fixes * Further hip warning fixes * Default build warning fixes - group III --------- Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * Docs - Bump rocm-docs-core[api_reference] from 1.25.0 to 1.26.0 in /docs/sphinx (#623) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.25.0 to 1.26.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.26.0/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.25.0...v1.26.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.26.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * ROCm 7.1 - Changelog updates (#625) * HIP - Remove unnecessary int load/stores (#621) * Initial changes for tensor sum for PLN1 and PKD3 variants U8 * Make changes for rest of the bit depths and layouts * Remove unused pack functions * Adjust comments * Initial cleanup * Further cleanup * Remove unused functions * Address copilot comments * Further standardize comments * Standardize comments spacing in functions affected --------- Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * CXX Compiler - Support TheRock (#630) * Test Suite - Enums for bit depth, output format and layout (#608) * removed numbers for bitdepths and output toggle * Add layout enum and replicate changes to HOST testsuite * Fix copilot review comments * resolve review comments * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * minor bugfix * minor bugfix * minor fix --------- Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * Docs - Bump rocm-docs-core[api_reference] from 1.26.0 to 1.27.0 in /docs/sphinx (#632) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.26.0 to 1.27.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.26.0...v1.27.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.27.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Packaging - Remove Meta Package dependency (#610) Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * Test Package - Add cmake deps (#617) * Docs - Bump rocm-docs-core[api_reference] from 1.24.1 to 1.25.0 in /docs/sphinx (#622) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.24.1 to 1.25.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.25.0/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.24.1...v1.25.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.25.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Docs - Bump rocm-docs-core[api_reference] from 1.25.0 to 1.26.0 in /docs/sphinx (#623) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.25.0 to 1.26.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.26.0/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.25.0...v1.26.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.26.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * HIP - Remove unnecessary int load/stores (#621) * Initial changes for tensor sum for PLN1 and PKD3 variants U8 * Make changes for rest of the bit depths and layouts * Remove unused pack functions * Adjust comments * Initial cleanup * Further cleanup * Remove unused functions * Address copilot comments * Further standardize comments * Standardize comments spacing in functions affected --------- Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * CXX Compiler - Support TheRock (#630) * Test Suite - Enums for bit depth, output format and layout (#608) * removed numbers for bitdepths and output toggle * Add layout enum and replicate changes to HOST testsuite * Fix copilot review comments * resolve review comments * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * minor bugfix * minor bugfix * minor fix --------- Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * Docs - Bump rocm-docs-core[api_reference] from 1.26.0 to 1.27.0 in /docs/sphinx (#632) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.26.0 to 1.27.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.26.0...v1.27.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.27.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Modified enum changed for the test suite for dropout * Updated enum changes for dropout * Update utilities/test_suite/HOST/runImageTests.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update utilities/test_suite/HIP/runImageTests.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update utilities/test_suite/HOST/runImageTests.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update utilities/test_suite/HIP/runImageTests.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update utilities/test_suite/HOST/Tensor_image_host.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/modules/tensor/rppt_tensor_effects_augmentations.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/modules/tensor/rppt_tensor_effects_augmentations.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Docs - Bump rocm-docs-core[api_reference] from 1.24.1 to 1.25.0 in /docs/sphinx (#622) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.24.1 to 1.25.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.25.0/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.24.1...v1.25.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.25.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * ROCm 7.1 - Changelog updates (#625) * Resolved copilot review comments for channel dropout * Reverted back the dropoutTypeCases * Updated and resolved reivew comments * Modified common.py file for channel dropout * Reverted changes * Updated common.py changes * updated channel dropout and resolved review comments * Updated random mask in API level * Updated seed to be passed from test suite * Updated Random generator in test suite level * updated name for every instances * Resolved review comments * Resolved Review comments and modified HIP code * Updated and resolved review comments * Modified datatype for channel dropout Hip backend --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: sampath117 <snehaa@multicorewareinc.com> Co-authored-by: RooseweltMcW <austin.roosewelt@multicorewareinc.com> Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com> Co-authored-by: arvindcheru <90783369+arvindcheru@users.noreply.github.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> Co-authored-by: Maddisetty <hmaddise@ctr2-alola-login-01.amd.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Optimized version of channel dropout HIP backend and working code for HOST AVX, SSE * Modified name for dropout compute function * Modified way of AVX and SSE version channel dropout to avoid if statments * Modified Channel Dropout with generic compute code reused * Parameters and name change for channel dropout * Modified HIP for better performance * Modified the code and made the channel dropout templated version for all the bitdepths * Added output image and modified the .h file to effects for channel dropout * added space * Resolved all review comments and modified code to produce results for i8 variant * Removed empty line * Resolved review comments * Modified HOST after merge * Made changes after merging and QA passed for dropout * Channel dropout make_float 4 macro changes * Updated QA with random generator and updated BIN files * Modified QA name changes * Modified RandomSeed value passed as parameter to the function call * Update rppt_tensor_effects_augmentations.cpp indentation modified * Removed space and review comments resolved * channel dropout implementation * Resolved all the review comments and modified the magic number to set as constant for better understanding, added required comments * Merged branch from develop and resolved merge conflicts * Removed empty space * Updated omp loop for better performance * Updated hip channel dropout code for PKD version * Updated change after merge * Packaging - Remove Meta Package dependency (ROCm#610) Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * Test Package - Add cmake deps (ROCm#617) * Solarize augmentation - HOST and HIP (ROCm#605) * Solarize HIP and HOST implementation * cleanup the code and fix pkd3-pkd3 performance * Add golden output and doxygen comments * Add cheks for Threshold param * modified case num for solarize * minor fix * fix load/store calls * Address review comments * minor fix --------- Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com> Co-authored-by: Maddisetty <hmaddise@ctr2-alola-login-01.amd.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * Docs - Bump rocm-docs-core[api_reference] from 1.24.1 to 1.25.0 in /docs/sphinx (ROCm#622) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.24.1 to 1.25.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.25.0/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.24.1...v1.25.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.25.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Warning fixes for HIP Backend - Check return status (ROCm#606) * Initial hip memory fixes * Further hip warning fixes * Default build warning fixes - group III --------- Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * Docs - Bump rocm-docs-core[api_reference] from 1.25.0 to 1.26.0 in /docs/sphinx (ROCm#623) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.25.0 to 1.26.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.26.0/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.25.0...v1.26.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.26.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * ROCm 7.1 - Changelog updates (ROCm#625) * HIP - Remove unnecessary int load/stores (ROCm#621) * Initial changes for tensor sum for PLN1 and PKD3 variants U8 * Make changes for rest of the bit depths and layouts * Remove unused pack functions * Adjust comments * Initial cleanup * Further cleanup * Remove unused functions * Address copilot comments * Further standardize comments * Standardize comments spacing in functions affected --------- Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * CXX Compiler - Support TheRock (ROCm#630) * Test Suite - Enums for bit depth, output format and layout (ROCm#608) * removed numbers for bitdepths and output toggle * Add layout enum and replicate changes to HOST testsuite * Fix copilot review comments * resolve review comments * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * minor bugfix * minor bugfix * minor fix --------- Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * Docs - Bump rocm-docs-core[api_reference] from 1.26.0 to 1.27.0 in /docs/sphinx (ROCm#632) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.26.0 to 1.27.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.26.0...v1.27.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.27.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Packaging - Remove Meta Package dependency (ROCm#610) Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * Test Package - Add cmake deps (ROCm#617) * Docs - Bump rocm-docs-core[api_reference] from 1.24.1 to 1.25.0 in /docs/sphinx (ROCm#622) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.24.1 to 1.25.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.25.0/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.24.1...v1.25.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.25.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Docs - Bump rocm-docs-core[api_reference] from 1.25.0 to 1.26.0 in /docs/sphinx (ROCm#623) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.25.0 to 1.26.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.26.0/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.25.0...v1.26.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.26.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * HIP - Remove unnecessary int load/stores (ROCm#621) * Initial changes for tensor sum for PLN1 and PKD3 variants U8 * Make changes for rest of the bit depths and layouts * Remove unused pack functions * Adjust comments * Initial cleanup * Further cleanup * Remove unused functions * Address copilot comments * Further standardize comments * Standardize comments spacing in functions affected --------- Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * CXX Compiler - Support TheRock (ROCm#630) * Test Suite - Enums for bit depth, output format and layout (ROCm#608) * removed numbers for bitdepths and output toggle * Add layout enum and replicate changes to HOST testsuite * Fix copilot review comments * resolve review comments * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * minor bugfix * minor bugfix * minor fix --------- Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * Docs - Bump rocm-docs-core[api_reference] from 1.26.0 to 1.27.0 in /docs/sphinx (ROCm#632) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.26.0 to 1.27.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.26.0...v1.27.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.27.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Modified enum changed for the test suite for dropout * Updated enum changes for dropout * Update utilities/test_suite/HOST/runImageTests.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update utilities/test_suite/HIP/runImageTests.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update utilities/test_suite/HOST/runImageTests.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update utilities/test_suite/HIP/runImageTests.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update utilities/test_suite/HOST/Tensor_image_host.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/modules/tensor/rppt_tensor_effects_augmentations.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/modules/tensor/rppt_tensor_effects_augmentations.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Docs - Bump rocm-docs-core[api_reference] from 1.24.1 to 1.25.0 in /docs/sphinx (ROCm#622) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.24.1 to 1.25.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.25.0/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.24.1...v1.25.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.25.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * ROCm 7.1 - Changelog updates (ROCm#625) * Resolved copilot review comments for channel dropout * Reverted back the dropoutTypeCases * Updated and resolved reivew comments * Modified common.py file for channel dropout * Reverted changes * Updated common.py changes * updated channel dropout and resolved review comments * Updated random mask in API level * Updated seed to be passed from test suite * Updated Random generator in test suite level * updated name for every instances * Resolved review comments * Resolved Review comments and modified HIP code * Updated and resolved review comments * Modified datatype for channel dropout Hip backend --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: sampath117 <snehaa@multicorewareinc.com> Co-authored-by: RooseweltMcW <austin.roosewelt@multicorewareinc.com> Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com> Co-authored-by: arvindcheru <90783369+arvindcheru@users.noreply.github.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> Co-authored-by: Maddisetty <hmaddise@ctr2-alola-login-01.amd.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

HazarathKumarM and others added 10 commits August 19, 2025 10:41

Solarize HIP and HOST implementation

eb33698

cleanup the code and fix pkd3-pkd3 performance

eaf72b8

Add golden output and doxygen comments

4c9037e

Add cheks for Threshold param

4723b89

modified case num for solarize

d9f65d3

minor fix

e3677cd

fix load/store calls

226f330

Address review comments

1c44d7f

Merge remote-tracking branch '/develop' into hk/solarize

04e143c

Merge pull request #454 from HazarathKumarM/hk/solarize

2564faa

Solarize HIP and HOST implementation

r-abishek added enhancement New feature or request ci:precheckin labels Aug 28, 2025

kiritigowda self-assigned this Aug 28, 2025

kiritigowda requested review from Copilot and rrawther and removed request for Copilot August 28, 2025 21:39

rrawther requested a review from AryanSalmanpour August 29, 2025 00:24

Merge branch 'develop' into ar/solarize

f2a68b0

rrawther reviewed Sep 12, 2025

View reviewed changes

rrawther approved these changes Sep 12, 2025

View reviewed changes

r-abishek and others added 5 commits September 16, 2025 12:31

Merge branch 'develop' into ar/solarize

b2f0407

Merge branch 'develop' into ar/solarize

0b7c405

Merge branch 'develop' into ar/solarize

ea6dcc2

Merge branch 'develop' into ar/solarize

cbdf5c9

Merge branch 'develop' into ar/solarize

9ee8ca0

kiritigowda marked this pull request as draft September 18, 2025 03:13

HazarathKumarM and others added 2 commits September 19, 2025 06:35

minor fix

6614d21

Merge branch 'develop' into ar/solarize

bf563df

Merge pull request #494 from HazarathKumarM/hk/solarize_pr

a997a7c

RPP SOLARIZE : Fix CI build

r-abishek marked this pull request as ready for review September 23, 2025 00:22

Merge branch 'develop' into ar/solarize

85d3e6b

kiritigowda merged commit 99c9743 into ROCm:develop Sep 23, 2025
10 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Solarize augmentation on HOST and HIP#605

Solarize augmentation on HOST and HIP#605
kiritigowda merged 20 commits intoROCm:developfrom
r-abishek:ar/solarize

r-abishek commented Aug 28, 2025

Uh oh!

rrawther Sep 12, 2025

Uh oh!

rrawther left a comment

Uh oh!

kiritigowda commented Sep 18, 2025

Uh oh!

kiritigowda commented Sep 18, 2025

Uh oh!

codecov bot commented Sep 23, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

r-abishek commented Aug 28, 2025

Uh oh!

rrawther Sep 12, 2025

Choose a reason for hiding this comment

Uh oh!

rrawther left a comment

Choose a reason for hiding this comment

Uh oh!

kiritigowda commented Sep 18, 2025

Uh oh!

kiritigowda commented Sep 18, 2025

Uh oh!

codecov bot commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Sep 23, 2025 •

edited

Loading