Dropout (Channel) on HIP and HOST by r-abishek · Pull Request #634 · ROCm/rpp

r-abishek · 2025-11-04T20:43:38Z

Adds Channel Dropout augmentation on HIP and HOST
Adds support for U8/F32/F16/I8 bit depths and NCHW/NHWC variants with toggle support
Adds relevant unit / qa / performance tests

… HOST AVX, SSE

…ents

…all the bitdepths

…opout

… i8 variant

indentation modified

… as constant for better understanding, added required comments

…d the HOST backend double free fault

codecov · 2025-11-14T02:03:03Z

Codecov Report

❌ Patch coverage is 99.68354% with 1 line in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/modules/tensor/hip/kernel/channel_dropout.cpp	98.46%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #634      +/-   ##
===========================================
+ Coverage    88.20%   88.36%   +0.16%     
===========================================
  Files          195      197       +2     
  Lines        82723    83047     +324     
===========================================
+ Hits         72964    73383     +419     
+ Misses        9759     9664      -95

Files with missing lines	Coverage Δ
api/rppdefs.h	`71.72% <ø> (ø)`
src/include/common/hip/rpp_hip_load_store.hpp	`100.00% <ø> (ø)`
src/modules/tensor/cpu/kernel/channel_dropout.cpp	`100.00% <100.00%> (ø)`
...dules/tensor/rppt_tensor_effects_augmentations.cpp	`96.18% <100.00%> (+1.51%)`	⬆️
src/modules/tensor/hip/kernel/channel_dropout.cpp	`98.46% <98.46%> (ø)`

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

AryanSalmanpour · 2025-11-25T06:05:07Z

src/modules/tensor/hip/kernel/channel_dropout.cpp

+                                          rpp::Handle &handle)
+{
+    if (roiType == RpptRoiType::LTRB)
+        hip_exec_roi_converison_ltrb_to_xywh(roiTensorPtrSrc, handle);


Please fix the typo in the function name _converison_ -> _conversion_

This issue is prevalent across files. Will issue a common fix PR for the same. Thanks

Why do we need a separate PR for fixing the typo?

@rrawther The same function call is used in many instances - all are fixed in #645 now.
Thanks @AryanSalmanpour

rrawther · 2025-12-02T16:23:17Z

src/modules/tensor/cpu/kernel/channel_dropout.cpp

+        dstPtrImage = dstPtr + batchCount * dstDescPtr->strides.nStride;
+
+        uint8_t *maskPtr = scratchBuffer + batchCount * srcDescPtr->c;
+        int seed = randomSeed ? std::random_device{}() : DROPOUT_FIXED_SEED; // Use a true random seed if requested, otherwise use the fixed seed for deterministic QA


All the randomization has to happen outside the kernel from the calling function

dropoutProbability and randomSeed have now been removed from arguments.
RPP won't be responsible for the randomization part.

rrawther · 2025-12-02T16:25:09Z

src/modules/tensor/hip/kernel/channel_dropout.cpp

+#pragma omp parallel for num_threads(numThreads)
+    for (int batchCount = 0; batchCount < dstDescPtr->n; batchCount++)
+    {
+        std::mt19937 gen(seed + batchCount);


As mentioned above this need to happen outside the kernel from the caller

rrawther

Added some comments

…annel_dropout

rrawther

waiting for the random dropout change before merge

…_dropout

Channel Dropout Resolved review comments

Srihari-mcw · 2025-12-17T09:40:45Z

@rrawther , the random dropout changes were made as discussed. Thanks

* Optimized version of channel dropout HIP backend and working code for HOST AVX, SSE * Modified name for dropout compute function * Modified way of AVX and SSE version channel dropout to avoid if statments * Modified Channel Dropout with generic compute code reused * Parameters and name change for channel dropout * Modified HIP for better performance * Modified the code and made the channel dropout templated version for all the bitdepths * Added output image and modified the .h file to effects for channel dropout * added space * Resolved all review comments and modified code to produce results for i8 variant * Removed empty line * Resolved review comments * Modified HOST after merge * Made changes after merging and QA passed for dropout * Channel dropout make_float 4 macro changes * Updated QA with random generator and updated BIN files * Modified QA name changes * Modified RandomSeed value passed as parameter to the function call * Update rppt_tensor_effects_augmentations.cpp indentation modified * Removed space and review comments resolved * channel dropout implementation * Resolved all the review comments and modified the magic number to set as constant for better understanding, added required comments * Merged branch from develop and resolved merge conflicts * Removed empty space * Updated omp loop for better performance * Updated hip channel dropout code for PKD version * Updated change after merge * Packaging - Remove Meta Package dependency (ROCm#610) Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * Test Package - Add cmake deps (ROCm#617) * Solarize augmentation - HOST and HIP (ROCm#605) * Solarize HIP and HOST implementation * cleanup the code and fix pkd3-pkd3 performance * Add golden output and doxygen comments * Add cheks for Threshold param * modified case num for solarize * minor fix * fix load/store calls * Address review comments * minor fix --------- Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com> Co-authored-by: Maddisetty <hmaddise@ctr2-alola-login-01.amd.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * Docs - Bump rocm-docs-core[api_reference] from 1.24.1 to 1.25.0 in /docs/sphinx (ROCm#622) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.24.1 to 1.25.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.25.0/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.24.1...v1.25.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.25.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Warning fixes for HIP Backend - Check return status (ROCm#606) * Initial hip memory fixes * Further hip warning fixes * Default build warning fixes - group III --------- Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * Docs - Bump rocm-docs-core[api_reference] from 1.25.0 to 1.26.0 in /docs/sphinx (ROCm#623) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.25.0 to 1.26.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.26.0/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.25.0...v1.26.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.26.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * ROCm 7.1 - Changelog updates (ROCm#625) * HIP - Remove unnecessary int load/stores (ROCm#621) * Initial changes for tensor sum for PLN1 and PKD3 variants U8 * Make changes for rest of the bit depths and layouts * Remove unused pack functions * Adjust comments * Initial cleanup * Further cleanup * Remove unused functions * Address copilot comments * Further standardize comments * Standardize comments spacing in functions affected --------- Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * CXX Compiler - Support TheRock (ROCm#630) * Test Suite - Enums for bit depth, output format and layout (ROCm#608) * removed numbers for bitdepths and output toggle * Add layout enum and replicate changes to HOST testsuite * Fix copilot review comments * resolve review comments * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * minor bugfix * minor bugfix * minor fix --------- Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * Docs - Bump rocm-docs-core[api_reference] from 1.26.0 to 1.27.0 in /docs/sphinx (ROCm#632) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.26.0 to 1.27.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.26.0...v1.27.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.27.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Packaging - Remove Meta Package dependency (ROCm#610) Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * Test Package - Add cmake deps (ROCm#617) * Docs - Bump rocm-docs-core[api_reference] from 1.24.1 to 1.25.0 in /docs/sphinx (ROCm#622) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.24.1 to 1.25.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.25.0/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.24.1...v1.25.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.25.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Docs - Bump rocm-docs-core[api_reference] from 1.25.0 to 1.26.0 in /docs/sphinx (ROCm#623) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.25.0 to 1.26.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.26.0/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.25.0...v1.26.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.26.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * HIP - Remove unnecessary int load/stores (ROCm#621) * Initial changes for tensor sum for PLN1 and PKD3 variants U8 * Make changes for rest of the bit depths and layouts * Remove unused pack functions * Adjust comments * Initial cleanup * Further cleanup * Remove unused functions * Address copilot comments * Further standardize comments * Standardize comments spacing in functions affected --------- Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * CXX Compiler - Support TheRock (ROCm#630) * Test Suite - Enums for bit depth, output format and layout (ROCm#608) * removed numbers for bitdepths and output toggle * Add layout enum and replicate changes to HOST testsuite * Fix copilot review comments * resolve review comments * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * minor bugfix * minor bugfix * minor fix --------- Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * Docs - Bump rocm-docs-core[api_reference] from 1.26.0 to 1.27.0 in /docs/sphinx (ROCm#632) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.26.0 to 1.27.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.26.0...v1.27.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.27.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Modified enum changed for the test suite for dropout * Updated enum changes for dropout * Update utilities/test_suite/HOST/runImageTests.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update utilities/test_suite/HIP/runImageTests.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update utilities/test_suite/HOST/runImageTests.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update utilities/test_suite/HIP/runImageTests.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update utilities/test_suite/HOST/Tensor_image_host.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/modules/tensor/rppt_tensor_effects_augmentations.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/modules/tensor/rppt_tensor_effects_augmentations.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Docs - Bump rocm-docs-core[api_reference] from 1.24.1 to 1.25.0 in /docs/sphinx (ROCm#622) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.24.1 to 1.25.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.25.0/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.24.1...v1.25.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.25.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * ROCm 7.1 - Changelog updates (ROCm#625) * Resolved copilot review comments for channel dropout * Reverted back the dropoutTypeCases * Updated and resolved reivew comments * Modified common.py file for channel dropout * Reverted changes * Updated common.py changes * updated channel dropout and resolved review comments * Updated random mask in API level * Updated seed to be passed from test suite * Updated Random generator in test suite level * updated name for every instances * Resolved review comments * Resolved Review comments and modified HIP code * Updated and resolved review comments * Modified datatype for channel dropout Hip backend --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: sampath117 <snehaa@multicorewareinc.com> Co-authored-by: RooseweltMcW <austin.roosewelt@multicorewareinc.com> Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com> Co-authored-by: arvindcheru <90783369+arvindcheru@users.noreply.github.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> Co-authored-by: Maddisetty <hmaddise@ctr2-alola-login-01.amd.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

snehaa8 and others added 30 commits August 22, 2025 07:39

Optimized version of channel dropout HIP backend and working code for…

e32bbdb

… HOST AVX, SSE

Modified name for dropout compute function

a1fdab1

Modified way of AVX and SSE version channel dropout to avoid if statm…

4c7e1a1

…ents

Modified Channel Dropout with generic compute code reused

5747ea0

Parameters and name change for channel dropout

133236a

Modified HIP for better performance

1fb450e

Modified the code and made the channel dropout templated version for …

63491ac

…all the bitdepths

Added output image and modified the .h file to effects for channel dr…

a374034

…opout

added space

709809d

Resolved all review comments and modified code to produce results for…

751cf48

… i8 variant

Removed empty line

d597022

Resolved review comments

4038129

Merge remote-tracking branch 'tot/develop' into apr/channel_dropout

24cada0

Modified HOST after merge

24968cf

Made changes after merging and QA passed for dropout

cbc74c8

Channel dropout make_float 4 macro changes

1baa41e

Updated QA with random generator and updated BIN files

ac97a1e

Modified QA name changes

cd5c576

Modified RandomSeed value passed as parameter to the function call

09f993c

Update rppt_tensor_effects_augmentations.cpp

da78859

indentation modified

Removed space and review comments resolved

f0e2195

channel dropout implementation

a358937

Resolved all the review comments and modified the magic number to set…

b9829b6

… as constant for better understanding, added required comments

Merge branch 'hk/channelDropout' into apr/channel_dropout and resolve…

ebacdf8

…d the HOST backend double free fault

Merged branch from develop and resolved merge conflicts

70d8b1a

Merge remote-tracking branch 'origin/develop' into hk/channelDropout

b0a66cb

Removed empty space

8c728ed

Updated omp loop for better performance

2b1450b

Merge branch 'apr/channel_dropout' into hk/channelDropout

cafebfc

Updated hip channel dropout code for PKD version

5b1b0d4

Merge branch 'develop' into ar/dropout_channel

bb19acd

Merge branch 'develop' into ar/dropout_channel

1b0b869

AryanSalmanpour reviewed Nov 25, 2025

View reviewed changes

Merge branch 'develop' into ar/dropout_channel

e007814

rrawther reviewed Dec 2, 2025

View reviewed changes

rrawther requested changes Dec 2, 2025

View reviewed changes

HazarathKumarM and others added 12 commits December 3, 2025 00:48

Merge remote-tracking branch 'tot/develop' into apr/channel_dropout

861ec7a

Merge branch 'develop' into ar/dropout_channel

0870847

updated channel dropout and resolved review comments

6d191fc

Merge remote-tracking branch 'abishek/ar/dropout_channel' into apr/ch…

527e957

…annel_dropout

Updated random mask in API level

1bacbad

Updated seed to be passed from test suite

2c8e572

Merge branch 'develop' into ar/dropout_channel

0d2aa89

Updated Random generator in test suite level

0573be4

updated name for every instances

120af19

Resolved review comments

45d301c

Merge remote-tracking branch 'origin/develop' into apr/channel_dropout

cdf05e0

Resolved Review comments and modified HIP code

7b050eb

rrawther requested changes Dec 12, 2025

View reviewed changes

HazarathKumarM and others added 5 commits December 15, 2025 11:58

Updated and resolved review comments

c7454a5

Merge branch 'ROCm:develop' into ar/dropout_channel

61cde11

Merge remote-tracking branch 'ar/ar/dropout_channel' into apr/channel…

faeaf5c

…_dropout

Modified datatype for channel dropout Hip backend

6e319e9

Merge pull request #541 from RooseweltMcW/apr/channel_dropout

8a1f90e

Channel Dropout Resolved review comments

rrawther approved these changes Jan 2, 2026

View reviewed changes

kiritigowda merged commit fd7f1b7 into ROCm:develop Jan 5, 2026
13 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dropout (Channel) on HIP and HOST#634

Dropout (Channel) on HIP and HOST#634
kiritigowda merged 95 commits intoROCm:developfrom
r-abishek:ar/dropout_channel

r-abishek commented Nov 4, 2025

Uh oh!

codecov bot commented Nov 14, 2025 •

edited

Loading

Uh oh!

AryanSalmanpour Nov 25, 2025

Uh oh!

Srihari-mcw Nov 25, 2025

Uh oh!

Srihari-mcw Nov 26, 2025

Uh oh!

rrawther Dec 2, 2025

Uh oh!

r-abishek Dec 3, 2025 •

edited

Loading

Uh oh!

rrawther Dec 2, 2025

Uh oh!

r-abishek Dec 17, 2025

Uh oh!

rrawther Dec 2, 2025

Uh oh!

rrawther left a comment

Uh oh!

rrawther left a comment

Uh oh!

Srihari-mcw commented Dec 17, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Conversation

r-abishek commented Nov 4, 2025

Uh oh!

codecov bot commented Nov 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

AryanSalmanpour Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

Srihari-mcw Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

Srihari-mcw Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

rrawther Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

r-abishek Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rrawther Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

r-abishek Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

rrawther Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

rrawther left a comment

Choose a reason for hiding this comment

Uh oh!

rrawther left a comment

Choose a reason for hiding this comment

Uh oh!

Srihari-mcw commented Dec 17, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

codecov bot commented Nov 14, 2025 •

edited

Loading

r-abishek Dec 3, 2025 •

edited

Loading