Remove unnecessary int hip load/stores by r-abishek · Pull Request #621 · ROCm/rpp

r-abishek · 2025-09-24T06:00:36Z

The PR addresses this comment to remove unnecessary integer pack load stores and use existing char load/stores.

Removed load/store helpers:

rpp_hip_pack_uint4()
rpp_hip_pack_int8()
only tensor sum related functions calling the above two helpers.

This was done only for one function Tensor Sum, but the change greatly improves performance of different Tensor-Sum variants between 35.6% to 82.8%.

Removal of Integer Pack Load Functions

Copilot

Pull Request Overview

This PR refactors tensor sum operations in the HIP kernel to eliminate unnecessary integer pack load/store helpers and use simpler char load/stores directly. The changes significantly improve performance of tensor sum operations by 35.6% to 82.8%.

Key changes:

Removed rpp_hip_pack_uint4() and rpp_hip_pack_int8() helper functions and their related load operations
Added new device functions add_uchar4_parts() and add_schar4_parts() for vectorized addition
Simplified data structures from d_uint8/d_int8 to d_uchar8/d_schar8 throughout tensor sum kernels

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
src/modules/tensor/hip/kernel/tensor_sum.cpp	Refactored tensor sum kernels to use direct char load/stores and added new vectorized addition functions
src/include/common/hip/rpp_hip_load_store.hpp	Removed unused integer packing functions and their associated load operations

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

src/include/common/hip/rpp_hip_load_store.hpp

src/modules/tensor/hip/kernel/tensor_sum.cpp

codecov · 2025-09-26T04:15:44Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #621      +/-   ##
===========================================
- Coverage    88.41%   88.40%   -0.01%     
===========================================
  Files          195      195              
  Lines        82768    82768              
===========================================
- Hits         73174    73164      -10     
- Misses        9594     9604      +10

Files with missing lines	Coverage Δ
src/include/common/hip/rpp_hip_load_store.hpp	`100.00% <ø> (ø)`
src/modules/tensor/hip/kernel/tensor_sum.cpp	`98.84% <ø> (ø)`

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

src/modules/tensor/hip/kernel/tensor_sum.cpp

* Initial changes for tensor sum for PLN1 and PKD3 variants U8 * Make changes for rest of the bit depths and layouts * Remove unused pack functions * Adjust comments * Initial cleanup * Further cleanup * Remove unused functions * Address copilot comments * Further standardize comments * Standardize comments spacing in functions affected --------- Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>

* Optimized version of channel dropout HIP backend and working code for HOST AVX, SSE * Modified name for dropout compute function * Modified way of AVX and SSE version channel dropout to avoid if statments * Modified Channel Dropout with generic compute code reused * Parameters and name change for channel dropout * Modified HIP for better performance * Modified the code and made the channel dropout templated version for all the bitdepths * Added output image and modified the .h file to effects for channel dropout * added space * Resolved all review comments and modified code to produce results for i8 variant * Removed empty line * Resolved review comments * Modified HOST after merge * Made changes after merging and QA passed for dropout * Channel dropout make_float 4 macro changes * Updated QA with random generator and updated BIN files * Modified QA name changes * Modified RandomSeed value passed as parameter to the function call * Update rppt_tensor_effects_augmentations.cpp indentation modified * Removed space and review comments resolved * channel dropout implementation * Resolved all the review comments and modified the magic number to set as constant for better understanding, added required comments * Merged branch from develop and resolved merge conflicts * Removed empty space * Updated omp loop for better performance * Updated hip channel dropout code for PKD version * Updated change after merge * Packaging - Remove Meta Package dependency (#610) Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * Test Package - Add cmake deps (#617) * Solarize augmentation - HOST and HIP (#605) * Solarize HIP and HOST implementation * cleanup the code and fix pkd3-pkd3 performance * Add golden output and doxygen comments * Add cheks for Threshold param * modified case num for solarize * minor fix * fix load/store calls * Address review comments * minor fix --------- Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com> Co-authored-by: Maddisetty <hmaddise@ctr2-alola-login-01.amd.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * Docs - Bump rocm-docs-core[api_reference] from 1.24.1 to 1.25.0 in /docs/sphinx (#622) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.24.1 to 1.25.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.25.0/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.24.1...v1.25.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.25.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Warning fixes for HIP Backend - Check return status (#606) * Initial hip memory fixes * Further hip warning fixes * Default build warning fixes - group III --------- Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * Docs - Bump rocm-docs-core[api_reference] from 1.25.0 to 1.26.0 in /docs/sphinx (#623) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.25.0 to 1.26.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.26.0/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.25.0...v1.26.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.26.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * ROCm 7.1 - Changelog updates (#625) * HIP - Remove unnecessary int load/stores (#621) * Initial changes for tensor sum for PLN1 and PKD3 variants U8 * Make changes for rest of the bit depths and layouts * Remove unused pack functions * Adjust comments * Initial cleanup * Further cleanup * Remove unused functions * Address copilot comments * Further standardize comments * Standardize comments spacing in functions affected --------- Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * CXX Compiler - Support TheRock (#630) * Test Suite - Enums for bit depth, output format and layout (#608) * removed numbers for bitdepths and output toggle * Add layout enum and replicate changes to HOST testsuite * Fix copilot review comments * resolve review comments * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * minor bugfix * minor bugfix * minor fix --------- Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * Docs - Bump rocm-docs-core[api_reference] from 1.26.0 to 1.27.0 in /docs/sphinx (#632) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.26.0 to 1.27.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.26.0...v1.27.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.27.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Packaging - Remove Meta Package dependency (#610) Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * Test Package - Add cmake deps (#617) * Docs - Bump rocm-docs-core[api_reference] from 1.24.1 to 1.25.0 in /docs/sphinx (#622) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.24.1 to 1.25.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.25.0/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.24.1...v1.25.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.25.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Docs - Bump rocm-docs-core[api_reference] from 1.25.0 to 1.26.0 in /docs/sphinx (#623) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.25.0 to 1.26.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.26.0/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.25.0...v1.26.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.26.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * HIP - Remove unnecessary int load/stores (#621) * Initial changes for tensor sum for PLN1 and PKD3 variants U8 * Make changes for rest of the bit depths and layouts * Remove unused pack functions * Adjust comments * Initial cleanup * Further cleanup * Remove unused functions * Address copilot comments * Further standardize comments * Standardize comments spacing in functions affected --------- Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * CXX Compiler - Support TheRock (#630) * Test Suite - Enums for bit depth, output format and layout (#608) * removed numbers for bitdepths and output toggle * Add layout enum and replicate changes to HOST testsuite * Fix copilot review comments * resolve review comments * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * minor bugfix * minor bugfix * minor fix --------- Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * Docs - Bump rocm-docs-core[api_reference] from 1.26.0 to 1.27.0 in /docs/sphinx (#632) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.26.0 to 1.27.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.26.0...v1.27.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.27.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Modified enum changed for the test suite for dropout * Updated enum changes for dropout * Update utilities/test_suite/HOST/runImageTests.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update utilities/test_suite/HIP/runImageTests.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update utilities/test_suite/HOST/runImageTests.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update utilities/test_suite/HIP/runImageTests.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update utilities/test_suite/HOST/Tensor_image_host.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/modules/tensor/rppt_tensor_effects_augmentations.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/modules/tensor/rppt_tensor_effects_augmentations.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Docs - Bump rocm-docs-core[api_reference] from 1.24.1 to 1.25.0 in /docs/sphinx (#622) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.24.1 to 1.25.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.25.0/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.24.1...v1.25.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.25.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * ROCm 7.1 - Changelog updates (#625) * Resolved copilot review comments for channel dropout * Reverted back the dropoutTypeCases * Updated and resolved reivew comments * Modified common.py file for channel dropout * Reverted changes * Updated common.py changes * updated channel dropout and resolved review comments * Updated random mask in API level * Updated seed to be passed from test suite * Updated Random generator in test suite level * updated name for every instances * Resolved review comments * Resolved Review comments and modified HIP code * Updated and resolved review comments * Modified datatype for channel dropout Hip backend --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: sampath117 <snehaa@multicorewareinc.com> Co-authored-by: RooseweltMcW <austin.roosewelt@multicorewareinc.com> Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com> Co-authored-by: arvindcheru <90783369+arvindcheru@users.noreply.github.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> Co-authored-by: Maddisetty <hmaddise@ctr2-alola-login-01.amd.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Optimized version of channel dropout HIP backend and working code for HOST AVX, SSE * Modified name for dropout compute function * Modified way of AVX and SSE version channel dropout to avoid if statments * Modified Channel Dropout with generic compute code reused * Parameters and name change for channel dropout * Modified HIP for better performance * Modified the code and made the channel dropout templated version for all the bitdepths * Added output image and modified the .h file to effects for channel dropout * added space * Resolved all review comments and modified code to produce results for i8 variant * Removed empty line * Resolved review comments * Modified HOST after merge * Made changes after merging and QA passed for dropout * Channel dropout make_float 4 macro changes * Updated QA with random generator and updated BIN files * Modified QA name changes * Modified RandomSeed value passed as parameter to the function call * Update rppt_tensor_effects_augmentations.cpp indentation modified * Removed space and review comments resolved * channel dropout implementation * Resolved all the review comments and modified the magic number to set as constant for better understanding, added required comments * Merged branch from develop and resolved merge conflicts * Removed empty space * Updated omp loop for better performance * Updated hip channel dropout code for PKD version * Updated change after merge * Packaging - Remove Meta Package dependency (ROCm#610) Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * Test Package - Add cmake deps (ROCm#617) * Solarize augmentation - HOST and HIP (ROCm#605) * Solarize HIP and HOST implementation * cleanup the code and fix pkd3-pkd3 performance * Add golden output and doxygen comments * Add cheks for Threshold param * modified case num for solarize * minor fix * fix load/store calls * Address review comments * minor fix --------- Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com> Co-authored-by: Maddisetty <hmaddise@ctr2-alola-login-01.amd.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * Docs - Bump rocm-docs-core[api_reference] from 1.24.1 to 1.25.0 in /docs/sphinx (ROCm#622) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.24.1 to 1.25.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.25.0/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.24.1...v1.25.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.25.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Warning fixes for HIP Backend - Check return status (ROCm#606) * Initial hip memory fixes * Further hip warning fixes * Default build warning fixes - group III --------- Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * Docs - Bump rocm-docs-core[api_reference] from 1.25.0 to 1.26.0 in /docs/sphinx (ROCm#623) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.25.0 to 1.26.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.26.0/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.25.0...v1.26.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.26.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * ROCm 7.1 - Changelog updates (ROCm#625) * HIP - Remove unnecessary int load/stores (ROCm#621) * Initial changes for tensor sum for PLN1 and PKD3 variants U8 * Make changes for rest of the bit depths and layouts * Remove unused pack functions * Adjust comments * Initial cleanup * Further cleanup * Remove unused functions * Address copilot comments * Further standardize comments * Standardize comments spacing in functions affected --------- Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * CXX Compiler - Support TheRock (ROCm#630) * Test Suite - Enums for bit depth, output format and layout (ROCm#608) * removed numbers for bitdepths and output toggle * Add layout enum and replicate changes to HOST testsuite * Fix copilot review comments * resolve review comments * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * minor bugfix * minor bugfix * minor fix --------- Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * Docs - Bump rocm-docs-core[api_reference] from 1.26.0 to 1.27.0 in /docs/sphinx (ROCm#632) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.26.0 to 1.27.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.26.0...v1.27.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.27.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Packaging - Remove Meta Package dependency (ROCm#610) Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * Test Package - Add cmake deps (ROCm#617) * Docs - Bump rocm-docs-core[api_reference] from 1.24.1 to 1.25.0 in /docs/sphinx (ROCm#622) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.24.1 to 1.25.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.25.0/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.24.1...v1.25.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.25.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Docs - Bump rocm-docs-core[api_reference] from 1.25.0 to 1.26.0 in /docs/sphinx (ROCm#623) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.25.0 to 1.26.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.26.0/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.25.0...v1.26.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.26.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * HIP - Remove unnecessary int load/stores (ROCm#621) * Initial changes for tensor sum for PLN1 and PKD3 variants U8 * Make changes for rest of the bit depths and layouts * Remove unused pack functions * Adjust comments * Initial cleanup * Further cleanup * Remove unused functions * Address copilot comments * Further standardize comments * Standardize comments spacing in functions affected --------- Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * CXX Compiler - Support TheRock (ROCm#630) * Test Suite - Enums for bit depth, output format and layout (ROCm#608) * removed numbers for bitdepths and output toggle * Add layout enum and replicate changes to HOST testsuite * Fix copilot review comments * resolve review comments * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * minor bugfix * minor bugfix * minor fix --------- Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> * Docs - Bump rocm-docs-core[api_reference] from 1.26.0 to 1.27.0 in /docs/sphinx (ROCm#632) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.26.0 to 1.27.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.26.0...v1.27.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.27.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Modified enum changed for the test suite for dropout * Updated enum changes for dropout * Update utilities/test_suite/HOST/runImageTests.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update utilities/test_suite/HIP/runImageTests.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update utilities/test_suite/HOST/runImageTests.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update utilities/test_suite/HIP/runImageTests.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update utilities/test_suite/HOST/Tensor_image_host.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/modules/tensor/rppt_tensor_effects_augmentations.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/modules/tensor/rppt_tensor_effects_augmentations.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Docs - Bump rocm-docs-core[api_reference] from 1.24.1 to 1.25.0 in /docs/sphinx (ROCm#622) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.24.1 to 1.25.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.25.0/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.24.1...v1.25.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.25.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * ROCm 7.1 - Changelog updates (ROCm#625) * Resolved copilot review comments for channel dropout * Reverted back the dropoutTypeCases * Updated and resolved reivew comments * Modified common.py file for channel dropout * Reverted changes * Updated common.py changes * updated channel dropout and resolved review comments * Updated random mask in API level * Updated seed to be passed from test suite * Updated Random generator in test suite level * updated name for every instances * Resolved review comments * Resolved Review comments and modified HIP code * Updated and resolved review comments * Modified datatype for channel dropout Hip backend --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: sampath117 <snehaa@multicorewareinc.com> Co-authored-by: RooseweltMcW <austin.roosewelt@multicorewareinc.com> Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com> Co-authored-by: arvindcheru <90783369+arvindcheru@users.noreply.github.com> Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com> Co-authored-by: Maddisetty <hmaddise@ctr2-alola-login-01.amd.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Srihari-mcw and others added 12 commits September 10, 2025 11:31

Initial changes for tensor sum for PLN1 and PKD3 variants U8

e73c6f3

Make changes for rest of the bit depths and layouts

728c453

Remove unused pack functions

faf9f80

Adjust comments

11ead78

Initial cleanup

28bc79a

Further cleanup

4f24c19

Remove unused functions

bda86cd

Merge branch 'develop' into pack_int_removal

77b94e4

Address copilot comments

16ef37b

Further standardize comments

fb88125

Standardize comments spacing in functions affected

b0c763d

Merge pull request #487 from Srihari-mcw/pack_int_removal

01f3e63

Removal of Integer Pack Load Functions

r-abishek requested a review from Copilot September 24, 2025 06:00

r-abishek added the ci:precheckin label Sep 24, 2025

Copilot AI reviewed Sep 24, 2025

View reviewed changes

src/include/common/hip/rpp_hip_load_store.hpp Show resolved Hide resolved

src/modules/tensor/hip/kernel/tensor_sum.cpp Show resolved Hide resolved

LakshmiKumar23 requested a review from rrawther September 24, 2025 16:13

LakshmiKumar23 assigned kiritigowda Sep 24, 2025

LakshmiKumar23 self-requested a review September 24, 2025 16:13

kiritigowda added 3 commits September 26, 2025 09:32

Merge branch 'develop' into ar/opt_load_store_hip

d771c69

Merge branch 'develop' into ar/opt_load_store_hip

897f325

Merge branch 'develop' into ar/opt_load_store_hip

71f9db4

rrawther reviewed Oct 3, 2025

View reviewed changes

src/modules/tensor/hip/kernel/tensor_sum.cpp Show resolved Hide resolved

Merge branch 'develop' into ar/opt_load_store_hip

2ff1974

rrawther approved these changes Oct 10, 2025

View reviewed changes

kiritigowda merged commit 5ad7a66 into ROCm:develop Oct 10, 2025
9 of 10 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove unnecessary int hip load/stores#621

Remove unnecessary int hip load/stores#621
kiritigowda merged 16 commits intoROCm:developfrom
r-abishek:ar/opt_load_store_hip

r-abishek commented Sep 24, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Sep 26, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

r-abishek commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

r-abishek commented Sep 24, 2025 •

edited

Loading

codecov bot commented Sep 26, 2025 •

edited

Loading