Skip to content

CXX Compiler - Support TheRock#630

Merged
kiritigowda merged 1 commit intoROCm:developfrom
kiritigowda:kg/compiler-updates
Oct 13, 2025
Merged

CXX Compiler - Support TheRock#630
kiritigowda merged 1 commit intoROCm:developfrom
kiritigowda:kg/compiler-updates

Conversation

@kiritigowda
Copy link
Copy Markdown
Collaborator

@kiritigowda kiritigowda commented Oct 13, 2025

Motivation

AMD Clang/Clang++ use core path

Technical Details

The symlink to amdclang/amdclang++ is not available on all rocm installations

Test Plan

CTests from test package

Test Result

All tests should pass

Submission Checklist

@kiritigowda kiritigowda self-assigned this Oct 13, 2025
@kiritigowda kiritigowda requested a review from a team as a code owner October 13, 2025 17:54
@kiritigowda kiritigowda added enhancement New feature or request ci:precheckin labels Oct 13, 2025
@kiritigowda
Copy link
Copy Markdown
Collaborator Author

kiritigowda commented Oct 13, 2025 

-- rpp -- Using Compiler - Path:/opt/rocm/lib/llvm/bin/amdclang++	Version:20.0.0	Compiler:Clang
-- rpp -- CMAKE_CXX_FLAGS:-fprofile-instr-generate -fcoverage-mapping -O0 -g -fopenmp=libomp -fPIC -mavx2 -mf16c -mfma
-- rpp -- Link Libraries: OpenMP::OpenMP_CXX;stdc++fs;hip::host

@kiritigowda kiritigowda merged commit c4b8ef2 into ROCm:develop Oct 13, 2025
6 of 8 checks passed
@kiritigowda kiritigowda deleted the kg/compiler-updates branch October 13, 2025 19:31
RooseweltMcW pushed a commit to RooseweltMcW/rpp that referenced this pull request Oct 29, 2025
@kiritigowda @HazarathKumarM
CXX Compiler - Support TheRock (ROCm#630)
750f0ea
RooseweltMcW pushed a commit to HazarathKumarM/rpp that referenced this pull request Oct 29, 2025
@kiritigowda @HazarathKumarM
CXX Compiler - Support TheRock (ROCm#630)
0a89798
ManasaDattaT pushed a commit to RooseweltMcW/rpp that referenced this pull request Dec 19, 2025
@kiritigowda
CXX Compiler - Support TheRock (ROCm#630)
69a7d38
kiritigowda added a commit that referenced this pull request Jan 5, 2026
@r-abishek @snehaa8
@RooseweltMcW @HazarathKumarM @arvindcheru @kiritigowda @dependabot @Srihari-mcw
Dropout (Channel) - HIP and HOST (#634)
fd7f1b7 
* Optimized version of channel dropout HIP backend and working code for HOST AVX, SSE

* Modified name for dropout compute function

* Modified way of AVX and SSE version channel dropout to avoid if statments

* Modified Channel Dropout with generic compute code reused

* Parameters and name change for channel dropout

* Modified HIP for better performance

* Modified the code and made the channel dropout templated version for all the bitdepths

* Added output image and modified the .h file to effects for channel dropout

* added space

* Resolved all review comments and modified code to produce results for i8 variant

* Removed empty line

* Resolved review comments

* Modified HOST after merge

* Made changes after merging and QA passed for dropout

* Channel dropout make_float 4 macro changes

* Updated QA with random generator and updated BIN files

* Modified QA name changes

* Modified RandomSeed value passed as parameter to the function call

* Update rppt_tensor_effects_augmentations.cpp

indentation modified

* Removed space and review comments resolved

* channel dropout implementation

* Resolved all the review comments and modified the magic number to set as constant for better understanding, added required comments

* Merged branch from develop and resolved merge conflicts

* Removed empty space

* Updated omp loop for better performance

* Updated hip channel dropout code for PKD version

* Updated change after merge

* Packaging - Remove Meta Package dependency (#610)

Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>

* Test Package - Add cmake deps (#617)

* Solarize augmentation - HOST and HIP (#605)

* Solarize HIP and HOST implementation

* cleanup the code and fix pkd3-pkd3 performance

* Add golden output and doxygen comments

* Add cheks for Threshold param

* modified case num for solarize

* minor fix

* fix load/store calls

* Address review comments

* minor fix

---------

Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com>
Co-authored-by: Maddisetty <hmaddise@ctr2-alola-login-01.amd.com>
Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>

* Docs - Bump rocm-docs-core[api_reference] from 1.24.1 to 1.25.0 in /docs/sphinx (#622)

Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.24.1 to 1.25.0.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.25.0/CHANGELOG.md)
- [Commits](ROCm/rocm-docs-core@v1.24.1...v1.25.0)

---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
  dependency-version: 1.25.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Warning fixes for HIP Backend - Check return status (#606)

* Initial hip memory fixes

* Further hip warning fixes

* Default build warning fixes - group III

---------

Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com>
Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>

* Docs - Bump rocm-docs-core[api_reference] from 1.25.0 to 1.26.0 in /docs/sphinx (#623)

Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.25.0 to 1.26.0.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.26.0/CHANGELOG.md)
- [Commits](ROCm/rocm-docs-core@v1.25.0...v1.26.0)

---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
  dependency-version: 1.26.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* ROCm 7.1 - Changelog updates (#625)

* HIP - Remove unnecessary int load/stores (#621)

* Initial changes for tensor sum for PLN1 and PKD3 variants U8

* Make changes for rest of the bit depths and layouts

* Remove unused pack functions

* Adjust comments

* Initial cleanup

* Further cleanup

* Remove unused functions

* Address copilot comments

* Further standardize comments

* Standardize comments spacing in functions affected

---------

Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com>
Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>

* CXX Compiler - Support TheRock (#630)

* Test Suite - Enums for bit depth, output format and layout (#608)

* removed numbers for bitdepths and output toggle

* Add layout enum and replicate changes to HOST testsuite

* Fix copilot review comments

* resolve review comments

* Apply suggestion from @Copilot

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* minor bugfix

* minor bugfix

* minor fix

---------

Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>

* Docs - Bump rocm-docs-core[api_reference] from 1.26.0 to 1.27.0 in /docs/sphinx (#632)

Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.26.0 to 1.27.0.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](ROCm/rocm-docs-core@v1.26.0...v1.27.0)

---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
  dependency-version: 1.27.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Packaging - Remove Meta Package dependency (#610)

Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>

* Test Package - Add cmake deps (#617)

* Docs - Bump rocm-docs-core[api_reference] from 1.24.1 to 1.25.0 in /docs/sphinx (#622)

Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.24.1 to 1.25.0.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.25.0/CHANGELOG.md)
- [Commits](ROCm/rocm-docs-core@v1.24.1...v1.25.0)

---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
  dependency-version: 1.25.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Docs - Bump rocm-docs-core[api_reference] from 1.25.0 to 1.26.0 in /docs/sphinx (#623)

Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.25.0 to 1.26.0.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.26.0/CHANGELOG.md)
- [Commits](ROCm/rocm-docs-core@v1.25.0...v1.26.0)

---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
  dependency-version: 1.26.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* HIP - Remove unnecessary int load/stores (#621)

* Initial changes for tensor sum for PLN1 and PKD3 variants U8

* Make changes for rest of the bit depths and layouts

* Remove unused pack functions

* Adjust comments

* Initial cleanup

* Further cleanup

* Remove unused functions

* Address copilot comments

* Further standardize comments

* Standardize comments spacing in functions affected

---------

Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com>
Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>

* CXX Compiler - Support TheRock (#630)

* Test Suite - Enums for bit depth, output format and layout (#608)

* removed numbers for bitdepths and output toggle

* Add layout enum and replicate changes to HOST testsuite

* Fix copilot review comments

* resolve review comments

* Apply suggestion from @Copilot

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* minor bugfix

* minor bugfix

* minor fix

---------

Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>

* Docs - Bump rocm-docs-core[api_reference] from 1.26.0 to 1.27.0 in /docs/sphinx (#632)

Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.26.0 to 1.27.0.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](ROCm/rocm-docs-core@v1.26.0...v1.27.0)

---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
  dependency-version: 1.27.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Modified enum changed for the test suite for dropout

* Updated enum changes for dropout

* Update utilities/test_suite/HOST/runImageTests.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update utilities/test_suite/HIP/runImageTests.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update utilities/test_suite/HOST/runImageTests.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update utilities/test_suite/HIP/runImageTests.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update utilities/test_suite/HOST/Tensor_image_host.cpp

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update src/modules/tensor/rppt_tensor_effects_augmentations.cpp

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update src/modules/tensor/rppt_tensor_effects_augmentations.cpp

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Docs - Bump rocm-docs-core[api_reference] from 1.24.1 to 1.25.0 in /docs/sphinx (#622)

Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.24.1 to 1.25.0.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.25.0/CHANGELOG.md)
- [Commits](ROCm/rocm-docs-core@v1.24.1...v1.25.0)

---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
  dependency-version: 1.25.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* ROCm 7.1 - Changelog updates (#625)

* Resolved copilot review comments for channel dropout

* Reverted back the dropoutTypeCases

* Updated and resolved reivew comments

* Modified common.py file for channel dropout

* Reverted changes

* Updated common.py changes

* updated channel dropout and resolved review comments

* Updated random mask in API level

* Updated seed to be passed from test suite

* Updated Random generator in test suite level

* updated name for every instances

* Resolved review comments

* Resolved Review comments and modified HIP code

* Updated and resolved review comments

* Modified datatype for channel dropout Hip backend

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: sampath117 <snehaa@multicorewareinc.com>
Co-authored-by: RooseweltMcW <austin.roosewelt@multicorewareinc.com>
Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com>
Co-authored-by: arvindcheru <90783369+arvindcheru@users.noreply.github.com>
Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>
Co-authored-by: Maddisetty <hmaddise@ctr2-alola-login-01.amd.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
HazarathKumarM added a commit to HazarathKumarM/rpp that referenced this pull request Jan 6, 2026
@r-abishek @snehaa8
@RooseweltMcW @HazarathKumarM @arvindcheru @kiritigowda @dependabot @Srihari-mcw
Dropout (Channel) - HIP and HOST (ROCm#634)
f015298 
* Optimized version of channel dropout HIP backend and working code for HOST AVX, SSE

* Modified name for dropout compute function

* Modified way of AVX and SSE version channel dropout to avoid if statments

* Modified Channel Dropout with generic compute code reused

* Parameters and name change for channel dropout

* Modified HIP for better performance

* Modified the code and made the channel dropout templated version for all the bitdepths

* Added output image and modified the .h file to effects for channel dropout

* added space

* Resolved all review comments and modified code to produce results for i8 variant

* Removed empty line

* Resolved review comments

* Modified HOST after merge

* Made changes after merging and QA passed for dropout

* Channel dropout make_float 4 macro changes

* Updated QA with random generator and updated BIN files

* Modified QA name changes

* Modified RandomSeed value passed as parameter to the function call

* Update rppt_tensor_effects_augmentations.cpp

indentation modified

* Removed space and review comments resolved

* channel dropout implementation

* Resolved all the review comments and modified the magic number to set as constant for better understanding, added required comments

* Merged branch from develop and resolved merge conflicts

* Removed empty space

* Updated omp loop for better performance

* Updated hip channel dropout code for PKD version

* Updated change after merge

* Packaging - Remove Meta Package dependency (ROCm#610)

Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>

* Test Package - Add cmake deps (ROCm#617)

* Solarize augmentation - HOST and HIP (ROCm#605)

* Solarize HIP and HOST implementation

* cleanup the code and fix pkd3-pkd3 performance

* Add golden output and doxygen comments

* Add cheks for Threshold param

* modified case num for solarize

* minor fix

* fix load/store calls

* Address review comments

* minor fix

---------

Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com>
Co-authored-by: Maddisetty <hmaddise@ctr2-alola-login-01.amd.com>
Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>

* Docs - Bump rocm-docs-core[api_reference] from 1.24.1 to 1.25.0 in /docs/sphinx (ROCm#622)

Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.24.1 to 1.25.0.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.25.0/CHANGELOG.md)
- [Commits](ROCm/rocm-docs-core@v1.24.1...v1.25.0)

---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
  dependency-version: 1.25.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Warning fixes for HIP Backend - Check return status (ROCm#606)

* Initial hip memory fixes

* Further hip warning fixes

* Default build warning fixes - group III

---------

Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com>
Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>

* Docs - Bump rocm-docs-core[api_reference] from 1.25.0 to 1.26.0 in /docs/sphinx (ROCm#623)

Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.25.0 to 1.26.0.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.26.0/CHANGELOG.md)
- [Commits](ROCm/rocm-docs-core@v1.25.0...v1.26.0)

---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
  dependency-version: 1.26.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* ROCm 7.1 - Changelog updates (ROCm#625)

* HIP - Remove unnecessary int load/stores (ROCm#621)

* Initial changes for tensor sum for PLN1 and PKD3 variants U8

* Make changes for rest of the bit depths and layouts

* Remove unused pack functions

* Adjust comments

* Initial cleanup

* Further cleanup

* Remove unused functions

* Address copilot comments

* Further standardize comments

* Standardize comments spacing in functions affected

---------

Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com>
Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>

* CXX Compiler - Support TheRock (ROCm#630)

* Test Suite - Enums for bit depth, output format and layout (ROCm#608)

* removed numbers for bitdepths and output toggle

* Add layout enum and replicate changes to HOST testsuite

* Fix copilot review comments

* resolve review comments

* Apply suggestion from @Copilot

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* minor bugfix

* minor bugfix

* minor fix

---------

Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>

* Docs - Bump rocm-docs-core[api_reference] from 1.26.0 to 1.27.0 in /docs/sphinx (ROCm#632)

Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.26.0 to 1.27.0.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](ROCm/rocm-docs-core@v1.26.0...v1.27.0)

---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
  dependency-version: 1.27.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Packaging - Remove Meta Package dependency (ROCm#610)

Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>

* Test Package - Add cmake deps (ROCm#617)

* Docs - Bump rocm-docs-core[api_reference] from 1.24.1 to 1.25.0 in /docs/sphinx (ROCm#622)

Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.24.1 to 1.25.0.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.25.0/CHANGELOG.md)
- [Commits](ROCm/rocm-docs-core@v1.24.1...v1.25.0)

---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
  dependency-version: 1.25.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Docs - Bump rocm-docs-core[api_reference] from 1.25.0 to 1.26.0 in /docs/sphinx (ROCm#623)

Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.25.0 to 1.26.0.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.26.0/CHANGELOG.md)
- [Commits](ROCm/rocm-docs-core@v1.25.0...v1.26.0)

---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
  dependency-version: 1.26.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* HIP - Remove unnecessary int load/stores (ROCm#621)

* Initial changes for tensor sum for PLN1 and PKD3 variants U8

* Make changes for rest of the bit depths and layouts

* Remove unused pack functions

* Adjust comments

* Initial cleanup

* Further cleanup

* Remove unused functions

* Address copilot comments

* Further standardize comments

* Standardize comments spacing in functions affected

---------

Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com>
Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>

* CXX Compiler - Support TheRock (ROCm#630)

* Test Suite - Enums for bit depth, output format and layout (ROCm#608)

* removed numbers for bitdepths and output toggle

* Add layout enum and replicate changes to HOST testsuite

* Fix copilot review comments

* resolve review comments

* Apply suggestion from @Copilot

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* minor bugfix

* minor bugfix

* minor fix

---------

Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>

* Docs - Bump rocm-docs-core[api_reference] from 1.26.0 to 1.27.0 in /docs/sphinx (ROCm#632)

Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.26.0 to 1.27.0.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](ROCm/rocm-docs-core@v1.26.0...v1.27.0)

---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
  dependency-version: 1.27.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Modified enum changed for the test suite for dropout

* Updated enum changes for dropout

* Update utilities/test_suite/HOST/runImageTests.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update utilities/test_suite/HIP/runImageTests.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update utilities/test_suite/HOST/runImageTests.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update utilities/test_suite/HIP/runImageTests.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update utilities/test_suite/HOST/Tensor_image_host.cpp

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update src/modules/tensor/rppt_tensor_effects_augmentations.cpp

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update src/modules/tensor/rppt_tensor_effects_augmentations.cpp

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Docs - Bump rocm-docs-core[api_reference] from 1.24.1 to 1.25.0 in /docs/sphinx (ROCm#622)

Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.24.1 to 1.25.0.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.25.0/CHANGELOG.md)
- [Commits](ROCm/rocm-docs-core@v1.24.1...v1.25.0)

---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
  dependency-version: 1.25.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* ROCm 7.1 - Changelog updates (ROCm#625)

* Resolved copilot review comments for channel dropout

* Reverted back the dropoutTypeCases

* Updated and resolved reivew comments

* Modified common.py file for channel dropout

* Reverted changes

* Updated common.py changes

* updated channel dropout and resolved review comments

* Updated random mask in API level

* Updated seed to be passed from test suite

* Updated Random generator in test suite level

* updated name for every instances

* Resolved review comments

* Resolved Review comments and modified HIP code

* Updated and resolved review comments

* Modified datatype for channel dropout Hip backend

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: sampath117 <snehaa@multicorewareinc.com>
Co-authored-by: RooseweltMcW <austin.roosewelt@multicorewareinc.com>
Co-authored-by: HazarathKumarM <hazarathkumar@multicorewareinc.com>
Co-authored-by: arvindcheru <90783369+arvindcheru@users.noreply.github.com>
Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>
Co-authored-by: Maddisetty <hmaddise@ctr2-alola-login-01.amd.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Srihari-mcw <srihari@multicorewareinc.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AryanSalmanpour AryanSalmanpour AryanSalmanpour approved these changes

@LakshmiKumar23 LakshmiKumar23 LakshmiKumar23 approved these changes

@rrawther rrawther Awaiting requested review from rrawther

Assignees

@kiritigowda kiritigowda

Labels

ci:precheckin enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kiritigowda @AryanSalmanpour @LakshmiKumar23