CMakeLists - Set Compiler and std#582
Merged
kiritigowda merged 2 commits intoROCm:developfrom Jul 21, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reorganizes the CMake configuration by moving C++ standard settings to be declared before compiler selection. The changes ensure that C++ standard requirements are consistently set before determining which compiler to use across all CMakeLists.txt files.
Key changes:
- Move CMAKE_CXX_STANDARD settings before compiler selection logic
- Add CMAKE_CXX_EXTENSIONS ON setting consistently across all files
- Set CMAKE_C_COMPILER to clang when amdclang++ is not available
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| CMakeLists.txt | Main CMake file with reordered standard settings and compiler fallback |
| utilities/test_suite/HOST/CMakeLists.txt | Test suite HOST build with consistent standard configuration |
| utilities/test_suite/HIP/CMakeLists.txt | Test suite HIP build with consistent standard configuration |
| utilities/test_suite/CMakeLists.txt | Test suite root with consistent standard configuration |
| utilities/rpp-unittests/OCL_NEW/CMakeLists.txt | OCL unit tests with consistent standard configuration |
| utilities/rpp-unittests/HOST_NEW/CMakeLists.txt | HOST unit tests with consistent standard configuration |
| utilities/rpp-unittests/HIP_NEW/CMakeLists.txt | HIP unit tests with consistent standard configuration |
| utilities/rpp-performancetests/OCL_NEW/CMakeLists.txt | OCL performance tests with consistent standard configuration |
| utilities/rpp-performancetests/HOST_NEW/CMakeLists.txt | HOST performance tests with consistent standard configuration |
| utilities/rpp-performancetests/HIP_NEW/CMakeLists.txt | HIP performance tests with consistent standard configuration |
| utilities/examples/brightness/CMakeLists.txt | Brightness example with consistent standard configuration |
r-abishek
approved these changes
Jul 18, 2025
ManasaDattaT
pushed a commit
to ManasaDattaT/rpp
that referenced
this pull request
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.