flatten_indices: remove syncs by nikitaved · Pull Request #94401 · pytorch/pytorch

nikitaved · 2023-02-08T16:06:12Z

Stack from ghstack (oldest at bottom):

[ghstack-poisoned]

pytorch-bot · 2023-02-08T16:06:26Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/94401

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 07d182b:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[ghstack-poisoned]

pearu

LGMT! Thanks, @nikitaved!

pearu · 2023-02-09T17:41:55Z

aten/src/ATen/native/sparse/FlattenIndicesCommon.h

+          // NOTE: capture by value required by CUDA
+          [=] FUNCAPI (int64_t nnz_idx) -> int64_t {
+          const auto* RESTRICT ptr_indices_dim = ptr_indices + nnz_idx * indices_nnz_stride;
+          auto hash = static_cast<int64_t>(0);


Suggested change

auto hash = static_cast<int64_t>(0);

int64_t hash = 0;

[ghstack-poisoned]

nikitaved · 2023-03-10T12:01:28Z

@pytorchbot merge

pytorchmergebot · 2023-03-10T12:03:20Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Pull Request resolved: pytorch/pytorch#94401 Approved by: https://github.com/cpuhrsch, https://github.com/pearu

malfet · 2023-03-13T18:07:15Z

This causes internal link failures, trying to investigate:

stderr: ld.lld: error: undefined symbol: at::native::DispatchStub<at::Tensor (*)(at::Tensor const&, c10::ArrayRef<long long>), at::native::flatten_indices_stub>::DEFAULT
>>> referenced by DispatchStub.h:137 (buck-out/gen/fe3a39b8/xplat/caffe2/aten_headerAndroid#header-mode-symlink-tree-with-header-map,headers/ATen/native/DispatchStub.h:137)
>>>               buck-out/gen/fe3a39b8/xplat/caffe2/aten_cpuAndroid#android-x86,compile-pic-SparseTensorUtils.cpp.oeb82483d/aten/src/ATen/SparseTensorUtils.cpp.o:(at::sparse::flatten_indices(at::Tensor const&, c10::ArrayRef<long long>, bool))
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Some explanation: DECLARE_DISPATCH is design with performance in mind, i.e. calling a stub result in direct, rather than indirect function call, which result in a linker error if aten_core and aten_native are 2 different targets, which they are if one to look into

pytorch/buckbuild.bzl

Lines 1916 to 1925 in b992199

    
           ("aten_cpu", jit_core_sources + aten_cpu_source_list + [ 
        
               # Generated 
        
               ":gen_aten[Functions.cpp]", 
        
               ":gen_aten[Operators_0.cpp]", 
        
               ":gen_aten[Operators_1.cpp]", 
        
               ":gen_aten[Operators_2.cpp]", 
        
               ":gen_aten[Operators_3.cpp]", 
        
               ":gen_aten[Operators_4.cpp]", 
        
               ":gen_aten[core/ATenOpList.cpp]", 
        
               ":gen_aten[core/TensorMethods.cpp]",

To expose errors similar to #94401 (comment) in OSS CI

To expose errors similar to #94401 (comment) in OSS CI Building `aten_cpu` as a shared library with `-Wl,--no-undefined` simulates behavior of Android NDK toolchain. Test plan: It should fail, see https://github.com/pytorch/pytorch/actions/runs/4410571970/jobs/7728232916#step:14:1386 Pull Request resolved: #96697 Approved by: https://github.com/kit1980

Pull Request resolved: pytorch/pytorch#94401 Approved by: https://github.com/cpuhrsch, https://github.com/pearu

One more regression from #94401

One more regression from #94401 Pull Request resolved: #96765 Approved by: https://github.com/izaitsevfb, https://github.com/Skylion007

To expose errors similar to pytorch/pytorch#94401 (comment) in OSS CI Building `aten_cpu` as a shared library with `-Wl,--no-undefined` simulates behavior of Android NDK toolchain. Test plan: It should fail, see https://github.com/pytorch/pytorch/actions/runs/4410571970/jobs/7728232916#step:14:1386 Pull Request resolved: pytorch/pytorch#96697 Approved by: https://github.com/kit1980

One more regression from pytorch/pytorch#94401 Pull Request resolved: pytorch/pytorch#96765 Approved by: https://github.com/izaitsevfb, https://github.com/Skylion007

To expose errors similar to pytorch/pytorch#94401 (comment) in OSS CI Building `aten_cpu` as a shared library with `-Wl,--no-undefined` simulates behavior of Android NDK toolchain. Test plan: It should fail, see https://github.com/pytorch/pytorch/actions/runs/4410571970/jobs/7728232916#step:14:1386 Pull Request resolved: pytorch/pytorch#96697 Approved by: https://github.com/kit1980

One more regression from pytorch/pytorch#94401 Pull Request resolved: pytorch/pytorch#96765 Approved by: https://github.com/izaitsevfb, https://github.com/Skylion007

flatten_indices: remove syncs

65ca9fc

[ghstack-poisoned]

nikitaved mentioned this pull request Feb 8, 2023

COO intersection primitives: performance improvement #92976

Closed

pytorch-bot bot added the release notes: sparse release notes category label Feb 8, 2023

pytorchbot added the open source label Feb 8, 2023

Update on "flatten_indices: remove syncs"

a9270c0

[ghstack-poisoned]

nikitaved mentioned this pull request Feb 8, 2023

sparse_mask: remove syncs by removing calls to coalesce #94406

Closed

nikitaved added 2 commits February 8, 2023 17:19

Update on "flatten_indices: remove syncs"

d243e2b

[ghstack-poisoned]

Update on "flatten_indices: remove syncs"

afa83d1

[ghstack-poisoned]

nikitaved requested review from alexsamardzic, amjames, bhosmer, cpuhrsch and pearu February 9, 2023 10:31

nikitaved added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 9, 2023

cpuhrsch approved these changes Feb 9, 2023

View reviewed changes

pearu approved these changes Feb 9, 2023

View reviewed changes

Update on "flatten_indices: remove syncs"

e65f05e

[ghstack-poisoned]

nikitaved mentioned this pull request Feb 10, 2023

COO intersection: allow external hash + hash reuse in sparse_mask #94596

Closed

nikitaved added 4 commits February 13, 2023 09:03

Update on "flatten_indices: remove syncs"

e9db485

[ghstack-poisoned]

Update on "flatten_indices: remove syncs"

b84186b

[ghstack-poisoned]

Update on "flatten_indices: remove syncs"

6f2143e

[ghstack-poisoned]

Update on "flatten_indices: remove syncs"

cc38b4f

[ghstack-poisoned]

nikitaved mentioned this pull request Feb 16, 2023

sparse.mm backward: performance improvements #94991

Closed

nikitaved added 4 commits February 17, 2023 17:14

Update on "flatten_indices: remove syncs"

ed49e01

[ghstack-poisoned]

Update on "flatten_indices: remove syncs"

b12adbc

[ghstack-poisoned]

Update on "flatten_indices: remove syncs"

d585264

[ghstack-poisoned]

Update on "flatten_indices: remove syncs"

25c761e

[ghstack-poisoned]

nikitaved mentioned this pull request Feb 20, 2023

sparse_mask: backward support for sparse lhs #95165

Closed

nikitaved added 5 commits February 20, 2023 15:40

Update on "flatten_indices: remove syncs"

962bd6e

[ghstack-poisoned]

Update on "flatten_indices: remove syncs"

39cee9a

[ghstack-poisoned]

Update on "flatten_indices: remove syncs"

ed436ad

[ghstack-poisoned]

Update on "flatten_indices: remove syncs"

0212bcc

[ghstack-poisoned]

Update on "flatten_indices: remove syncs"

9ca935b

[ghstack-poisoned]

nikitaved mentioned this pull request Mar 6, 2023

COO intersection primitives: performance improvement #96094

Closed

nikitaved added 2 commits March 6, 2023 14:18

Update on "flatten_indices: remove syncs"

f31b382

[ghstack-poisoned]

Update on "flatten_indices: remove syncs"

07d182b

[ghstack-poisoned]

ZainRizvi mentioned this pull request Mar 9, 2023

Devs using C++17 features will break internal builds #96427

Closed

pytorchmergebot added the Merged label Mar 10, 2023

pytorchmergebot closed this in d0f4d62 Mar 10, 2023

cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 12, 2023

flatten_indices: remove syncs (#94401)

0b4b837

Pull Request resolved: pytorch/pytorch#94401 Approved by: https://github.com/cpuhrsch, https://github.com/pearu

malfet mentioned this pull request Mar 13, 2023

[BE] Add regression test for aten shared build #96697

Closed

malfet added a commit that referenced this pull request Mar 13, 2023

[BE] Add regression test for aten shared build

c069228

To expose errors similar to #94401 (comment) in OSS CI

cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 14, 2023

flatten_indices: remove syncs (#94401)

ba2442a

Pull Request resolved: pytorch/pytorch#94401 Approved by: https://github.com/cpuhrsch, https://github.com/pearu

malfet added a commit that referenced this pull request Mar 14, 2023

Fix signed-unsigned compare in FlattenIndicesCommon.h

51be8cc

One more regression from #94401

malfet mentioned this pull request Mar 14, 2023

Fix signed-unsigned compare in FlattenIndicesCommon.h #96765

Closed

pytorchmergebot pushed a commit that referenced this pull request Mar 14, 2023

Fix signed-unsigned compare in FlattenIndicesCommon.h (#96765)

da1489e

One more regression from #94401 Pull Request resolved: #96765 Approved by: https://github.com/izaitsevfb, https://github.com/Skylion007

facebook-github-bot deleted the gh/nikitaved/17/head branch June 8, 2023 18:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

flatten_indices: remove syncs#94401

flatten_indices: remove syncs#94401
nikitaved wants to merge 20 commits intogh/nikitaved/17/basefrom
gh/nikitaved/17/head

nikitaved commented Feb 8, 2023 •

edited

Loading

Uh oh!

pytorch-bot bot commented Feb 8, 2023 •

edited

Loading

Uh oh!

pearu left a comment

Uh oh!

pearu Feb 9, 2023

Uh oh!

nikitaved commented Mar 10, 2023

Uh oh!

pytorchmergebot commented Mar 10, 2023

Uh oh!

malfet commented Mar 13, 2023 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

nikitaved commented Feb 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Feb 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/94401

✅ No Failures

Uh oh!

pearu left a comment

Choose a reason for hiding this comment

Uh oh!

pearu Feb 9, 2023

Choose a reason for hiding this comment

Uh oh!

nikitaved commented Mar 10, 2023

Uh oh!

pytorchmergebot commented Mar 10, 2023

Merge started

Uh oh!

malfet commented Mar 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

nikitaved commented Feb 8, 2023 •

edited

Loading

pytorch-bot bot commented Feb 8, 2023 •

edited

Loading

malfet commented Mar 13, 2023 •

edited

Loading