[BE] Add regression test for aten shared build#96697
Closed
Conversation
To expose errors similar to #94401 (comment) in OSS CI
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/96697
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 FailuresAs of commit 939299a: NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
kit1980
approved these changes
Mar 14, 2023
Contributor
Author
|
@pytorchbot merge -f "BUCK failure is expected, to be fixed by #96696" |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 23, 2023
To expose errors similar to pytorch/pytorch#94401 (comment) in OSS CI Building `aten_cpu` as a shared library with `-Wl,--no-undefined` simulates behavior of Android NDK toolchain. Test plan: It should fail, see https://github.com/pytorch/pytorch/actions/runs/4410571970/jobs/7728232916#step:14:1386 Pull Request resolved: pytorch/pytorch#96697 Approved by: https://github.com/kit1980
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 27, 2023
To expose errors similar to pytorch/pytorch#94401 (comment) in OSS CI Building `aten_cpu` as a shared library with `-Wl,--no-undefined` simulates behavior of Android NDK toolchain. Test plan: It should fail, see https://github.com/pytorch/pytorch/actions/runs/4410571970/jobs/7728232916#step:14:1386 Pull Request resolved: pytorch/pytorch#96697 Approved by: https://github.com/kit1980
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To expose errors similar to #94401 (comment) in OSS CI
Building
aten_cpuas a shared library with-Wl,--no-undefinedsimulates behavior of Android NDK toolchain.Test plan: It should fail, see https://github.com/pytorch/pytorch/actions/runs/4410571970/jobs/7728232916#step:14:1386