[Sparse] Move SparseTensorUtils.* to native/#96696
Closed
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/96696
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ffac186: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
albanD
approved these changes
Mar 13, 2023
Collaborator
albanD
left a comment
There was a problem hiding this comment.
If CI is happy, I'm happy
7759e30 to
29697e6
Compare
29697e6 to
77f6474
Compare
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Collaborator
Merge failedReason: New commits were pushed while merging. Please rerun the merge command. Details for Dev Infra teamRaised by workflow job |
Contributor
Author
|
@pytorchbot merge -f "Builds are green" |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 23, 2023
Fixes internal linking problem after `DECLARE_DISPATCH` was introduced in SparseTensorUtils.cpp, but implemented inside the native library. Also, fix `sign-unsigned` compare in `_flatten_indices_impl` Followups: Move code declared/implemented in `SparseTensorUtils.*` to `at::native` namespace Pull Request resolved: pytorch/pytorch#96696 Approved by: https://github.com/albanD
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 27, 2023
Fixes internal linking problem after `DECLARE_DISPATCH` was introduced in SparseTensorUtils.cpp, but implemented inside the native library. Also, fix `sign-unsigned` compare in `_flatten_indices_impl` Followups: Move code declared/implemented in `SparseTensorUtils.*` to `at::native` namespace Pull Request resolved: pytorch/pytorch#96696 Approved by: https://github.com/albanD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes internal linking problem after
DECLARE_DISPATCHwas introduced in SparseTensorUtils.cpp, but implemented inside the native library.Also, fix
sign-unsignedcompare in_flatten_indices_implFollowups:
Move code declared/implemented in
SparseTensorUtils.*toat::nativenamespace