Fix signed-unsigned compare in FlattenIndicesCommon.h#96765
Closed
Fix signed-unsigned compare in FlattenIndicesCommon.h#96765
Conversation
One more regression from #94401
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/96765
Note: Links to docs will display an error until the docs builds have been completed. ❌ 5 FailuresAs of commit 51be8cc: BROKEN TRUNK - The following jobs failed but were present on the merge base 799521f:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
izaitsevfb
approved these changes
Mar 14, 2023
Skylion007
approved these changes
Mar 14, 2023
Contributor
Author
|
@pytorchbot merge -f "Lint + one of the builds is green" |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 23, 2023
One more regression from pytorch/pytorch#94401 Pull Request resolved: pytorch/pytorch#96765 Approved by: https://github.com/izaitsevfb, https://github.com/Skylion007
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 27, 2023
One more regression from pytorch/pytorch#94401 Pull Request resolved: pytorch/pytorch#96765 Approved by: https://github.com/izaitsevfb, https://github.com/Skylion007
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One more regression from #94401