Skip to content

sparse_mask: backward support for sparse lhs#95165

Closed
nikitaved wants to merge 45 commits intogh/nikitaved/25/basefrom
gh/nikitaved/25/head
Closed

sparse_mask: backward support for sparse lhs#95165
nikitaved wants to merge 45 commits intogh/nikitaved/25/basefrom
gh/nikitaved/25/head

Conversation

@nikitaved
Copy link
Copy Markdown
Collaborator

@nikitaved nikitaved commented Feb 20, 2023 •
edited
Loading

@nikitaved nikitaved mentioned this pull request Feb 20, 2023
Closed
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Feb 20, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/95165

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 95bbbde:

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@nikitaved nikitaved mentioned this pull request Feb 20, 2023
Closed
@pytorch-bot pytorch-bot bot added the release notes: sparse release notes category label Feb 20, 2023
This was referenced Feb 20, 2023
Closed
Closed
Closed
@nikitaved nikitaved added module: sparse Related to torch.sparse module: autograd Related to torch.autograd, and the autograd engine in general labels Feb 20, 2023
@nikitaved
Update on "sparse_mask: backward support for sparse lhs"
0a37c25 
cc alexsamardzic pearu cpuhrsch amjames bhosmer ezyang albanD zou3519 gqchen soulitzer Lezcano Varal7

[ghstack-poisoned]
nikitaved added a commit that referenced this pull request Feb 20, 2023
@nikitaved
sparse_mask: backward support for sparse lhs
b517c17 
ghstack-source-id: cb0ffb6
Pull Request resolved: #95165
@nikitaved
Update on "sparse_mask: backward support for sparse lhs"
e3f162f 
cc alexsamardzic pearu cpuhrsch amjames bhosmer ezyang albanD zou3519 gqchen soulitzer Lezcano Varal7

[ghstack-poisoned]
@nikitaved
Update on "sparse_mask: backward support for sparse lhs"
874d936 
cc alexsamardzic pearu cpuhrsch amjames bhosmer ezyang albanD zou3519 gqchen soulitzer Lezcano Varal7

[ghstack-poisoned]
nikitaved added a commit that referenced this pull request Feb 21, 2023
@nikitaved
sparse_mask: backward support for sparse lhs
5cda21c 
ghstack-source-id: 05b8031
Pull Request resolved: #95165
@nikitaved nikitaved added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 21, 2023
This was referenced Feb 27, 2023
Closed
Closed
@nikitaved
Update on "sparse_mask: backward support for sparse lhs"
159aae5 
cc alexsamardzic pearu cpuhrsch amjames bhosmer ezyang albanD zou3519 gqchen soulitzer Lezcano Varal7

[ghstack-poisoned]
@nikitaved
Update on "sparse_mask: backward support for sparse lhs"
924e27f 
cc alexsamardzic pearu cpuhrsch amjames bhosmer ezyang albanD zou3519 gqchen soulitzer Lezcano Varal7

[ghstack-poisoned]
nikitaved added a commit that referenced this pull request Mar 2, 2023
@nikitaved
sparse_mask: backward support for sparse lhs
7355cf5 
ghstack-source-id: 6f78859
Pull Request resolved: #95165
@nikitaved
Update on "sparse_mask: backward support for sparse lhs"
4df4b79 
cc alexsamardzic pearu cpuhrsch amjames bhosmer ezyang albanD zou3519 gqchen soulitzer Lezcano Varal7

[ghstack-poisoned]
@nikitaved nikitaved mentioned this pull request Mar 6, 2023
Closed
@nikitaved nikitaved closed this Jun 28, 2023
@nikitaved nikitaved mentioned this pull request Jun 28, 2023
Closed
nikitaved
nikitaved commented Jun 28, 2023
View reviewed changes
aten/src/ATen/native/sparse/SparseTensor.cpp
Comment on lines 707 to 709
if (t.is_coalesced()) {
return std::make_tuple(t, static_cast<OptTensor>(c10::nullopt));
return std::make_tuple(std::move(t), static_cast<OptTensor>(c10::nullopt));
} else {
Copy link
Copy Markdown
Collaborator Author

@nikitaved nikitaved Jun 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, all right, that does not look right to me...

nikitaved added a commit that referenced this pull request Jun 28, 2023
@nikitaved
Update base for Update on "sparse_mask: backward support for sparse l…
caf9b2f 
…hs (take 2)"

This is a copy of #95165 with some bug fixes.




cc alexsamardzic pearu cpuhrsch amjames bhosmer ezyang albanD zou3519 gqchen soulitzer Lezcano Varal7

[ghstack-poisoned]
nikitaved added a commit that referenced this pull request Jun 28, 2023
@nikitaved
Update on "sparse_mask: backward support for sparse lhs (take 2)"
d97c6ea 
This is a copy of #95165 with some bug fixes.




cc alexsamardzic pearu cpuhrsch amjames bhosmer ezyang albanD zou3519 gqchen soulitzer Lezcano Varal7

[ghstack-poisoned]
nikitaved added a commit that referenced this pull request Jun 28, 2023
@nikitaved
Update base for Update on "sparse_mask: backward support for sparse l…
03df4d1 
…hs (take 2)"

This is a copy of #95165 with some bug fixes.




cc alexsamardzic pearu cpuhrsch amjames bhosmer ezyang albanD zou3519 gqchen soulitzer Lezcano Varal7

[ghstack-poisoned]
nikitaved added a commit that referenced this pull request Jun 28, 2023
@nikitaved
Update on "sparse_mask: backward support for sparse lhs (take 2)"
a40acbc 
This is a copy of #95165 with some bug fixes.




cc alexsamardzic pearu cpuhrsch amjames bhosmer ezyang albanD zou3519 gqchen soulitzer Lezcano Varal7

[ghstack-poisoned]
nikitaved added a commit that referenced this pull request Jun 28, 2023
@nikitaved
Update base for Update on "sparse_mask: backward support for sparse l…
8c88382 
…hs (take 2)"

This is a copy of #95165 with some bug fixes.




cc alexsamardzic pearu cpuhrsch amjames bhosmer ezyang albanD zou3519 gqchen soulitzer Lezcano Varal7

[ghstack-poisoned]
nikitaved added a commit that referenced this pull request Jun 28, 2023
@nikitaved
Update on "sparse_mask: backward support for sparse lhs (take 2)"
d82a1af 
This is a copy of #95165 with some bug fixes.




cc alexsamardzic pearu cpuhrsch amjames bhosmer ezyang albanD zou3519 gqchen soulitzer Lezcano Varal7

[ghstack-poisoned]
nikitaved added a commit that referenced this pull request Jun 28, 2023
@nikitaved
Update base for Update on "sparse_mask: backward support for sparse l…
a78e4b8 
…hs (take 2)"

This is a copy of #95165 with some bug fixes.




cc alexsamardzic pearu cpuhrsch amjames bhosmer ezyang albanD zou3519 gqchen soulitzer Lezcano Varal7

[ghstack-poisoned]
nikitaved added a commit that referenced this pull request Jun 28, 2023
@nikitaved
Update on "sparse_mask: backward support for sparse lhs (take 2)"
b90c8af 
This is a copy of #95165 with some bug fixes.




cc alexsamardzic pearu cpuhrsch amjames bhosmer ezyang albanD zou3519 gqchen soulitzer Lezcano Varal7

[ghstack-poisoned]
@amjames amjames reopened this Jun 28, 2023
nikitaved added a commit that referenced this pull request Jun 29, 2023
@nikitaved
Update base for Update on "sparse_mask: backward support for sparse l…
57d0250 
…hs (take 2)"

This is a copy of #95165 with some bug fixes.




cc alexsamardzic pearu cpuhrsch amjames bhosmer ezyang albanD zou3519 gqchen soulitzer Lezcano Varal7

[ghstack-poisoned]
nikitaved added a commit that referenced this pull request Jun 29, 2023
@nikitaved
Update on "sparse_mask: backward support for sparse lhs (take 2)"
923fe66 
This is a copy of #95165 with some bug fixes.




cc alexsamardzic pearu cpuhrsch amjames bhosmer ezyang albanD zou3519 gqchen soulitzer Lezcano Varal7

[ghstack-poisoned]
nikitaved added a commit that referenced this pull request Jun 29, 2023
@nikitaved
Update base for Update on "sparse_mask: backward support for sparse l…
8383a50 
…hs (take 2)"

This is a copy of #95165 with some bug fixes.




cc alexsamardzic pearu cpuhrsch amjames bhosmer ezyang albanD zou3519 gqchen soulitzer Lezcano Varal7

[ghstack-poisoned]
nikitaved added a commit that referenced this pull request Jun 29, 2023
@nikitaved
Update on "sparse_mask: backward support for sparse lhs (take 2)"
7e61080 
This is a copy of #95165 with some bug fixes.




cc alexsamardzic pearu cpuhrsch amjames bhosmer ezyang albanD zou3519 gqchen soulitzer Lezcano Varal7

[ghstack-poisoned]
@amjames
Copy link
Copy Markdown
Collaborator

amjames commented Jun 29, 2023

Superseded by #104341

@amjames amjames closed this Jun 29, 2023
nikitaved added a commit that referenced this pull request Jun 29, 2023
@nikitaved
Update base for Update on "sparse_mask: backward support for sparse l…
6920fbf 
…hs (take 2)"

This is a copy of #95165 with some bug fixes.




cc alexsamardzic pearu cpuhrsch amjames bhosmer ezyang albanD zou3519 gqchen soulitzer Lezcano Varal7

[ghstack-poisoned]
nikitaved added a commit that referenced this pull request Jun 29, 2023
@nikitaved
Update on "sparse_mask: backward support for sparse lhs (take 2)"
1998e5e 
This is a copy of #95165 with some bug fixes.




cc alexsamardzic pearu cpuhrsch amjames bhosmer ezyang albanD zou3519 gqchen soulitzer Lezcano Varal7

[ghstack-poisoned]
nikitaved added a commit that referenced this pull request Jun 29, 2023
@nikitaved
Update base for Update on "sparse_mask: backward support for sparse l…
64d838b 
…hs (take 2)"

This is a copy of #95165 with some bug fixes.




cc alexsamardzic pearu cpuhrsch amjames bhosmer ezyang albanD zou3519 gqchen soulitzer Lezcano Varal7

[ghstack-poisoned]
nikitaved added a commit that referenced this pull request Jun 29, 2023
@nikitaved
Update on "sparse_mask: backward support for sparse lhs (take 2)"
c100711 
This is a copy of #95165 with some bug fixes.




cc alexsamardzic pearu cpuhrsch amjames bhosmer ezyang albanD zou3519 gqchen soulitzer Lezcano Varal7

[ghstack-poisoned]
nikitaved added a commit that referenced this pull request Jun 29, 2023
@nikitaved
Update base for Update on "sparse_mask: backward support for sparse l…
9cc4b8b 
…hs (take 2)"

This is a copy of #95165 with some bug fixes.




cc alexsamardzic pearu cpuhrsch amjames bhosmer ezyang albanD zou3519 gqchen soulitzer Lezcano Varal7

[ghstack-poisoned]
nikitaved added a commit that referenced this pull request Jun 29, 2023
@nikitaved
Update on "sparse_mask: backward support for sparse lhs (take 2)"
b50c0c3 
This is a copy of #95165 with some bug fixes.




cc alexsamardzic pearu cpuhrsch amjames bhosmer ezyang albanD zou3519 gqchen soulitzer Lezcano Varal7

[ghstack-poisoned]
nikitaved added a commit that referenced this pull request Jun 29, 2023
@nikitaved
Update base for Update on "sparse_mask: backward support for sparse l…
8169d2a 
…hs (take 2)"

This is a copy of #95165 with some bug fixes.




cc alexsamardzic pearu cpuhrsch amjames bhosmer ezyang albanD zou3519 gqchen soulitzer Lezcano Varal7

[ghstack-poisoned]
nikitaved added a commit that referenced this pull request Jun 29, 2023
@nikitaved
Update on "sparse_mask: backward support for sparse lhs (take 2)"
38020ad 
This is a copy of #95165 with some bug fixes.




cc alexsamardzic pearu cpuhrsch amjames bhosmer ezyang albanD zou3519 gqchen soulitzer Lezcano Varal7

[ghstack-poisoned]
nikitaved added a commit that referenced this pull request Jun 30, 2023
@nikitaved
Update base for Update on "sparse_mask: backward support for sparse l…
d36d39e 
…hs (take 2)"

This is a copy of #95165 with some bug fixes.




cc alexsamardzic pearu cpuhrsch amjames bhosmer ezyang albanD zou3519 gqchen soulitzer Lezcano Varal7

[ghstack-poisoned]
nikitaved added a commit that referenced this pull request Jun 30, 2023
@nikitaved
Update on "sparse_mask: backward support for sparse lhs (take 2)"
e51deb0 
This is a copy of #95165 with some bug fixes.




cc alexsamardzic pearu cpuhrsch amjames bhosmer ezyang albanD zou3519 gqchen soulitzer Lezcano Varal7

[ghstack-poisoned]
nikitaved added a commit that referenced this pull request Jun 30, 2023
@nikitaved
Update base for Update on "sparse_mask: backward support for sparse l…
215e27b 
…hs (take 2)"

This is a copy of #95165 with some bug fixes.




cc alexsamardzic pearu cpuhrsch amjames bhosmer ezyang albanD zou3519 gqchen soulitzer Lezcano Varal7

[ghstack-poisoned]
nikitaved added a commit that referenced this pull request Jun 30, 2023
@nikitaved
Update on "sparse_mask: backward support for sparse lhs (take 2)"
9c5f7c3 
This is a copy of #95165 with some bug fixes.




cc alexsamardzic pearu cpuhrsch amjames bhosmer ezyang albanD zou3519 gqchen soulitzer Lezcano Varal7

[ghstack-poisoned]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pearu pearu pearu approved these changes

@cpuhrsch cpuhrsch cpuhrsch approved these changes

@albanD albanD Awaiting requested review from albanD albanD is a code owner

@soulitzer soulitzer Awaiting requested review from soulitzer soulitzer is a code owner

@amjames amjames Awaiting requested review from amjames amjames is a code owner

Assignees

No one assigned

Labels

ciflow/slow ciflow/trunk Trigger trunk jobs on your pull request Merged module: autograd Related to torch.autograd, and the autograd engine in general module: sparse Related to torch.sparse open source release notes: sparse release notes category Reverted topic: new features topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@nikitaved @pytorchmergebot @cpuhrsch @huydhn @amjames @pearu @pytorchbot