Skip to content

sparse.sum backward: fix gradient projection#99298

Closed
nikitaved wants to merge 38 commits intogh/nikitaved/39/basefrom
gh/nikitaved/39/head
Closed

sparse.sum backward: fix gradient projection#99298
nikitaved wants to merge 38 commits intogh/nikitaved/39/basefrom
gh/nikitaved/39/head

Conversation

@nikitaved
Copy link
Copy Markdown
Collaborator

@nikitaved nikitaved commented Apr 17, 2023 •
edited
Loading

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Apr 17, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/99298

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 4995cce:

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@nikitaved nikitaved mentioned this pull request Apr 17, 2023
Closed
@pytorch-bot pytorch-bot bot added the release notes: sparse release notes category label Apr 17, 2023
This was referenced Apr 17, 2023
Closed
Closed
Closed
Closed
Closed
@nikitaved nikitaved added module: sparse Related to torch.sparse module: autograd Related to torch.autograd, and the autograd engine in general labels Apr 17, 2023
@nikitaved
Update on "sparse.sum backward: fix gradient projection"
6257ed6 
Fixes #99147 temporarily. I believe we can reuse our intersection kernels to refactor the backward function and make it more performant.




cc alexsamardzic pearu cpuhrsch amjames bhosmer ezyang albanD zou3519 gqchen soulitzer Lezcano Varal7

[ghstack-poisoned]
nikitaved added a commit that referenced this pull request Apr 17, 2023
@nikitaved
sparse.sum backward: fix gradient projection
1864f55 
ghstack-source-id: 2ad1fce
Pull Request resolved: #99298
@nikitaved
Update on "sparse.sum backward: fix gradient projection"
cc28e2b 
Fixes #99147 temporarily. I believe we can reuse our intersection kernels to refactor the backward function and make it more performant.




cc alexsamardzic pearu cpuhrsch amjames bhosmer ezyang albanD zou3519 gqchen soulitzer Lezcano Varal7

[ghstack-poisoned]
nikitaved added a commit that referenced this pull request Apr 17, 2023
@nikitaved
sparse.sum backward: fix gradient projection
2a75ff1 
ghstack-source-id: a15f237
Pull Request resolved: #99298
@nikitaved
Update on "sparse.sum backward: fix gradient projection"
3f0f866 
Fixes #99147 temporarily. I believe we can reuse our intersection kernels to refactor the backward function and make it more performant.




cc alexsamardzic pearu cpuhrsch amjames bhosmer ezyang albanD zou3519 gqchen soulitzer Lezcano Varal7

[ghstack-poisoned]
nikitaved added a commit that referenced this pull request Apr 18, 2023
@nikitaved
sparse.sum backward: fix gradient projection
40dedde 
ghstack-source-id: 8a80fa8
Pull Request resolved: #99298
@nikitaved
Update on "sparse.sum backward: fix gradient projection"
b3fedad 
Fixes #99147 temporarily. I believe we can reuse our intersection kernels to refactor the backward function and make it more performant.




cc alexsamardzic pearu cpuhrsch amjames bhosmer ezyang albanD zou3519 gqchen soulitzer Lezcano Varal7

[ghstack-poisoned]
@nikitaved
Update on "sparse.sum backward: fix gradient projection"
c9e7e4b 
Fixes #99147 temporarily. I believe we can reuse our intersection kernels to refactor the backward function and make it more performant.




cc alexsamardzic pearu cpuhrsch amjames bhosmer ezyang albanD zou3519 gqchen soulitzer Lezcano Varal7

[ghstack-poisoned]
nikitaved added a commit that referenced this pull request Apr 19, 2023
@nikitaved
sparse.sum backward: fix gradient projection
b139bb6 
ghstack-source-id: adb584c
Pull Request resolved: #99298
@nikitaved
Update on "sparse.sum backward: fix gradient projection"
ff7f400 
Fixes #99147 temporarily. I believe we can reuse our intersection kernels to refactor the backward function and make it more performant.




cc alexsamardzic pearu cpuhrsch amjames bhosmer ezyang albanD zou3519 gqchen soulitzer Lezcano Varal7

[ghstack-poisoned]
@nikitaved
Update on "sparse.sum backward: fix gradient projection"
60d0043 
Fixes #99147 temporarily. I believe we can reuse our intersection kernels to refactor the backward function and make it more performant.




cc alexsamardzic pearu cpuhrsch amjames bhosmer ezyang albanD zou3519 gqchen soulitzer Lezcano Varal7

[ghstack-poisoned]
nikitaved added a commit that referenced this pull request Apr 20, 2023
@nikitaved
sparse.sum backward: fix gradient projection
cb2daea 
ghstack-source-id: 3084d9c
Pull Request resolved: #99298
@nikitaved
Update on "sparse.sum backward: fix gradient projection"
c293eaf 
Fixes #99147 temporarily. I believe we can reuse our intersection kernels to refactor the backward function and make it more performant.




cc alexsamardzic pearu cpuhrsch amjames bhosmer ezyang albanD zou3519 gqchen soulitzer Lezcano Varal7

[ghstack-poisoned]
nikitaved added a commit that referenced this pull request Apr 21, 2023
@nikitaved
sparse.sum backward: fix gradient projection
ef37cba 
ghstack-source-id: 8ce31ec
Pull Request resolved: #99298
@nikitaved
Update on "sparse.sum backward: fix gradient projection"
e014182 
Fixes #99147 temporarily. I believe we can reuse our intersection kernels to refactor the backward function and make it more performant.




cc alexsamardzic pearu cpuhrsch amjames bhosmer ezyang albanD zou3519 gqchen soulitzer Lezcano Varal7

[ghstack-poisoned]
@nikitaved
Update on "sparse.sum backward: fix gradient projection"
91f4cb0 
Fixes #99147 temporarily. I believe we can reuse our intersection kernels to refactor the backward function and make it more performant.




cc alexsamardzic pearu cpuhrsch amjames bhosmer ezyang albanD zou3519 gqchen soulitzer Lezcano Varal7

[ghstack-poisoned]
@nikitaved
Update on "sparse.sum backward: fix gradient projection"
958b426 
Fixes #99147 temporarily. I believe we can reuse our intersection kernels to refactor the backward function and make it more performant.




cc alexsamardzic pearu cpuhrsch amjames bhosmer ezyang albanD zou3519 gqchen soulitzer Lezcano Varal7

[ghstack-poisoned]
@nikitaved
Update on "sparse.sum backward: fix gradient projection"
23d18e3 
Fixes #99147 temporarily. I believe we can reuse our intersection kernels to refactor the backward function and make it more performant.




cc alexsamardzic pearu cpuhrsch amjames bhosmer ezyang albanD zou3519 gqchen soulitzer Lezcano Varal7

[ghstack-poisoned]
@nikitaved
Update on "sparse.sum backward: fix gradient projection"
6df4a9f 
Fixes #99147 temporarily. I believe we can reuse our intersection kernels to refactor the backward function and make it more performant.




cc alexsamardzic pearu cpuhrsch amjames bhosmer ezyang albanD zou3519 gqchen soulitzer Lezcano Varal7

[ghstack-poisoned]
@nikitaved
Update on "sparse.sum backward: fix gradient projection"
9f682cd 
Fixes #99147 temporarily. I believe we can reuse our intersection kernels to refactor the backward function and make it more performant.




cc alexsamardzic pearu cpuhrsch amjames bhosmer ezyang albanD zou3519 gqchen soulitzer Lezcano Varal7

[ghstack-poisoned]
@nikitaved
Update on "sparse.sum backward: fix gradient projection"
530185a 
Fixes #99147 temporarily. I believe we can reuse our intersection kernels to refactor the backward function and make it more performant.




cc alexsamardzic pearu cpuhrsch amjames bhosmer ezyang albanD zou3519 gqchen soulitzer Lezcano Varal7

[ghstack-poisoned]
@nikitaved
Update on "sparse.sum backward: fix gradient projection"
fc72448 
Fixes #99147 temporarily. I believe we can reuse our intersection kernels to refactor the backward function and make it more performant.




cc alexsamardzic pearu cpuhrsch amjames bhosmer ezyang albanD zou3519 gqchen soulitzer Lezcano Varal7

[ghstack-poisoned]
@nikitaved
Update on "sparse.sum backward: fix gradient projection"
eea2a41 
Fixes #99147 temporarily. I believe we can reuse our intersection kernels to refactor the backward function and make it more performant.




cc alexsamardzic pearu cpuhrsch amjames bhosmer ezyang albanD zou3519 gqchen soulitzer Lezcano Varal7

[ghstack-poisoned]
@nikitaved
Update on "sparse.sum backward: fix gradient projection"
1d38381 
Fixes #99147 temporarily. I believe we can reuse our intersection kernels to refactor the backward function and make it more performant.




cc alexsamardzic pearu cpuhrsch amjames bhosmer ezyang albanD zou3519 gqchen soulitzer Lezcano Varal7

[ghstack-poisoned]
@nikitaved
Update on "sparse.sum backward: fix gradient projection"
ff534b4 
Fixes #99147 temporarily. I believe we can reuse our intersection kernels to refactor the backward function and make it more performant.




cc alexsamardzic pearu cpuhrsch amjames bhosmer ezyang albanD zou3519 gqchen soulitzer Lezcano Varal7

[ghstack-poisoned]
@nikitaved
Update on "sparse.sum backward: fix gradient projection"
3f27118 
Fixes #99147 temporarily. I believe we can reuse our intersection kernels to refactor the backward function and make it more performant.




cc alexsamardzic pearu cpuhrsch amjames bhosmer ezyang albanD zou3519 gqchen soulitzer Lezcano Varal7

[ghstack-poisoned]
@nikitaved
Update on "sparse.sum backward: fix gradient projection"
7138e54 
Fixes #99147 temporarily. I believe we can reuse our intersection kernels to refactor the backward function and make it more performant.




cc alexsamardzic pearu cpuhrsch amjames bhosmer ezyang albanD zou3519 gqchen soulitzer Lezcano Varal7

[ghstack-poisoned]
nikitaved added a commit that referenced this pull request Jun 30, 2023
@nikitaved
sparse.sum backward: fix gradient projection
4c9b2d5 
ghstack-source-id: e921e93
Pull Request resolved: #99298
@nikitaved
Update on "sparse.sum backward: fix gradient projection"
4995cce 
Fixes #99147 temporarily. I believe we can reuse our intersection kernels to refactor the backward function and make it more performant.




cc alexsamardzic pearu cpuhrsch amjames bhosmer ezyang albanD zou3519 gqchen soulitzer Lezcano Varal7

[ghstack-poisoned]
nikitaved added a commit that referenced this pull request Jul 3, 2023
@nikitaved
sparse.sum backward: fix gradient projection
8bf7f1f 
ghstack-source-id: d720c3e
Pull Request resolved: #99298
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 1, 2023

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Sep 1, 2023
@github-actions github-actions bot closed this Oct 1, 2023
@facebook-github-bot facebook-github-bot deleted the gh/nikitaved/39/head branch November 1, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

module: autograd Related to torch.autograd, and the autograd engine in general module: sparse Related to torch.sparse open source release notes: sparse release notes category Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nikitaved @pytorchbot