enable NVFuser by default by davidberard98 · Pull Request #77213 · pytorch/pytorch

davidberard98 · 2022-05-11T01:03:08Z

Stack from ghstack:

-> enable NVFuser by default #77213

Enable NVFuser in OSS.

Tests are passing, and we've also run tests in torchvision and torchaudio

Retry of #76006, because that PR had GH1/ghstack issues.

Differential Revision: D36302686

Enable NVFuser in OSS. Tests are passing, and we've also run tests in [torchvision](pytorch/vision#5959) and [torchaudio](pytorch/audio#2372) Retry of #76006, because that PR had GH1/ghstack issues. [ghstack-poisoned]

facebook-github-bot · 2022-05-11T01:03:14Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/77213
📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓Need help or want to give feedback on the CI? Visit our office hours
↩️ [fb-only] Re-run with SSH instructions

❌ 1 New Failures

As of commit 7ea37f5 (more details on the Dr. CI page):

Expand to see more

1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages

pull / pytorch-xla-linux-bionic-py3.7-clang8 / test (xla, 1, 1, linux.2xlarge) (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-05-11T02:43:36.4578560Z /var/lib/jenkins/w... virtual member functions can be marked 'override'

2022-05-11T02:43:36.4572768Z In file included from /var/lib/jenkins/workspace/xla/torch_xla/csrc/aten_xla_bridge.cpp:11:
2022-05-11T02:43:36.4573618Z /var/lib/jenkins/workspace/xla/torch_xla/csrc/tensor_impl.h:33:40: error: only virtual member functions can be marked 'override'
2022-05-11T02:43:36.4574228Z   at::IntArrayRef sizes_custom() const override;
2022-05-11T02:43:36.4574613Z                                        ^~~~~~~~
2022-05-11T02:43:36.4575324Z /var/lib/jenkins/workspace/xla/torch_xla/csrc/tensor_impl.h:34:42: error: only virtual member functions can be marked 'override'
2022-05-11T02:43:36.4575894Z   at::IntArrayRef strides_custom() const override;
2022-05-11T02:43:36.4576276Z                                          ^~~~~~~~
2022-05-11T02:43:36.4577012Z /var/lib/jenkins/workspace/xla/torch_xla/csrc/tensor_impl.h:36:30: error: only virtual member functions can be marked 'override'
2022-05-11T02:43:36.4577540Z   int64_t dim_custom() const override;
2022-05-11T02:43:36.4577854Z                              ^~~~~~~~
2022-05-11T02:43:36.4578560Z /var/lib/jenkins/workspace/xla/torch_xla/csrc/tensor_impl.h:38:32: error: only virtual member functions can be marked 'override'
2022-05-11T02:43:36.4579083Z   int64_t numel_custom() const override;
2022-05-11T02:43:36.4579391Z                                ^~~~~~~~
2022-05-11T02:43:36.4579680Z 4 errors generated.
2022-05-11T02:43:37.5397990Z [10/179] clang++-8 -MMD -MF /var/lib/jenkins/workspace/xla/build/temp.linux-x86_64-3.7/torch_xla/csrc/convert_ops.o.d -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -D_GLIBCXX_USE_CXX11_ABI=1 -fPIC -I/var/lib/jenkins/workspace/xla -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-bin -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/protobuf_archive/src -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/com_google_protobuf/src -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/eigen_archive -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/com_google_absl -I/var/lib/jenkins/workspace -I/var/lib/jenkins/workspace/torch/csrc -I/var/lib/jenkins/workspace/torch/lib/tmp_install/include -I/opt/conda/lib/python3.7/site-packages/torch/include -I/opt/conda/lib/python3.7/site-packages/torch/include/torch/csrc/api/include -I/opt/conda/lib/python3.7/site-packages/torch/include/TH -I/opt/conda/lib/python3.7/site-packages/torch/include/THC -I/opt/conda/include/python3.7m -c -c /var/lib/jenkins/workspace/xla/torch_xla/csrc/convert_ops.cpp -o /var/lib/jenkins/workspace/xla/build/temp.linux-x86_64-3.7/torch_xla/csrc/convert_ops.o -std=c++14 -Wno-sign-compare -Wno-deprecated-declarations -Wno-return-type -Wno-macro-redefined -Wno-return-std-move -DNDEBUG -DTORCH_API_INCLUDE_EXTENSION_H '-DPYBIND11_COMPILER_TYPE="_clang"' '-DPYBIND11_STDLIB="_libstdcpp"' '-DPYBIND11_BUILD_ABI="_cxxabi1002"' -DTORCH_EXTENSION_NAME=_XLAC -D_GLIBCXX_USE_CXX11_ABI=1
2022-05-11T02:43:41.8314778Z [11/179] clang++-8 -MMD -MF /var/lib/jenkins/workspace/xla/build/temp.linux-x86_64-3.7/torch_xla/csrc/convolution.o.d -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -D_GLIBCXX_USE_CXX11_ABI=1 -fPIC -I/var/lib/jenkins/workspace/xla -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-bin -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/protobuf_archive/src -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/com_google_protobuf/src -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/eigen_archive -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/com_google_absl -I/var/lib/jenkins/workspace -I/var/lib/jenkins/workspace/torch/csrc -I/var/lib/jenkins/workspace/torch/lib/tmp_install/include -I/opt/conda/lib/python3.7/site-packages/torch/include -I/opt/conda/lib/python3.7/site-packages/torch/include/torch/csrc/api/include -I/opt/conda/lib/python3.7/site-packages/torch/include/TH -I/opt/conda/lib/python3.7/site-packages/torch/include/THC -I/opt/conda/include/python3.7m -c -c /var/lib/jenkins/workspace/xla/torch_xla/csrc/convolution.cpp -o /var/lib/jenkins/workspace/xla/build/temp.linux-x86_64-3.7/torch_xla/csrc/convolution.o -std=c++14 -Wno-sign-compare -Wno-deprecated-declarations -Wno-return-type -Wno-macro-redefined -Wno-return-std-move -DNDEBUG -DTORCH_API_INCLUDE_EXTENSION_H '-DPYBIND11_COMPILER_TYPE="_clang"' '-DPYBIND11_STDLIB="_libstdcpp"' '-DPYBIND11_BUILD_ABI="_cxxabi1002"' -DTORCH_EXTENSION_NAME=_XLAC -D_GLIBCXX_USE_CXX11_ABI=1
2022-05-11T02:44:05.0047551Z [12/179] clang++-8 -MMD -MF /var/lib/jenkins/workspace/xla/build/temp.linux-x86_64-3.7/torch_xla/csrc/RegisterXLA.o.d -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -D_GLIBCXX_USE_CXX11_ABI=1 -fPIC -I/var/lib/jenkins/workspace/xla -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-bin -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/protobuf_archive/src -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/com_google_protobuf/src -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/eigen_archive -I/var/lib/jenkins/workspace/xla/third_party/tensorflow/bazel-tensorflow/external/com_google_absl -I/var/lib/jenkins/workspace -I/var/lib/jenkins/workspace/torch/csrc -I/var/lib/jenkins/workspace/torch/lib/tmp_install/include -I/opt/conda/lib/python3.7/site-packages/torch/include -I/opt/conda/lib/python3.7/site-packages/torch/include/torch/csrc/api/include -I/opt/conda/lib/python3.7/site-packages/torch/include/TH -I/opt/conda/lib/python3.7/site-packages/torch/include/THC -I/opt/conda/include/python3.7m -c -c /var/lib/jenkins/workspace/xla/torch_xla/csrc/RegisterXLA.cpp -o /var/lib/jenkins/workspace/xla/build/temp.linux-x86_64-3.7/torch_xla/csrc/RegisterXLA.o -std=c++14 -Wno-sign-compare -Wno-deprecated-declarations -Wno-return-type -Wno-macro-redefined -Wno-return-std-move -DNDEBUG -DTORCH_API_INCLUDE_EXTENSION_H '-DPYBIND11_COMPILER_TYPE="_clang"' '-DPYBIND11_STDLIB="_libstdcpp"' '-DPYBIND11_BUILD_ABI="_cxxabi1002"' -DTORCH_EXTENSION_NAME=_XLAC -D_GLIBCXX_USE_CXX11_ABI=1
2022-05-11T02:44:05.0052025Z /var/lib/jenkins/workspace/xla/torch_xla/csrc/RegisterXLA.cpp:63:6: warning: unused function 'resize_out' [-Wunused-function]
2022-05-11T02:44:05.0052836Z void resize_out(const Tensor &out, IntArrayRef sizes, IntArrayRef strides, const TensorOptions &options) {
2022-05-11T02:44:05.0053398Z      ^
2022-05-11T02:44:05.0054194Z /var/lib/jenkins/workspace/xla/torch_xla/csrc/RegisterXLA.cpp:82:6: warning: unused function 'check_inplace' [-Wunused-function]

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

Enable NVFuser in OSS. Tests are passing, and we've also run tests in [torchvision](pytorch/vision#5959) and [torchaudio](pytorch/audio#2372) Retry of #76006, because that PR had GH1/ghstack issues. ghstack-source-id: b1c68c1 Pull Request resolved: #77213

davidberard98 · 2022-05-11T01:03:48Z

@davidberard98 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

davidberard98 · 2022-05-11T19:57:53Z

@pytorchbot merge this please

github-actions · 2022-05-11T20:00:07Z

Hey @davidberard98.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

Summary: Enable NVFuser in OSS. Tests are passing, and we've also run tests in [torchvision](pytorch/vision#5959) and [torchaudio](pytorch/audio#2372) Retry of #76006, because that PR had GH1/ghstack issues. Pull Request resolved: #77213 Approved by: https://github.com/eellison Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/24f7dcd8161544fc55a19e3b471bd95d37f9ec18 Reviewed By: H-Huang Differential Revision: D36302686 Pulled By: H-Huang fbshipit-source-id: 2c380e46d8a532dfe0f52fb28d24ca310ffbc43a

davidberard98 · 2022-05-16T18:22:04Z

@pytorchbot revert this because it is breaking torchvision tests in pytorch/vision#6015

This reverts commit 24f7dcd. Reverted #77213 on behalf of https://github.com/davidberard98

@jjsjann123

Enable NVFuser in OSS. Retry of #77213, because it was breaking torchvision tests. Fix in #77471 has been verified by @jjsjann123 [ghstack-poisoned]

Enable NVFuser in OSS. Retry of #77213, because it was breaking torchvision tests. Fix in #77471 has been verified by jjsjann123 ghstack-source-id: 642e7cf Pull Request resolved: #77579

Summary: This reverts commit 24f7dcd. Reverted #77213 on behalf of https://github.com/davidberard98 Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/2a905aef097feb5695d53f8d4de9da12068b90dd Reviewed By: atalman Differential Revision: D36421612 fbshipit-source-id: 0a8670f7bc9ba9722f4efc6f0811575318abbb71

Enable NVFuser in OSS. Retry of #77213, because it was breaking torchvision tests. Fix in #77471 has been verified by jjsjann123 Pull Request resolved: #77579 Approved by: https://github.com/eellison, https://github.com/malfet, https://github.com/atalman, https://github.com/seemethere

Summary: Enable NVFuser in OSS. Retry of #77213, because it was breaking torchvision tests. Fix in #77471 has been verified by jjsjann123 Pull Request resolved: #77579 Approved by: https://github.com/eellison, https://github.com/malfet, https://github.com/atalman, https://github.com/seemethere Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/38bc10ae25c6fd2f445926fdee148ac19a4a1c08 Reviewed By: seemethere Differential Revision: D36552636 Pulled By: seemethere fbshipit-source-id: 3ee5eb9ad5ee2638ef75105a366d90db54b0b436

Enable NVFuser in OSS. Tests are passing, and we've also run tests in [torchvision](pytorch/vision#5959) and [torchaudio](pytorch/audio#2372) Retry of #76006, because that PR had GH1/ghstack issues. Pull Request resolved: pytorch/pytorch#77213 Approved by: https://github.com/eellison

This reverts commit b15b354. Reverted pytorch/pytorch#77213 on behalf of https://github.com/davidberard98

Enable NVFuser in OSS. Tests are passing, and we've also run tests in [torchvision](pytorch/vision#5959) and [torchaudio](pytorch/audio#2372) Retry of #76006, because that PR had GH1/ghstack issues. Pull Request resolved: pytorch/pytorch#77213 Approved by: https://github.com/eellison

This reverts commit 4b14426. Reverted pytorch/pytorch#77213 on behalf of https://github.com/davidberard98

Enable NVFuser in OSS. Tests are passing, and we've also run tests in [torchvision](pytorch/vision#5959) and [torchaudio](pytorch/audio#2372) Retry of pytorch#76006, because that PR had GH1/ghstack issues. Pull Request resolved: pytorch#77213 Approved by: https://github.com/eellison

This reverts commit 660ca81. Reverted pytorch#77213 on behalf of https://github.com/davidberard98

Enable NVFuser in OSS. Retry of pytorch#77213, because it was breaking torchvision tests. Fix in pytorch#77471 has been verified by jjsjann123 Pull Request resolved: pytorch#77579 Approved by: https://github.com/eellison, https://github.com/malfet, https://github.com/atalman, https://github.com/seemethere

enable NVFuser by default

7ea37f5

Enable NVFuser in OSS. Tests are passing, and we've also run tests in [torchvision](pytorch/vision#5959) and [torchaudio](pytorch/audio#2372) Retry of #76006, because that PR had GH1/ghstack issues. [ghstack-poisoned]

facebook-github-bot added the cla signed label May 11, 2022

facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label May 11, 2022

davidberard98 mentioned this pull request May 11, 2022

enable NVFuser by default #76006

Closed

davidberard98 requested review from eellison and jjsjann123 May 11, 2022 16:05

eellison approved these changes May 11, 2022

View reviewed changes

pytorchmergebot added the Merged label May 11, 2022

pytorchmergebot closed this in 24f7dcd May 11, 2022

davidberard98 mentioned this pull request May 12, 2022

test_broadcast_in_dim_cuda_float32 (__main__.TestPrimsCUDA) error #77236

Closed

facebook-github-bot deleted the gh/davidberard98/112/head branch May 15, 2022 14:17

pytorchmergebot added a commit that referenced this pull request May 16, 2022

Revert "enable NVFuser by default"

2a905ae

This reverts commit 24f7dcd. Reverted #77213 on behalf of https://github.com/davidberard98

pytorchmergebot added the Reverted label May 16, 2022

davidberard98 added a commit that referenced this pull request May 16, 2022

retry - enable NVFuser by default

34a3e82

Enable NVFuser in OSS. Retry of #77213, because it was breaking torchvision tests. Fix in #77471 has been verified by @jjsjann123 [ghstack-poisoned]

davidberard98 mentioned this pull request May 16, 2022

retry - enable NVFuser by default #77579

Closed

datumbox mentioned this pull request May 17, 2022

temporaily disable nvfuser pytorch/vision#6029

Closed

jjsjann123 pushed a commit to jjsjann123/nvfuser that referenced this pull request Oct 29, 2022

Revert "enable NVFuser by default"

77120de

This reverts commit b15b354. Reverted pytorch/pytorch#77213 on behalf of https://github.com/davidberard98

jjsjann123 pushed a commit to jjsjann123/nvfuser that referenced this pull request Nov 10, 2022

Revert "enable NVFuser by default"

a71c589

This reverts commit 4b14426. Reverted pytorch/pytorch#77213 on behalf of https://github.com/davidberard98

laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 25, 2026

Revert "enable NVFuser by default"

c5d4843

This reverts commit 660ca81. Reverted pytorch#77213 on behalf of https://github.com/davidberard98

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

enable NVFuser by default#77213

enable NVFuser by default#77213
davidberard98 wants to merge 1 commit intogh/davidberard98/112/basefrom
gh/davidberard98/112/head

davidberard98 commented May 11, 2022 •

edited

Loading

Uh oh!

facebook-github-bot commented May 11, 2022 •

edited

Loading

🕵️ 1 new failure recognized by patterns

pull / pytorch-xla-linux-bionic-py3.7-clang8 / test (xla, 1, 1, linux.2xlarge) (1/1)

Uh oh!

davidberard98 commented May 11, 2022

Uh oh!

davidberard98 commented May 11, 2022

Uh oh!

github-actions Bot commented May 11, 2022

Uh oh!

davidberard98 commented May 16, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

davidberard98 commented May 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented May 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

❌ 1 New Failures

🕵️ 1 new failure recognized by patterns

pull / pytorch-xla-linux-bionic-py3.7-clang8 / test (xla, 1, 1, linux.2xlarge) (1/1)

Uh oh!

davidberard98 commented May 11, 2022

Uh oh!

davidberard98 commented May 11, 2022

Uh oh!

github-actions Bot commented May 11, 2022

Uh oh!

davidberard98 commented May 16, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

davidberard98 commented May 11, 2022 •

edited

Loading

facebook-github-bot commented May 11, 2022 •

edited

Loading