enable NVFuser by default#76006
enable NVFuser by default#76006davidberard98 wants to merge 21 commits intogh/davidberard98/97/basefrom
Conversation
Testing to see what breaks [ghstack-poisoned]
🔗 Helpful links
❌ 1 New FailuresAs of commit ad73bd7 (more details on the Dr. CI page): Expand to see more
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages
|
Testing to see what breaks [ghstack-poisoned]
|
@davidberard98 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
cc @jjsjann123 did you have a plan on how to flip the switch? I was trying to test it here, but looks like this strategy doesn't work (I think it's due to static initialization order where CUDAHooks needs to get registered before at::globakContext().hasCUDA() will work in cuda_graph_fuser.h) Do you have another idea on how to do this? I think we could probably try to wrap the registration in some functions and call the functions to enforce registration order... but not sure if there's a nicer way to do it |
Testing to see what breaks Differential Revision: [D35736977](https://our.internmc.facebook.com/intern/diff/D35736977) [ghstack-poisoned]
Testing to see what breaks Differential Revision: [D35736977](https://our.internmc.facebook.com/intern/diff/D35736977) [ghstack-poisoned]
Testing to see what breaks Differential Revision: [D35736977](https://our.internmc.facebook.com/intern/diff/D35736977) [ghstack-poisoned]
Testing to see what breaks Differential Revision: [D35736977](https://our.internmc.facebook.com/intern/diff/D35736977) [ghstack-poisoned]
Testing to see what breaks Differential Revision: [D35736977](https://our.internmc.facebook.com/intern/diff/D35736977) [ghstack-poisoned]
Testing to see what breaks Differential Revision: [D35736977](https://our.internmc.facebook.com/intern/diff/D35736977) [ghstack-poisoned]
Testing to see what breaks Differential Revision: [D35736977](https://our.internmc.facebook.com/intern/diff/D35736977) [ghstack-poisoned]
|
@davidberard98 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
1 similar comment
|
@davidberard98 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Testing to see what breaks Differential Revision: [D35736977](https://our.internmc.facebook.com/intern/diff/D35736977) [ghstack-poisoned]
Testing to see what breaks Differential Revision: [D35736977](https://our.internmc.facebook.com/intern/diff/D35736977) [ghstack-poisoned]
|
@pytorchbot force merge this (Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally) |
|
Merge failed due to Matched rule NVFuser, but PR has not been reviewed yet |
|
@pytorchbot force merge this (Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally) |
|
Merge failed due to Matched rule NVFuser, but PR has not been reviewed yet |
|
@pytorchbot force merge this (Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally) |
|
Merge failed due to Matched rule NVFuser, but PR has not been reviewed yet |
|
@pytorchbot force merge this (Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally) |
|
Merge failed due to Matched rule NVFuser, but PR has not been reviewed yet |
|
@pytorchbot force merge this (Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally) |
|
Merge failed due to Matched rule NVFuser, but PR has not been reviewed yet |
|
@pytorchbot force merge this (Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally) |
|
Merge failed due to Matched rule NVFuser, but PR has not been reviewed yet |
|
@pytorchbot force merge this (Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally) |
|
Merge failed due to Matched rule NVFuser, but PR has not been reviewed yet |
|
@pytorchbot force merge this (Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally) |
|
Merge failed due to Matched rule NVFuser, but PR has not been reviewed yet |
|
@pytorchbot force merge this (Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally) |
|
Merge failed due to Matched rule NVFuser, but PR has not been reviewed yet |
|
@pytorchbot force merge this (Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally) |
|
Merge failed due to Matched rule NVFuser, but PR has not been reviewed yet |
|
Apologies for the spam here. For Meta engineers the fix is D36284533 |
Enable NVFuser in OSS. Tests are passing, and we've also run tests in [torchvision](pytorch/vision#5959) and [torchaudio](pytorch/audio#2372) Retry of #76006, because that PR had GH1/ghstack issues. [ghstack-poisoned]
Enable NVFuser in OSS. Tests are passing, and we've also run tests in [torchvision](pytorch/vision#5959) and [torchaudio](pytorch/audio#2372) Retry of #76006, because that PR had GH1/ghstack issues. ghstack-source-id: b1c68c1 Pull Request resolved: #77213
|
retrying in #77213 |
Enable NVFuser in OSS. Tests are passing, and we've also run tests in [torchvision](pytorch/vision#5959) and [torchaudio](pytorch/audio#2372) Retry of #76006, because that PR had GH1/ghstack issues. Pull Request resolved: #77213 Approved by: https://github.com/eellison
Summary: Enable NVFuser in OSS. Tests are passing, and we've also run tests in [torchvision](pytorch/vision#5959) and [torchaudio](pytorch/audio#2372) Retry of #76006, because that PR had GH1/ghstack issues. Pull Request resolved: #77213 Approved by: https://github.com/eellison Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/24f7dcd8161544fc55a19e3b471bd95d37f9ec18 Reviewed By: H-Huang Differential Revision: D36302686 Pulled By: H-Huang fbshipit-source-id: 2c380e46d8a532dfe0f52fb28d24ca310ffbc43a
Enable NVFuser in OSS. Tests are passing, and we've also run tests in [torchvision](pytorch/vision#5959) and [torchaudio](pytorch/audio#2372) Retry of pytorch#76006, because that PR had GH1/ghstack issues. Pull Request resolved: pytorch#77213 Approved by: https://github.com/eellison
Stack from ghstack:
Enable NVFuser in OSS.
Tests are passing, and we've also run tests in torchvision and torchaudio
Differential Revision: D35736977