Skip to content

[testing] Enable nvfuser#2372

Closed
davidberard98 wants to merge 2 commits intopytorch:mainfrom
davidberard98:nvfuser
Closed

[testing] Enable nvfuser#2372
davidberard98 wants to merge 2 commits intopytorch:mainfrom
davidberard98:nvfuser

Conversation

@davidberard98
Copy link
Copy Markdown

ahead of nvfuser enablement by default, we want to check for failures

Copy link
Copy Markdown
Contributor

@mthrok mthrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @davidberard98 - Does Windows matter? Windows CI jobs use similar but separate script here. https://github.com/pytorch/audio/blob/main/.circleci/unittest/windows/scripts/run_test.sh#L15

@davidberard98
Copy link
Copy Markdown
Author

thanks! we don't expect windows to be much different, but I added it anyway just in case

@davidberard98
Copy link
Copy Markdown
Author

davidberard98 commented May 10, 2022

To summarize the failures:

  • I didn't observe any NVFuser failures
  • Many jobs are failing, but they are also failing on other PRs opened around the same time.
  • Many CPU jobs began failing, but this is expected because the environment flag PYTORCH_JIT_ENABLE_NVFUSER=1 will attempt to turn on NVFuser, but NVFuser can't be turned on in cpu-only builds. When NVFuser is enabled by default, it will be enabled only on gpu configurations.

davidberard98 added a commit to pytorch/pytorch that referenced this pull request May 11, 2022
Enable NVFuser in OSS.

Tests are passing, and we've also run tests in [torchvision](pytorch/vision#5959) and [torchaudio](pytorch/audio#2372)

Retry of #76006, because that PR had GH1/ghstack issues.

[ghstack-poisoned]
davidberard98 added a commit to pytorch/pytorch that referenced this pull request May 11, 2022
Enable NVFuser in OSS.

Tests are passing, and we've also run tests in [torchvision](pytorch/vision#5959) and [torchaudio](pytorch/audio#2372)

Retry of #76006, because that PR had GH1/ghstack issues.

ghstack-source-id: b1c68c1
Pull Request resolved: #77213
pytorchmergebot pushed a commit to pytorch/pytorch that referenced this pull request May 11, 2022
Enable NVFuser in OSS.

Tests are passing, and we've also run tests in [torchvision](pytorch/vision#5959) and [torchaudio](pytorch/audio#2372)

Retry of #76006, because that PR had GH1/ghstack issues.

Pull Request resolved: #77213

Approved by: https://github.com/eellison
facebook-github-bot pushed a commit to pytorch/pytorch that referenced this pull request May 13, 2022
Summary:
Enable NVFuser in OSS.

Tests are passing, and we've also run tests in [torchvision](pytorch/vision#5959) and [torchaudio](pytorch/audio#2372)

Retry of #76006, because that PR had GH1/ghstack issues.

Pull Request resolved: #77213

Approved by: https://github.com/eellison

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/24f7dcd8161544fc55a19e3b471bd95d37f9ec18

Reviewed By: H-Huang

Differential Revision: D36302686

Pulled By: H-Huang

fbshipit-source-id: 2c380e46d8a532dfe0f52fb28d24ca310ffbc43a
jjsjann123 pushed a commit to jjsjann123/nvfuser that referenced this pull request Oct 29, 2022
Enable NVFuser in OSS.

Tests are passing, and we've also run tests in [torchvision](pytorch/vision#5959) and [torchaudio](pytorch/audio#2372)

Retry of #76006, because that PR had GH1/ghstack issues.

Pull Request resolved: pytorch/pytorch#77213

Approved by: https://github.com/eellison
jjsjann123 pushed a commit to jjsjann123/nvfuser that referenced this pull request Nov 10, 2022
Enable NVFuser in OSS.

Tests are passing, and we've also run tests in [torchvision](pytorch/vision#5959) and [torchaudio](pytorch/audio#2372)

Retry of #76006, because that PR had GH1/ghstack issues.

Pull Request resolved: pytorch/pytorch#77213

Approved by: https://github.com/eellison
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 25, 2026
Enable NVFuser in OSS.

Tests are passing, and we've also run tests in [torchvision](pytorch/vision#5959) and [torchaudio](pytorch/audio#2372)

Retry of pytorch#76006, because that PR had GH1/ghstack issues.

Pull Request resolved: pytorch#77213

Approved by: https://github.com/eellison
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants