Skip to content

retry - enable NVFuser by default#77579

Closed
davidberard98 wants to merge 1 commit intogh/davidberard98/117/basefrom
gh/davidberard98/117/head
Closed

retry - enable NVFuser by default#77579
davidberard98 wants to merge 1 commit intogh/davidberard98/117/basefrom
gh/davidberard98/117/head

Conversation

@davidberard98
Copy link
Copy Markdown
Contributor

@davidberard98 davidberard98 commented May 16, 2022

Stack from ghstack:

Enable NVFuser in OSS.

Retry of #77213, because it was breaking torchvision tests.

Fix in #77471 is being verified by @jjsjann123

Summary on on-by-default testing: https://github.com/csarofeen/pytorch/wiki/on-by-default-testing-for-PyTorch-1.12-release

Enable NVFuser in OSS.

Retry of #77213, because it was breaking torchvision tests.

Fix in #77471 has been verified by @jjsjann123

[ghstack-poisoned]
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 16, 2022

🔗 Helpful links

✅ No Failures (17 Pending)

As of commit 34a3e82 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

davidberard98 added a commit that referenced this pull request May 16, 2022
Enable NVFuser in OSS.

Retry of #77213, because it was breaking torchvision tests.

Fix in #77471 has been verified by jjsjann123

ghstack-source-id: 642e7cf
Pull Request resolved: #77579
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label May 16, 2022
Copy link
Copy Markdown
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but can we please share link to config where torchvision test is validated?

@davidberard98
Copy link
Copy Markdown
Contributor Author

cc @jjsjann123 can you edit the commit description with the test results?

@davidberard98
Copy link
Copy Markdown
Contributor Author

@pytorchbot merge this please

@github-actions
Copy link
Copy Markdown
Contributor

Hey @davidberard98.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

atalman pushed a commit that referenced this pull request May 20, 2022
Enable NVFuser in OSS.

Retry of #77213, because it was breaking torchvision tests.

Fix in #77471 has been verified by jjsjann123

Pull Request resolved: #77579

Approved by: https://github.com/eellison, https://github.com/malfet, https://github.com/atalman, https://github.com/seemethere
facebook-github-bot pushed a commit that referenced this pull request May 23, 2022
Summary:
Enable NVFuser in OSS.

Retry of #77213, because it was breaking torchvision tests.

Fix in #77471 has been verified by jjsjann123

Pull Request resolved: #77579

Approved by: https://github.com/eellison, https://github.com/malfet, https://github.com/atalman, https://github.com/seemethere

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/38bc10ae25c6fd2f445926fdee148ac19a4a1c08

Reviewed By: seemethere

Differential Revision: D36552636

Pulled By: seemethere

fbshipit-source-id: 3ee5eb9ad5ee2638ef75105a366d90db54b0b436
@facebook-github-bot facebook-github-bot deleted the gh/davidberard98/117/head branch May 24, 2022 14:17
jjsjann123 pushed a commit to jjsjann123/nvfuser that referenced this pull request Oct 29, 2022
Enable NVFuser in OSS.

Retry of #77213, because it was breaking torchvision tests.

Fix in #77471 has been verified by jjsjann123

Pull Request resolved: pytorch/pytorch#77579

Approved by: https://github.com/eellison, https://github.com/malfet, https://github.com/atalman, https://github.com/seemethere
jjsjann123 pushed a commit to jjsjann123/nvfuser that referenced this pull request Nov 10, 2022
Enable NVFuser in OSS.

Retry of #77213, because it was breaking torchvision tests.

Fix in #77471 has been verified by jjsjann123

Pull Request resolved: pytorch/pytorch#77579

Approved by: https://github.com/eellison, https://github.com/malfet, https://github.com/atalman, https://github.com/seemethere
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 25, 2026
Enable NVFuser in OSS.

Retry of pytorch#77213, because it was breaking torchvision tests.

Fix in pytorch#77471 has been verified by jjsjann123

Pull Request resolved: pytorch#77579

Approved by: https://github.com/eellison, https://github.com/malfet, https://github.com/atalman, https://github.com/seemethere
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants