Make mv and addmv support torch.float16#75220
Closed
lezcano wants to merge 5 commits intogh/Lezcano/61/basefrom
Closed
Make mv and addmv support torch.float16#75220lezcano wants to merge 5 commits intogh/Lezcano/61/basefrom
lezcano wants to merge 5 commits intogh/Lezcano/61/basefrom
Conversation
In the next PR of this stack we're changing the use of an at::mm by an at::mv. For us to be able to do this, we need at::mv to support the same input dtypes as at::mm. [ghstack-poisoned]
Closed
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 60dde5d (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Apr 4, 2022
Closed
In the next PR of this stack we're changing the use of an at::mm by an at::mv. For us to be able to do this, we need at::mv to support the same input dtypes as at::mm. [ghstack-poisoned]
In the next PR of this stack we're changing the use of an at::mm by an at::mv. For us to be able to do this, we need at::mv to support the same input dtypes as at::mm. [ghstack-poisoned]
In the next PR of this stack we're changing the use of an at::mm by an at::mv. For us to be able to do this, we need at::mv to support the same input dtypes as at::mm. [ghstack-poisoned]
In the next PR of this stack we're changing the use of an at::mm by an at::mv. For us to be able to do this, we need at::mv to support the same input dtypes as at::mm. [ghstack-poisoned]
Collaborator
Collaborator
Author
|
I'm happy with the hard break, as it's better to break hard than to silently give wrong results, but let's see what Mike has to say. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
In the next PR of this stack we're changing the use of an at::mm by an
at::mv. For us to be able to do this, we need at::mv to support the same
input dtypes as at::mm.